* [U-Boot] [PATCH v2 2/4] patman: Add meaningful statements instead of blah blah
@ 2012-04-27 16:39 Vikram Narayanan
2012-04-30 7:44 ` Wolfgang Denk
0 siblings, 1 reply; 3+ messages in thread
From: Vikram Narayanan @ 2012-04-27 16:39 UTC (permalink / raw)
To: u-boot
Add example statements for commit message and series messages
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
tools/patman/README | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/patman/README b/tools/patman/README
index d9820ab..d98f081 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -132,16 +132,15 @@ Series-prefix: prefix
Cover-letter:
This is the patch set title
-blah blah
-more blah blah
+This patch set fixes the errors when CONFIG_xxx is enabled.
+Tested on xyz board.
END
Sets the cover letter contents for the series. The first line
will become the subject of the cover letter
Series-notes:
-blah blah
-blah blah
-more blah blah
+Sorry that I couldn't find time to reply for the comments posted on the v1 of my
+patch. This patch supersedes v1. Please comment.
END
Sets some notes for the patch series, which you don't want in
the commit messages, but do want to send, The notes are joined
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 2/4] patman: Add meaningful statements instead of blah blah
2012-04-27 16:39 [U-Boot] [PATCH v2 2/4] patman: Add meaningful statements instead of blah blah Vikram Narayanan
@ 2012-04-30 7:44 ` Wolfgang Denk
2012-04-30 13:35 ` Vikram Narayanan
0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2012-04-30 7:44 UTC (permalink / raw)
To: u-boot
Dear Vikram Narayanan,
In message <4F9ACBB8.2040408@gmail.com> you wrote:
> Add example statements for commit message and series messages
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> tools/patman/README | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tools/patman/README b/tools/patman/README
> index d9820ab..d98f081 100644
> --- a/tools/patman/README
> +++ b/tools/patman/README
> @@ -132,16 +132,15 @@ Series-prefix: prefix
>
> Cover-letter:
> This is the patch set title
> -blah blah
> -more blah blah
> +This patch set fixes the errors when CONFIG_xxx is enabled.
> +Tested on xyz board.
> END
> Sets the cover letter contents for the series. The first line
> will become the subject of the cover letter
>
> Series-notes:
> -blah blah
> -blah blah
> -more blah blah
> +Sorry that I couldn't find time to reply for the comments posted on the v1 of my
> +patch. This patch supersedes v1. Please comment.
> END
> Sets some notes for the patch series, which you don't want in
> the commit messages, but do want to send, The notes are joined
I'm not sure this is an improvement. Your example messages are pretty
much specific, so people in completely different situations will not
find much help in them either.
I suggest we leave the text as is. What do you think?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust. We trust you will pay in advance.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 2/4] patman: Add meaningful statements instead of blah blah
2012-04-30 7:44 ` Wolfgang Denk
@ 2012-04-30 13:35 ` Vikram Narayanan
0 siblings, 0 replies; 3+ messages in thread
From: Vikram Narayanan @ 2012-04-30 13:35 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
On 4/30/2012 1:14 PM, Wolfgang Denk wrote:
> Dear Vikram Narayanan,
>
> In message<4F9ACBB8.2040408@gmail.com> you wrote:
>> Add example statements for commit message and series messages
>>
>> Signed-off-by: Vikram Narayanan<vikram186@gmail.com>
>> Cc: Simon Glass<sjg@chromium.org>
>> ---
>> tools/patman/README | 9 ++++-----
>> 1 files changed, 4 insertions(+), 5 deletions(-)
>>
<snip>
> I'm not sure this is an improvement. Your example messages are pretty
> much specific, so people in completely different situations will not
> find much help in them either.
>
> I suggest we leave the text as is. What do you think?
Yes. Then, its better to leave as it is.
Regards,
Vikram
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-30 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-27 16:39 [U-Boot] [PATCH v2 2/4] patman: Add meaningful statements instead of blah blah Vikram Narayanan
2012-04-30 7:44 ` Wolfgang Denk
2012-04-30 13:35 ` Vikram Narayanan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.