All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Yilu Mao <ylmao@marvell.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"Baohua.Song@csr.com" <Baohua.Song@csr.com>,
	"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>,
	"robherring2@gmail.com" <robherring2@gmail.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Ning Jiang <njiang1@marvell.com>
Subject: Re: [PATCH] ARM: cache-l2x0.c: save aux ctrl for resume in case that l2x0 is enabled before init
Date: Mon, 30 Apr 2012 13:11:26 +0100	[thread overview]
Message-ID: <20120430121125.GN10632@arm.com> (raw)
In-Reply-To: <4F9B8D1C.6090400@marvell.com>

On Sat, Apr 28, 2012 at 07:24:28AM +0100, Yilu Mao wrote:
> Do you agree with this patch to be merged?

I would rather re-read the aux_ctrl register again after it was set (if
L2 is disabled) and store this value. It makes sense if some of the bits
are reserved, at least we have the real value.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cache-l2x0.c: save aux ctrl for resume in case that l2x0 is enabled before init
Date: Mon, 30 Apr 2012 13:11:26 +0100	[thread overview]
Message-ID: <20120430121125.GN10632@arm.com> (raw)
In-Reply-To: <4F9B8D1C.6090400@marvell.com>

On Sat, Apr 28, 2012 at 07:24:28AM +0100, Yilu Mao wrote:
> Do you agree with this patch to be merged?

I would rather re-read the aux_ctrl register again after it was set (if
L2 is disabled) and store this value. It makes sense if some of the bits
are reserved, at least we have the real value.

-- 
Catalin

  reply	other threads:[~2012-04-30 12:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  2:41 [PATCH] ARM: cache-l2x0.c: save aux ctrl for resume in case that l2x0 is enabled before init Yilu Mao
2012-04-24  2:41 ` Yilu Mao
2012-04-24  8:28 ` Catalin Marinas
2012-04-24  8:28   ` Catalin Marinas
2012-04-26  5:00   ` Yilu Mao
2012-04-26  5:00     ` Yilu Mao
2012-04-26  8:35     ` Catalin Marinas
2012-04-26  8:35       ` Catalin Marinas
2012-04-26  9:25       ` Yilu Mao
2012-04-26  9:25         ` Yilu Mao
2012-04-26  9:44         ` Catalin Marinas
2012-04-26  9:44           ` Catalin Marinas
2012-04-26 10:09           ` Yilu Mao
2012-04-26 10:09             ` Yilu Mao
2012-04-26 10:28             ` Catalin Marinas
2012-04-26 10:28               ` Catalin Marinas
2012-04-26 10:35               ` Yilu Mao
2012-04-26 10:35                 ` Yilu Mao
2012-04-26 10:38                 ` Catalin Marinas
2012-04-26 10:38                   ` Catalin Marinas
2012-04-26 10:48                   ` Yilu Mao
2012-04-26 10:48                     ` Yilu Mao
2012-04-26 10:56                     ` Catalin Marinas
2012-04-26 10:56                       ` Catalin Marinas
2012-04-26 11:03                       ` Yilu Mao
2012-04-26 11:03                         ` Yilu Mao
2012-04-28  6:24                         ` Yilu Mao
2012-04-28  6:24                           ` Yilu Mao
2012-04-30 12:11                           ` Catalin Marinas [this message]
2012-04-30 12:11                             ` Catalin Marinas
2012-04-30 13:22                             ` Yilu Mao
2012-04-30 13:22                               ` Yilu Mao
2012-04-26  5:09   ` Yilu Mao
2012-04-26  5:09     ` Yilu Mao
  -- strict thread matches above, loose matches on Subject: below --
2012-04-23  7:43 Yilu Mao
2012-04-23  7:43 ` Yilu Mao
2012-04-23 11:19 ` Sergei Shtylyov
2012-04-23 11:19   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120430121125.GN10632@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Baohua.Song@csr.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=njiang1@marvell.com \
    --cc=robherring2@gmail.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=ylmao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.