* [U-Boot] [PATCH] image/fit: drop inline markings on parser code
@ 2012-04-22 16:59 Mike Frysinger
2012-04-30 14:39 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2012-04-22 16:59 UTC (permalink / raw)
To: u-boot
Putting "inline" on extern funcs makes no sense, so drop them.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
common/image.c | 4 ++--
include/image.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/image.c b/common/image.c
index 342b315..91954ac 100644
--- a/common/image.c
+++ b/common/image.c
@@ -1829,7 +1829,7 @@ static int fit_parse_spec(const char *spec, char sepc, ulong addr_curr,
* addr and conf_name are set accordingly
* 0 otherwise
*/
-inline int fit_parse_conf(const char *spec, ulong addr_curr,
+int fit_parse_conf(const char *spec, ulong addr_curr,
ulong *addr, const char **conf_name)
{
return fit_parse_spec(spec, '#', addr_curr, addr, conf_name);
@@ -1855,7 +1855,7 @@ inline int fit_parse_conf(const char *spec, ulong addr_curr,
* addr and image_name are set accordingly
* 0 otherwise
*/
-inline int fit_parse_subimage(const char *spec, ulong addr_curr,
+int fit_parse_subimage(const char *spec, ulong addr_curr,
ulong *addr, const char **image_name)
{
return fit_parse_spec(spec, ':', addr_curr, addr, image_name);
diff --git a/include/image.h b/include/image.h
index a1c6e4e..aa9daa2 100644
--- a/include/image.h
+++ b/include/image.h
@@ -531,9 +531,9 @@ static inline int image_check_target_arch(const image_header_t *hdr)
#define FIT_MAX_HASH_LEN 20 /* max(crc32_len(4), sha1_len(20)) */
/* cmdline argument format parsing */
-inline int fit_parse_conf(const char *spec, ulong addr_curr,
+int fit_parse_conf(const char *spec, ulong addr_curr,
ulong *addr, const char **conf_name);
-inline int fit_parse_subimage(const char *spec, ulong addr_curr,
+int fit_parse_subimage(const char *spec, ulong addr_curr,
ulong *addr, const char **image_name);
void fit_print_contents(const void *fit);
--
1.7.8.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] image/fit: drop inline markings on parser code
2012-04-22 16:59 [U-Boot] [PATCH] image/fit: drop inline markings on parser code Mike Frysinger
@ 2012-04-30 14:39 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2012-04-30 14:39 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1335113946-21136-1-git-send-email-vapier@gentoo.org> you wrote:
> Putting "inline" on extern funcs makes no sense, so drop them.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/image.c | 4 ++--
> include/image.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The last thing one knows in constructing a work is what to put first.
- Blaise Pascal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-30 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-22 16:59 [U-Boot] [PATCH] image/fit: drop inline markings on parser code Mike Frysinger
2012-04-30 14:39 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.