All of lore.kernel.org
 help / color / mirror / Atom feed
* "smsc911x: Add fixed board regulators" problem
@ 2012-04-30 14:58 Enrico
  2012-04-30 16:11 ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Enrico @ 2012-04-30 14:58 UTC (permalink / raw)
  To: linux-omap; +Cc: Russ Dill, Enric Balletbo i Serra

Hi,

hi get this at boot on an IGEP board (igep0020), latest linux-omap
master (20 Apr):

[    0.047704] WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
[    0.047712] sysfs: cannot create duplicate filename
'/devices/platform/reg-fixed-voltage.0'
[    0.047720] Modules linked in:
[    0.047754] [<c0012dd0>] (unwind_backtrace+0x0/0xf8) from
[<c002d694>] (warn_slowpath_common+0x54/0x64)
[    0.047772] [<c002d694>] (warn_slowpath_common+0x54/0x64) from
[<c002d738>] (warn_slowpath_fmt+0x30/0x40)
[    0.047788] [<c002d738>] (warn_slowpath_fmt+0x30/0x40) from
[<c01065e8>] (sysfs_add_one+0x9c/0xac)
[    0.047804] [<c01065e8>] (sysfs_add_one+0x9c/0xac) from
[<c01067c0>] (create_dir+0x60/0xb4)
[    0.047817] [<c01067c0>] (create_dir+0x60/0xb4) from [<c0106b2c>]
(sysfs_create_dir+0x90/0xe8)
[    0.047838] [<c0106b2c>] (sysfs_create_dir+0x90/0xe8) from
[<c0218c80>] (kobject_add_internal+0x88/0x200)
[    0.047856] [<c0218c80>] (kobject_add_internal+0x88/0x200) from
[<c02191c4>] (kobject_add+0x50/0x98)
[    0.047880] [<c02191c4>] (kobject_add+0x50/0x98) from [<c025dd74>]
(device_add+0xcc/0x5a4)
[    0.047900] [<c025dd74>] (device_add+0xcc/0x5a4) from [<c026195c>]
(platform_device_add+0x108/0x1b4)
[    0.047916] [<c026195c>] (platform_device_add+0x108/0x1b4) from
[<c0261b28>] (platform_add_devices+0x34/0x60)
[    0.047935] [<c0261b28>] (platform_add_devices+0x34/0x60) from
[<c056cdc0>] (igep_init+0x2ec/0x768)
[    0.047956] [<c056cdc0>] (igep_init+0x2ec/0x768) from [<c05635e0>]
(customize_machine+0x20/0x28)
[    0.047974] [<c05635e0>] (customize_machine+0x20/0x28) from
[<c00086e4>] (do_one_initcall+0x34/0x174)
[    0.047990] [<c00086e4>] (do_one_initcall+0x34/0x174) from
[<c05608d8>] (kernel_init+0x13c/0x1e8)
[    0.048009] [<c05608d8>] (kernel_init+0x13c/0x1e8) from
[<c000e80c>] (kernel_thread_exit+0x0/0x8)
[    0.048044] ---[ end trace 1b75b31a2719ed1c ]---
[    0.048055] ------------[ cut here ]------------
[    0.048066] WARNING: at lib/kobject.c:198 kobject_add_internal+0x1fc/0x200()
[    0.048075] kobject_add_internal failed for reg-fixed-voltage.0
with -EEXIST, don't try to register things with the same name in the
same directory.
[    0.048086] Modules linked in:
[    0.048099] [<c0012dd0>] (unwind_backtrace+0x0/0xf8) from
[<c002d694>] (warn_slowpath_common+0x54/0x64)
[    0.048116] [<c002d694>] (warn_slowpath_common+0x54/0x64) from
[<c002d738>] (warn_slowpath_fmt+0x30/0x40)
[    0.048132] [<c002d738>] (warn_slowpath_fmt+0x30/0x40) from
[<c0218df4>] (kobject_add_internal+0x1fc/0x200)
[    0.048148] [<c0218df4>] (kobject_add_internal+0x1fc/0x200) from
[<c02191c4>] (kobject_add+0x50/0x98)
[    0.048165] [<c02191c4>] (kobject_add+0x50/0x98) from [<c025dd74>]
(device_add+0xcc/0x5a4)
[    0.048181] [<c025dd74>] (device_add+0xcc/0x5a4) from [<c026195c>]
(platform_device_add+0x108/0x1b4)
[    0.048196] [<c026195c>] (platform_device_add+0x108/0x1b4) from
[<c0261b28>] (platform_add_devices+0x34/0x60)
[    0.048212] [<c0261b28>] (platform_add_devices+0x34/0x60) from
[<c056cdc0>] (igep_init+0x2ec/0x768)
[    0.048227] [<c056cdc0>] (igep_init+0x2ec/0x768) from [<c05635e0>]
(customize_machine+0x20/0x28)
[    0.048242] [<c05635e0>] (customize_machine+0x20/0x28) from
[<c00086e4>] (do_one_initcall+0x34/0x174)
[    0.048257] [<c00086e4>] (do_one_initcall+0x34/0x174) from
[<c05608d8>] (kernel_init+0x13c/0x1e8)
[    0.048273] [<c05608d8>] (kernel_init+0x13c/0x1e8) from
[<c000e80c>] (kernel_thread_exit+0x0/0x8)

and

[    2.430117] WARNING: at drivers/regulator/core.c:1551
_regulator_disable+0xfc/0x15c()
[    2.438316] unbalanced disables for dummy
[    2.442523] Modules linked in:
[    2.445747] [<c0012dd0>] (unwind_backtrace+0x0/0xf8) from
[<c002d694>] (warn_slowpath_common+0x54/0x64)
[    2.455607] [<c002d694>] (warn_slowpath_common+0x54/0x64) from
[<c002d738>] (warn_slowpath_fmt+0x30/0x40)
[    2.465647] [<c002d738>] (warn_slowpath_fmt+0x30/0x40) from
[<c0236fc4>] (_regulator_disable+0xfc/0x15c)
[    2.475596] [<c0236fc4>] (_regulator_disable+0xfc/0x15c) from
[<c0237040>] (regulator_disable+0x1c/0x48)
[    2.485552] [<c0237040>] (regulator_disable+0x1c/0x48) from
[<c02eb700>] (omap_hsmmc_set_power+0x90/0x118)
[    2.495689] [<c02eb700>] (omap_hsmmc_set_power+0x90/0x118) from
[<c03e8448>] (omap_hsmmc_probe+0x70c/0x9d0)
[    2.505914] [<c03e8448>] (omap_hsmmc_probe+0x70c/0x9d0) from
[<c0261408>] (platform_drv_probe+0x18/0x1c)
[    2.515860] [<c0261408>] (platform_drv_probe+0x18/0x1c) from
[<c0260230>] (driver_probe_device+0xa0/0x224)
[    2.525988] [<c0260230>] (driver_probe_device+0xa0/0x224) from
[<c0260440>] (__driver_attach+0x8c/0x90)
[    2.535842] [<c0260440>] (__driver_attach+0x8c/0x90) from
[<c025ec74>] (bus_for_each_dev+0x50/0x7c)
[    2.545331] [<c025ec74>] (bus_for_each_dev+0x50/0x7c) from
[<c025f95c>] (bus_add_driver+0xa4/0x23c)
[    2.554821] [<c025f95c>] (bus_add_driver+0xa4/0x23c) from
[<c0260968>] (driver_register+0x78/0x12c)
[    2.564310] [<c0260968>] (driver_register+0x78/0x12c) from
[<c00086e4>] (do_one_initcall+0x34/0x174)
[    2.573895] [<c00086e4>] (do_one_initcall+0x34/0x174) from
[<c05608d8>] (kernel_init+0x13c/0x1e8)
[    2.583208] [<c05608d8>] (kernel_init+0x13c/0x1e8) from
[<c000e80c>] (kernel_thread_exit+0x0/0x8)
[    2.592510] ---[ end trace 1b75b31a2719ed1e ]---
[    2.598821] omap_hsmmc omap_hsmmc.1: could not set regulator OCR (-22)


Reverting the patch in subject (commit
5b3689f4c16bc692a2e2b9808e5efc457aeae371) fixes it. In both cases
network works (it boots from nfs).

I doubt it's a proper fix, but i don't know where to look at...any ideas?

Enrico

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: "smsc911x: Add fixed board regulators" problem
  2012-04-30 14:58 "smsc911x: Add fixed board regulators" problem Enrico
@ 2012-04-30 16:11 ` Tony Lindgren
  2012-04-30 16:39   ` Enrico
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2012-04-30 16:11 UTC (permalink / raw)
  To: Enrico; +Cc: linux-omap, Russ Dill, Enric Balletbo i Serra

Hi,

* Enrico <ebutera@users.sourceforge.net> [120430 08:02]:
> Hi,
> 
> hi get this at boot on an IGEP board (igep0020), latest linux-omap
> master (20 Apr):
> 
> [    0.047704] WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
> [    0.047712] sysfs: cannot create duplicate filename
> '/devices/platform/reg-fixed-voltage.0'

This is because of trying to create multiple fixed regulators with
id 0 as discussed earlier. AFAIK there's still no clean way to deal
with that unfortunately..

Can you try changing the id to something random like below?

Regards,

Tony


--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -641,7 +641,7 @@ static struct regulator_consumer_supply dummy_supplies[] = {
 
 static void __init igep_init(void)
 {
-	regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
+	regulator_register_fixed(42, dummy_supplies, ARRAY_SIZE(dummy_supplies));
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 
 	/* Get IGEP2 hardware revision */

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: "smsc911x: Add fixed board regulators" problem
  2012-04-30 16:11 ` Tony Lindgren
@ 2012-04-30 16:39   ` Enrico
  0 siblings, 0 replies; 3+ messages in thread
From: Enrico @ 2012-04-30 16:39 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap, Russ Dill, Enric Balletbo i Serra

On Mon, Apr 30, 2012 at 6:11 PM, Tony Lindgren <tony@atomide.com> wrote:
> Hi,
>
> * Enrico <ebutera@users.sourceforge.net> [120430 08:02]:
>> Hi,
>>
>> hi get this at boot on an IGEP board (igep0020), latest linux-omap
>> master (20 Apr):
>>
>> [    0.047704] WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
>> [    0.047712] sysfs: cannot create duplicate filename
>> '/devices/platform/reg-fixed-voltage.0'
>
> This is because of trying to create multiple fixed regulators with
> id 0 as discussed earlier. AFAIK there's still no clean way to deal
> with that unfortunately..
>
> Can you try changing the id to something random like below?

Sorry i must have missed the discussion, i used 40 and it works. I'll
send a patch.

Thanks,

Enrico
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-30 16:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-30 14:58 "smsc911x: Add fixed board regulators" problem Enrico
2012-04-30 16:11 ` Tony Lindgren
2012-04-30 16:39   ` Enrico

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.