All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Preston Fick <pffick@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, preston.fick@silabs.com
Subject: Re: [PATCH 3/3] usb: cp210x: Add ioctl for GPIO support
Date: Wed, 2 May 2012 21:49:01 +0100	[thread overview]
Message-ID: <20120502214901.6b6e031c@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120502200356.GA25915@kroah.com>

> Actually, why can't you use the GPIO subsystem for something like this?
> Can't you export your device as both a usb-serial device and a gpio
> device and have things work properly that way?

You still need the ioctls even then in order to discover the gpio
numbers, and having done that youi've got potential races with unload
when you try and open them. You've also got permissions considerations
and synchronization between gpio and data problems.

It's not a good way to go. It might make sense in some platforms to
expose them as both but its not a good general model.

I'm currently favouring adding some 'additional control line' bits to
termiox.

  reply	other threads:[~2012-05-02 20:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-01  4:06 [PATCH 1/3] usb: cp210x: Corrected USB request type definitions Preston Fick
2012-05-01  4:06 ` [PATCH 2/3] usb: cp210x: Added in support to get and store part number Preston Fick
2012-05-01 16:16   ` Sergei Shtylyov
2012-05-02 20:04     ` Greg KH
2012-05-02 20:04       ` Greg KH
2012-05-01  4:06 ` [PATCH 3/3] usb: cp210x: Add ioctl for GPIO support Preston Fick
2012-05-02 20:03   ` Greg KH
2012-05-02 20:49     ` Alan Cox [this message]
2012-05-02 21:52       ` Greg KH
2012-05-02 22:10         ` Alan Cox
2012-05-02 22:27           ` Greg KH
2012-05-02 22:59             ` Alan Cox
2012-05-03  8:58 ` [PATCH 1/3] usb: cp210x: Corrected USB request type definitions Bjørn Mork
2012-05-08 13:56   ` Preston Fick
2012-05-08 13:56     ` Preston Fick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120502214901.6b6e031c@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pffick@gmail.com \
    --cc=preston.fick@silabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.