From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Preston Fick <pffick@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
preston.fick@silabs.com
Subject: Re: [PATCH 2/3] usb: cp210x: Added in support to get and store part number
Date: Tue, 01 May 2012 20:16:09 +0400 [thread overview]
Message-ID: <4FA00C49.7000105@mvista.com> (raw)
In-Reply-To: <1335845210-5147-2-git-send-email-preston.fick@silabs.com>
Hello.
On 01-05-2012 8:06, Preston Fick wrote:
> This change gets the part number of the device when the driver is loaded and
> stores it in the private portion of the port structure. This addition will
> allow for part specific functionality to be added to the driver if needed.
> Signed-off-by: Preston Fick<preston.fick@silabs.com>
> ---
> drivers/usb/serial/cp210x.c | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e67ccf3..b3646b8 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
[...]
> @@ -862,6 +874,7 @@ static int cp210x_startup(struct usb_serial *serial)
> {
> struct cp210x_port_private *port_priv;
> int i;
> + unsigned int partNum;
>
> /* cp210x buffers behave strangely unless device is reset */
> usb_reset_device(serial->dev);
> @@ -876,6 +889,17 @@ static int cp210x_startup(struct usb_serial *serial)
> serial->interface->cur_altsetting->desc.bInterfaceNumber;
>
> usb_set_serial_port_data(serial->port[i], port_priv);
> +
> + /* Get the 1-byte part number of the cp210x device */
> + usb_control_msg(serial->dev,
This may involve DMA...
> + usb_rcvctrlpipe(serial->dev, 0),
> + CP210X_VENDOR_SPECIFIC,
> + REQTYPE_DEVICE_TO_HOST,
> + CP210X_GET_PARTNUM,
> + port_priv->bInterfaceNumber,
> + &partNum, 1,
You can't do DMA to a buffer situated on stack. You should kmalloc() the
buffer.
> + USB_CTRL_GET_TIMEOUT);
> + port_priv->bPartNumber = partNum& 0xFF;
> }
>
> return 0;
WBR, Sergei
next prev parent reply other threads:[~2012-05-01 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 4:06 [PATCH 1/3] usb: cp210x: Corrected USB request type definitions Preston Fick
2012-05-01 4:06 ` [PATCH 2/3] usb: cp210x: Added in support to get and store part number Preston Fick
2012-05-01 16:16 ` Sergei Shtylyov [this message]
2012-05-02 20:04 ` Greg KH
2012-05-02 20:04 ` Greg KH
2012-05-01 4:06 ` [PATCH 3/3] usb: cp210x: Add ioctl for GPIO support Preston Fick
2012-05-02 20:03 ` Greg KH
2012-05-02 20:49 ` Alan Cox
2012-05-02 21:52 ` Greg KH
2012-05-02 22:10 ` Alan Cox
2012-05-02 22:27 ` Greg KH
2012-05-02 22:59 ` Alan Cox
2012-05-03 8:58 ` [PATCH 1/3] usb: cp210x: Corrected USB request type definitions Bjørn Mork
2012-05-08 13:56 ` Preston Fick
2012-05-08 13:56 ` Preston Fick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA00C49.7000105@mvista.com \
--to=sshtylyov@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pffick@gmail.com \
--cc=preston.fick@silabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.