All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Rob Landley <rob@landley.net>, Richard Purdie <rpurdie@rpsys.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/4] mfd: add LM3533 lighting-power core driver
Date: Thu, 3 May 2012 19:14:02 +0200	[thread overview]
Message-ID: <20120503171402.GG15752@localhost> (raw)
In-Reply-To: <20120503165748.GS3955@opensource.wolfsonmicro.com>

On Thu, May 03, 2012 at 05:57:49PM +0100, Mark Brown wrote:
> On Thu, May 03, 2012 at 06:54:37PM +0200, Johan Hovold wrote:
> > On Thu, May 03, 2012 at 04:24:07PM +0100, Mark Brown wrote:
> 
> > > I'm not sure exactly which control that is?
> 
> > That would be the output_lvled[n] (n = 1..5) attributes. For example, to
> > have all five low-voltage sinks blink synchronously, you could assign 0
> > to all these five attributes, and set a timer trigger for the led device
> > which has id 0.
> 
> Sorry, I meant "what exactly does this do in hardware".

>From the datasheet (page 14):

	"CONTROL BANK MAPPING
	 Control of the LM3533's current sinks is not done directly, but
	 through the programming of Control Banks. The current sinks are
	 then assigned to the programmed Control Bank. This allows for
	 a wide variety of current control possibilities where LEDs can
	 be grouped and controlled via specific Control Banks (see
	 Figure 3)."

It is the control banks that has a brightness settings or can be
programmed to blink, that is, they correspond to the logical LEDs and
backlights.

Assigning a current sink to a control bank corresponds, then, to
setting, for example, output_lvled3 to (led) 1.

[ Figure 3 on page 16 of the data sheet may be instructive. In the
  figure,  BANK A and B corresponds to the two backlight devices, and
  BANK C through F corresponds to the four led devices. Note that there
  are more outputs (current sinks) than control banks. ]

Thanks,
Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <jhovold@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Rob Landley <rob@landley.net>, Richard Purdie <rpurdie@rpsys.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/4] mfd: add LM3533 lighting-power core driver
Date: Thu, 03 May 2012 17:14:02 +0000	[thread overview]
Message-ID: <20120503171402.GG15752@localhost> (raw)
In-Reply-To: <20120503165748.GS3955@opensource.wolfsonmicro.com>

On Thu, May 03, 2012 at 05:57:49PM +0100, Mark Brown wrote:
> On Thu, May 03, 2012 at 06:54:37PM +0200, Johan Hovold wrote:
> > On Thu, May 03, 2012 at 04:24:07PM +0100, Mark Brown wrote:
> 
> > > I'm not sure exactly which control that is?
> 
> > That would be the output_lvled[n] (n = 1..5) attributes. For example, to
> > have all five low-voltage sinks blink synchronously, you could assign 0
> > to all these five attributes, and set a timer trigger for the led device
> > which has id 0.
> 
> Sorry, I meant "what exactly does this do in hardware".

From the datasheet (page 14):

	"CONTROL BANK MAPPING
	 Control of the LM3533's current sinks is not done directly, but
	 through the programming of Control Banks. The current sinks are
	 then assigned to the programmed Control Bank. This allows for
	 a wide variety of current control possibilities where LEDs can
	 be grouped and controlled via specific Control Banks (see
	 Figure 3)."

It is the control banks that has a brightness settings or can be
programmed to blink, that is, they correspond to the logical LEDs and
backlights.

Assigning a current sink to a control bank corresponds, then, to
setting, for example, output_lvled3 to (led) 1.

[ Figure 3 on page 16 of the data sheet may be instructive. In the
  figure,  BANK A and B corresponds to the two backlight devices, and
  BANK C through F corresponds to the four led devices. Note that there
  are more outputs (current sinks) than control banks. ]

Thanks,
Johan

  reply	other threads:[~2012-05-03 17:14 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 15:30 [PATCH 0/4] mfd: add LM3533 lighting-power chip driver Johan Hovold
2012-04-20 15:30 ` Johan Hovold
2012-04-20 15:30 ` [PATCH 1/4] mfd: add LM3533 lighting-power core driver Johan Hovold
2012-04-20 15:30   ` Johan Hovold
2012-04-26 12:41   ` Mark Brown
2012-04-26 12:41     ` Mark Brown
2012-05-03 10:15     ` Johan Hovold
2012-05-03 10:15       ` Johan Hovold
2012-05-03 10:22     ` Johan Hovold
2012-05-03 10:22       ` Johan Hovold
2012-04-20 15:30 ` [PATCH 2/4] misc: add LM3533 ambient light sensor driver Johan Hovold
2012-04-20 15:30   ` Johan Hovold
2012-04-20 15:57   ` Greg Kroah-Hartman
2012-04-20 15:57     ` Greg Kroah-Hartman
2012-04-20 17:28     ` Johan Hovold
2012-04-20 17:28       ` Johan Hovold
2012-04-20 17:37       ` Greg Kroah-Hartman
2012-04-20 17:37         ` Greg Kroah-Hartman
2012-04-26 11:52         ` Johan Hovold
2012-04-26 11:52           ` Johan Hovold
2012-04-20 15:30 ` [PATCH 3/4] leds: add LM3533 LED driver Johan Hovold
2012-04-20 15:30   ` Johan Hovold
2012-04-20 16:10   ` Arnd Bergmann
2012-04-20 16:45     ` Johan Hovold
2012-04-20 16:45       ` Johan Hovold
2012-04-20 15:30 ` [PATCH 4/4] backlight: add LM3533 backlight driver Johan Hovold
2012-04-20 15:30   ` Johan Hovold
2012-05-03 10:26 ` [PATCH v2 0/4] mfd: add LM3533 lighting-power chip driver Johan Hovold
2012-05-03 10:26   ` Johan Hovold
2012-05-03 10:26   ` [PATCH v2 1/4] mfd: add LM3533 lighting-power core driver Johan Hovold
2012-05-03 10:26     ` Johan Hovold
2012-05-03 10:38     ` Mark Brown
2012-05-03 10:38       ` Mark Brown
2012-05-03 11:28       ` Johan Hovold
2012-05-03 11:28         ` Johan Hovold
2012-05-03 11:38         ` Mark Brown
2012-05-03 11:38           ` Mark Brown
2012-05-03 15:00           ` Johan Hovold
2012-05-03 15:00             ` Johan Hovold
2012-05-03 15:24             ` Mark Brown
2012-05-03 15:24               ` Mark Brown
2012-05-03 16:54               ` Johan Hovold
2012-05-03 16:54                 ` Johan Hovold
2012-05-03 16:57                 ` Mark Brown
2012-05-03 16:57                   ` Mark Brown
2012-05-03 17:14                   ` Johan Hovold [this message]
2012-05-03 17:14                     ` Johan Hovold
2012-05-03 17:23                     ` Mark Brown
2012-05-03 17:23                       ` Mark Brown
2012-05-03 17:31                       ` Johan Hovold
2012-05-03 17:31                         ` Johan Hovold
2012-05-09 14:42     ` Samuel Ortiz
2012-05-09 14:42       ` Samuel Ortiz
2012-05-10 12:07       ` Johan Hovold
2012-05-10 12:07         ` Johan Hovold
2012-05-10 12:11         ` [PATCH 1/2] mfd: lm3533: add boost frequency and ovp to platform data Johan Hovold
2012-05-10 12:11           ` [PATCH 2/2] mfd: lm3533: remove boost attributes Johan Hovold
2012-05-10 17:18         ` [PATCH 0/2] mfd: lm3533: update max-current interface Johan Hovold
2012-05-10 17:18           ` [PATCH 1/2] mfd: lm3533: remove unused max-current function Johan Hovold
2012-05-10 17:18           ` [PATCH 2/2] mfd: lm3533: use SI-units for max-current interface Johan Hovold
2012-05-11 13:32         ` [PATCH v2 1/4] mfd: add LM3533 lighting-power core driver Samuel Ortiz
2012-05-11 13:32           ` Samuel Ortiz
2012-05-03 10:26   ` [PATCH v2 2/4] iio: add LM3533 ambient light sensor driver Johan Hovold
2012-05-03 10:26     ` Johan Hovold
2012-05-03 11:40     ` Jonathan Cameron
2012-05-03 11:40       ` Jonathan Cameron
2012-05-03 16:36       ` Johan Hovold
2012-05-03 16:36         ` Johan Hovold
2012-05-08 13:47         ` Jonathan Cameron
2012-05-08 13:47           ` Jonathan Cameron
2012-05-15 16:44           ` Johan Hovold
2012-05-15 16:44             ` Johan Hovold
2012-05-15 20:00             ` Jonathan Cameron
2012-05-15 20:00               ` Jonathan Cameron
2012-05-16 13:05               ` Johan Hovold
2012-05-16 13:05                 ` Johan Hovold
2012-05-16 14:21                 ` Jonathan Cameron
2012-05-16 14:21                   ` Jonathan Cameron
2012-05-18 12:27                   ` Johan Hovold
2012-05-18 12:27                     ` Johan Hovold
2012-05-18 17:34                     ` Jonathan Cameron
2012-05-18 17:34                       ` Jonathan Cameron
2012-05-18 17:57                       ` Johan Hovold
2012-05-18 17:57                         ` Johan Hovold
2012-05-19  8:04                         ` Jonathan Cameron
2012-05-19  8:04                           ` Jonathan Cameron
2012-05-15 16:46     ` [PATCH v3] iio: add LM3533 ambient-light-sensor driver Johan Hovold
2012-05-15 19:27       ` Andrew Morton
2012-05-15 20:00         ` Johan Hovold
2012-05-15 20:16           ` Jonathan Cameron
2012-05-18 13:07       ` [PATCH v4] " Johan Hovold
2012-05-19  8:48         ` Jonathan Cameron
2012-05-19 16:30           ` Johan Hovold
2012-05-19 13:26             ` Jonathan Cameron
2012-05-21  9:50           ` Johan Hovold
2012-05-21 16:37             ` Jonathan Cameron
2012-05-21 22:07               ` Johan Hovold
2012-05-22  7:13                 ` Jonathan Cameron
2012-05-22  9:09                   ` Johan Hovold
2012-05-22  9:15                     ` Jonathan Cameron
2012-05-22  7:45               ` Michael Hennerich
2012-05-22  7:49                 ` Jonathan Cameron
2012-05-22  8:11                   ` Michael Hennerich
2012-05-22  8:20                     ` Jonathan Cameron
2012-05-21 12:18         ` [PATCH v5] " Johan Hovold
2012-05-22  9:19           ` Jonathan Cameron
2012-05-22  9:40             ` Johan Hovold
2012-05-22 13:55               ` Greg Kroah-Hartman
2012-06-05  4:11               ` Greg Kroah-Hartman
2012-05-03 10:26   ` [PATCH v2 3/4] leds: add LM3533 LED driver Johan Hovold
2012-05-03 10:26     ` Johan Hovold
2012-05-03 10:43     ` Mark Brown
2012-05-03 10:43       ` Mark Brown
2012-05-03 11:50       ` Johan Hovold
2012-05-03 11:50         ` Johan Hovold
2012-05-03 14:51         ` Mark Brown
2012-05-03 14:51           ` Mark Brown
2012-05-03 16:46           ` Johan Hovold
2012-05-03 16:46             ` Johan Hovold
2012-05-10 18:27     ` [PATCH v3] " Johan Hovold
2012-05-10 18:48       ` Andrew Morton
2012-05-11  9:54         ` Johan Hovold
2012-05-11 22:24           ` Andrew Morton
2012-05-14 10:25             ` Johan Hovold
2012-05-14 10:31       ` [PATCH v4] " Johan Hovold
2012-05-03 10:26   ` [PATCH v2 4/4] backlight: add LM3533 backlight driver Johan Hovold
2012-05-03 10:26     ` Johan Hovold
2012-05-10 18:29     ` [PATCH v3] " Johan Hovold
2012-05-10 18:29       ` Johan Hovold
2012-05-15 19:13       ` [PATCH v4] " Johan Hovold
2012-05-15 19:13         ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503171402.GG15752@localhost \
    --to=jhovold@gmail.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@cam.ac.uk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=rpurdie@rpsys.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.