All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"
@ 2012-04-19 12:09 Archit Taneja
  2012-05-04 19:14 ` Tony Lindgren
  2012-05-07 11:01 ` Archit Taneja
  0 siblings, 2 replies; 4+ messages in thread
From: Archit Taneja @ 2012-04-19 12:09 UTC (permalink / raw)
  To: tomi.valkeinen, linux
  Cc: tony, linux-omap, santosh.shilimkar, paul, b-cousson, stable,
	Archit Taneja

This reverts commit 46f8c3c7e95c0d30d95911e7975ddc4f93b3e237.

The commit above swapped the DSI1_PPID and DSI2_PPID register fields in
CONTROL_DSIPHY to be in sync with the newer public OMAP TRMs(after version V).

With this commit, contention errors were reported on DSI lanes some OMAP4 SDPs.
After probing the DSI lanes on OMAP4 SDP, it was seen that setting bits in the
DSI2_PPID field was pulling up voltage on DSI1 lanes, and DSI1_PPID field was
pulling up voltage on DSI2 lanes.

This proves that the current version of OMAP4 TRM is incorrect, swap the
position of register fields according to the older TRM versions as they were
correct.

Cc: stable@vger.kernel.org # v3.2+
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Archit Taneja <archit@ti.com>
---
Note: Resend with stable kernel list added in cc

 .../include/mach/ctrl_module_pad_core_44xx.h       |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
index 1e2d332..c88420d 100644
--- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
+++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
@@ -941,10 +941,10 @@
 #define OMAP4_DSI2_LANEENABLE_MASK				(0x7 << 29)
 #define OMAP4_DSI1_LANEENABLE_SHIFT				24
 #define OMAP4_DSI1_LANEENABLE_MASK				(0x1f << 24)
-#define OMAP4_DSI2_PIPD_SHIFT					19
-#define OMAP4_DSI2_PIPD_MASK					(0x1f << 19)
-#define OMAP4_DSI1_PIPD_SHIFT					14
-#define OMAP4_DSI1_PIPD_MASK					(0x1f << 14)
+#define OMAP4_DSI1_PIPD_SHIFT					19
+#define OMAP4_DSI1_PIPD_MASK					(0x1f << 19)
+#define OMAP4_DSI2_PIPD_SHIFT					14
+#define OMAP4_DSI2_PIPD_MASK					(0x1f << 14)
 
 /* CONTROL_MCBSPLP */
 #define OMAP4_ALBCTRLRX_FSX_SHIFT				31
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"
  2012-04-19 12:09 [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields" Archit Taneja
@ 2012-05-04 19:14 ` Tony Lindgren
  2012-05-07 11:01 ` Archit Taneja
  1 sibling, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-05-04 19:14 UTC (permalink / raw)
  To: Archit Taneja
  Cc: tomi.valkeinen, linux, linux-omap, santosh.shilimkar, paul,
	b-cousson, stable

* Archit Taneja <archit@ti.com> [120419 05:13]:
> This reverts commit 46f8c3c7e95c0d30d95911e7975ddc4f93b3e237.
> 
> The commit above swapped the DSI1_PPID and DSI2_PPID register fields in
> CONTROL_DSIPHY to be in sync with the newer public OMAP TRMs(after version V).
> 
> With this commit, contention errors were reported on DSI lanes some OMAP4 SDPs.
> After probing the DSI lanes on OMAP4 SDP, it was seen that setting bits in the
> DSI2_PPID field was pulling up voltage on DSI1 lanes, and DSI1_PPID field was
> pulling up voltage on DSI2 lanes.
> 
> This proves that the current version of OMAP4 TRM is incorrect, swap the
> position of register fields according to the older TRM versions as they were
> correct.

Thanks applying into fixes.

Tony
 
> Cc: stable@vger.kernel.org # v3.2+
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> Note: Resend with stable kernel list added in cc
> 
>  .../include/mach/ctrl_module_pad_core_44xx.h       |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> index 1e2d332..c88420d 100644
> --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> @@ -941,10 +941,10 @@
>  #define OMAP4_DSI2_LANEENABLE_MASK				(0x7 << 29)
>  #define OMAP4_DSI1_LANEENABLE_SHIFT				24
>  #define OMAP4_DSI1_LANEENABLE_MASK				(0x1f << 24)
> -#define OMAP4_DSI2_PIPD_SHIFT					19
> -#define OMAP4_DSI2_PIPD_MASK					(0x1f << 19)
> -#define OMAP4_DSI1_PIPD_SHIFT					14
> -#define OMAP4_DSI1_PIPD_MASK					(0x1f << 14)
> +#define OMAP4_DSI1_PIPD_SHIFT					19
> +#define OMAP4_DSI1_PIPD_MASK					(0x1f << 19)
> +#define OMAP4_DSI2_PIPD_SHIFT					14
> +#define OMAP4_DSI2_PIPD_MASK					(0x1f << 14)
>  
>  /* CONTROL_MCBSPLP */
>  #define OMAP4_ALBCTRLRX_FSX_SHIFT				31
> -- 
> 1.7.5.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"
  2012-04-19 12:09 [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields" Archit Taneja
  2012-05-04 19:14 ` Tony Lindgren
@ 2012-05-07 11:01 ` Archit Taneja
  2012-05-08 23:20   ` Tony Lindgren
  1 sibling, 1 reply; 4+ messages in thread
From: Archit Taneja @ 2012-05-07 11:01 UTC (permalink / raw)
  To: tony, paul
  Cc: tomi.valkeinen, linux, linux-omap, santosh.shilimkar, b-cousson, stable

Hi Tony, Paul,

Could you please consider this patch for the next -rc cycle, it fixes 
contention errors seen on the DSI panel on OMAP4 SDP.

Thanks,
Archit

On Thursday 19 April 2012 05:39 PM, Archit Taneja wrote:
> This reverts commit 46f8c3c7e95c0d30d95911e7975ddc4f93b3e237.
>
> The commit above swapped the DSI1_PPID and DSI2_PPID register fields in
> CONTROL_DSIPHY to be in sync with the newer public OMAP TRMs(after version V).
>
> With this commit, contention errors were reported on DSI lanes some OMAP4 SDPs.
> After probing the DSI lanes on OMAP4 SDP, it was seen that setting bits in the
> DSI2_PPID field was pulling up voltage on DSI1 lanes, and DSI1_PPID field was
> pulling up voltage on DSI2 lanes.
>
> This proves that the current version of OMAP4 TRM is incorrect, swap the
> position of register fields according to the older TRM versions as they were
> correct.
>
> Cc: stable@vger.kernel.org # v3.2+
> Acked-by: Tomi Valkeinen<tomi.valkeinen@ti.com>
> Signed-off-by: Archit Taneja<archit@ti.com>
> ---
> Note: Resend with stable kernel list added in cc
>
>   .../include/mach/ctrl_module_pad_core_44xx.h       |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> index 1e2d332..c88420d 100644
> --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> @@ -941,10 +941,10 @@
>   #define OMAP4_DSI2_LANEENABLE_MASK				(0x7<<  29)
>   #define OMAP4_DSI1_LANEENABLE_SHIFT				24
>   #define OMAP4_DSI1_LANEENABLE_MASK				(0x1f<<  24)
> -#define OMAP4_DSI2_PIPD_SHIFT					19
> -#define OMAP4_DSI2_PIPD_MASK					(0x1f<<  19)
> -#define OMAP4_DSI1_PIPD_SHIFT					14
> -#define OMAP4_DSI1_PIPD_MASK					(0x1f<<  14)
> +#define OMAP4_DSI1_PIPD_SHIFT					19
> +#define OMAP4_DSI1_PIPD_MASK					(0x1f<<  19)
> +#define OMAP4_DSI2_PIPD_SHIFT					14
> +#define OMAP4_DSI2_PIPD_MASK					(0x1f<<  14)
>
>   /* CONTROL_MCBSPLP */
>   #define OMAP4_ALBCTRLRX_FSX_SHIFT				31


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields"
  2012-05-07 11:01 ` Archit Taneja
@ 2012-05-08 23:20   ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-05-08 23:20 UTC (permalink / raw)
  To: Archit Taneja
  Cc: paul, tomi.valkeinen, linux, linux-omap, santosh.shilimkar,
	b-cousson, stable

* Archit Taneja <a0393947@ti.com> [120507 04:05]:
> Hi Tony, Paul,
> 
> Could you please consider this patch for the next -rc cycle, it
> fixes contention errors seen on the DSI panel on OMAP4 SDP.

I have this already in fixes branch as commit
08ca7444f589bedf9ad5d82883e5d0754852d73b.

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-08 23:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-19 12:09 [PATCH RESEND] ARM: OMAP: Revert "ARM: OMAP: ctrl: Fix CONTROL_DSIPHY register fields" Archit Taneja
2012-05-04 19:14 ` Tony Lindgren
2012-05-07 11:01 ` Archit Taneja
2012-05-08 23:20   ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.