* [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
[Resend to have subsystem lists Cc-ed]
With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
device tree conversion can start basing on that support. This series
adopts pinctrl support for mxs device drivers with a dummy pinctrl
state provided for non-DT boot, so that the pinctrl call in the device
drivers will be bypassed for non-DT probe while it starts working for
DT probe.
To ease the merge process, I would like to ask Arnd and Olof to pull
pinctrl tree as a dependency in arm-soc and have this series go through
arm-soc.
Regards,
Shawn
Shawn Guo (9):
ARM: mxs: enable pinctrl dummy states
serial: amba-pl011: adopt pinctrl support
serial: mxs-auart: adopt pinctrl support
mmc: mxs-mmc: adopt pinctrl support
mtd: nand: gpmi: adopt pinctrl support
i2c: mxs: adopt pinctrl support
ASoC: mxs-saif: adopt pinctrl support
video: mxsfb: adopt pinctrl support
ARM: mxs: enable pinctrl support
arch/arm/Kconfig | 1 +
arch/arm/mach-mxs/Kconfig | 2 ++
arch/arm/mach-mxs/include/mach/common.h | 2 ++
arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
arch/arm/mach-mxs/mach-m28evk.c | 2 ++
arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
arch/arm/mach-mxs/mach-tx28.c | 2 ++
arch/arm/mach-mxs/mm.c | 11 +++++++++++
drivers/i2c/busses/i2c-mxs.c | 6 ++++++
drivers/mmc/host/mxs-mmc.c | 8 ++++++++
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
drivers/tty/serial/amba-pl011.c | 8 ++++++++
drivers/tty/serial/mxs-auart.c | 8 ++++++++
drivers/video/mxsfb.c | 9 +++++++++
sound/soc/mxs/mxs-saif.c | 8 ++++++++
17 files changed, 84 insertions(+), 0 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-fbdev, Chris Ball, Arnd Bergmann,
Florian Tobias Schandinat, Artem Bityutskiy, Mark Brown,
linux-mmc, alsa-devel, Wolfram Sang, linux-mtd, linux-i2c,
linux-serial, Greg Kroah-Hartman, Olof Johansson, Shawn Guo
[Resend to have subsystem lists Cc-ed]
With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
device tree conversion can start basing on that support. This series
adopts pinctrl support for mxs device drivers with a dummy pinctrl
state provided for non-DT boot, so that the pinctrl call in the device
drivers will be bypassed for non-DT probe while it starts working for
DT probe.
To ease the merge process, I would like to ask Arnd and Olof to pull
pinctrl tree as a dependency in arm-soc and have this series go through
arm-soc.
Regards,
Shawn
Shawn Guo (9):
ARM: mxs: enable pinctrl dummy states
serial: amba-pl011: adopt pinctrl support
serial: mxs-auart: adopt pinctrl support
mmc: mxs-mmc: adopt pinctrl support
mtd: nand: gpmi: adopt pinctrl support
i2c: mxs: adopt pinctrl support
ASoC: mxs-saif: adopt pinctrl support
video: mxsfb: adopt pinctrl support
ARM: mxs: enable pinctrl support
arch/arm/Kconfig | 1 +
arch/arm/mach-mxs/Kconfig | 2 ++
arch/arm/mach-mxs/include/mach/common.h | 2 ++
arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
arch/arm/mach-mxs/mach-m28evk.c | 2 ++
arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
arch/arm/mach-mxs/mach-tx28.c | 2 ++
arch/arm/mach-mxs/mm.c | 11 +++++++++++
drivers/i2c/busses/i2c-mxs.c | 6 ++++++
drivers/mmc/host/mxs-mmc.c | 8 ++++++++
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
drivers/tty/serial/amba-pl011.c | 8 ++++++++
drivers/tty/serial/mxs-auart.c | 8 ++++++++
drivers/video/mxsfb.c | 9 +++++++++
sound/soc/mxs/mxs-saif.c | 8 ++++++++
17 files changed, 84 insertions(+), 0 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Arnd Bergmann, Olof Johansson, Shawn Guo, linux-fbdev,
Florian Tobias Schandinat, alsa-devel, Mark Brown, linux-i2c,
Wolfram Sang, linux-mtd, Artem Bityutskiy, linux-mmc, Chris Ball,
linux-serial, Greg Kroah-Hartman
[Resend to have subsystem lists Cc-ed]
With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
device tree conversion can start basing on that support. This series
adopts pinctrl support for mxs device drivers with a dummy pinctrl
state provided for non-DT boot, so that the pinctrl call in the device
drivers will be bypassed for non-DT probe while it starts working for
DT probe.
To ease the merge process, I would like to ask Arnd and Olof to pull
pinctrl tree as a dependency in arm-soc and have this series go through
arm-soc.
Regards,
Shawn
Shawn Guo (9):
ARM: mxs: enable pinctrl dummy states
serial: amba-pl011: adopt pinctrl support
serial: mxs-auart: adopt pinctrl support
mmc: mxs-mmc: adopt pinctrl support
mtd: nand: gpmi: adopt pinctrl support
i2c: mxs: adopt pinctrl support
ASoC: mxs-saif: adopt pinctrl support
video: mxsfb: adopt pinctrl support
ARM: mxs: enable pinctrl support
arch/arm/Kconfig | 1 +
arch/arm/mach-mxs/Kconfig | 2 ++
arch/arm/mach-mxs/include/mach/common.h | 2 ++
arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
arch/arm/mach-mxs/mach-m28evk.c | 2 ++
arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
arch/arm/mach-mxs/mach-tx28.c | 2 ++
arch/arm/mach-mxs/mm.c | 11 +++++++++++
drivers/i2c/busses/i2c-mxs.c | 6 ++++++
drivers/mmc/host/mxs-mmc.c | 8 ++++++++
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
drivers/tty/serial/amba-pl011.c | 8 ++++++++
drivers/tty/serial/mxs-auart.c | 8 ++++++++
drivers/video/mxsfb.c | 9 +++++++++
sound/soc/mxs/mxs-saif.c | 8 ++++++++
17 files changed, 84 insertions(+), 0 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 1/9] ARM: mxs: enable pinctrl dummy states
2012-05-07 1:16 ` Shawn Guo
` (2 preceding siblings ...)
(?)
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
The mxs pinctrl driver will only support DT probe. That said, the mxs
device drivers can only get pinctrl state from pinctrl subsystem when
the drivers get probed from device tree.
Before converting the whole mxs platform support over to device tree,
we need to enable pinctrl dummy states for those non-DT board files
to ensure the pinctrl API adopted by mxs device drivers will work for
both DT and non-DT probe.
Instead of calling pinctrl_provide_dummies() directly in every board
file, the patch introduces soc specific calls mx23_soc_init() and
mx28_soc_init() for boards' .init_machine hook to invoke, so that
any soc specific setup for non-DT boot only can be added there.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/mach-mxs/include/mach/common.h | 2 ++
arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
arch/arm/mach-mxs/mach-m28evk.c | 2 ++
arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
arch/arm/mach-mxs/mach-tx28.c | 2 ++
arch/arm/mach-mxs/mm.c | 11 +++++++++++
8 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/common.h b/arch/arm/mach-mxs/include/mach/common.h
index c50c3ea..8d88399 100644
--- a/arch/arm/mach-mxs/include/mach/common.h
+++ b/arch/arm/mach-mxs/include/mach/common.h
@@ -19,11 +19,13 @@ extern void mxs_timer_init(struct clk *, int);
extern void mxs_restart(char, const char *);
extern int mxs_saif_clkmux_select(unsigned int clkmux);
+extern void mx23_soc_init(void);
extern int mx23_register_gpios(void);
extern int mx23_clocks_init(void);
extern void mx23_map_io(void);
extern void mx23_init_irq(void);
+extern void mx28_soc_init(void);
extern int mx28_register_gpios(void);
extern int mx28_clocks_init(void);
extern void mx28_map_io(void);
diff --git a/arch/arm/mach-mxs/mach-apx4devkit.c b/arch/arm/mach-mxs/mach-apx4devkit.c
index 48a7fab..5e90b9d 100644
--- a/arch/arm/mach-mxs/mach-apx4devkit.c
+++ b/arch/arm/mach-mxs/mach-apx4devkit.c
@@ -207,6 +207,8 @@ static int apx4devkit_phy_fixup(struct phy_device *phy)
static void __init apx4devkit_init(void)
{
+ mx28_soc_init();
+
mxs_iomux_setup_multiple_pads(apx4devkit_pads,
ARRAY_SIZE(apx4devkit_pads));
diff --git a/arch/arm/mach-mxs/mach-m28evk.c b/arch/arm/mach-mxs/mach-m28evk.c
index 06d7996..4c00c87 100644
--- a/arch/arm/mach-mxs/mach-m28evk.c
+++ b/arch/arm/mach-mxs/mach-m28evk.c
@@ -319,6 +319,8 @@ static struct mxs_mmc_platform_data m28evk_mmc_pdata[] __initdata = {
static void __init m28evk_init(void)
{
+ mx28_soc_init();
+
mxs_iomux_setup_multiple_pads(m28evk_pads, ARRAY_SIZE(m28evk_pads));
mx28_add_duart();
diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c
index 5ea1c57..e7272a4 100644
--- a/arch/arm/mach-mxs/mach-mx23evk.c
+++ b/arch/arm/mach-mxs/mach-mx23evk.c
@@ -141,6 +141,8 @@ static void __init mx23evk_init(void)
{
int ret;
+ mx23_soc_init();
+
mxs_iomux_setup_multiple_pads(mx23evk_pads, ARRAY_SIZE(mx23evk_pads));
mx23_add_duart();
diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c
index e386c14..da4610e 100644
--- a/arch/arm/mach-mxs/mach-mx28evk.c
+++ b/arch/arm/mach-mxs/mach-mx28evk.c
@@ -413,6 +413,8 @@ static void __init mx28evk_init(void)
{
int ret;
+ mx28_soc_init();
+
mxs_iomux_setup_multiple_pads(mx28evk_pads, ARRAY_SIZE(mx28evk_pads));
mx28_add_duart();
diff --git a/arch/arm/mach-mxs/mach-stmp378x_devb.c b/arch/arm/mach-mxs/mach-stmp378x_devb.c
index a626c07..6548965 100644
--- a/arch/arm/mach-mxs/mach-stmp378x_devb.c
+++ b/arch/arm/mach-mxs/mach-stmp378x_devb.c
@@ -85,6 +85,8 @@ static void __init stmp378x_dvb_init(void)
{
int ret;
+ mx23_soc_init();
+
mxs_iomux_setup_multiple_pads(stmp378x_dvb_pads,
ARRAY_SIZE(stmp378x_dvb_pads));
diff --git a/arch/arm/mach-mxs/mach-tx28.c b/arch/arm/mach-mxs/mach-tx28.c
index 2c0862e..8837029 100644
--- a/arch/arm/mach-mxs/mach-tx28.c
+++ b/arch/arm/mach-mxs/mach-tx28.c
@@ -146,6 +146,8 @@ static struct mxs_mmc_platform_data tx28_mmc0_pdata __initdata = {
static void __init tx28_stk5v3_init(void)
{
+ mx28_soc_init();
+
mxs_iomux_setup_multiple_pads(tx28_stk5v3_pads,
ARRAY_SIZE(tx28_stk5v3_pads));
diff --git a/arch/arm/mach-mxs/mm.c b/arch/arm/mach-mxs/mm.c
index 50af5ce..67a384e 100644
--- a/arch/arm/mach-mxs/mm.c
+++ b/arch/arm/mach-mxs/mm.c
@@ -13,6 +13,7 @@
#include <linux/mm.h>
#include <linux/init.h>
+#include <linux/pinctrl/machine.h>
#include <asm/mach/map.h>
@@ -61,3 +62,13 @@ void __init mx28_init_irq(void)
{
icoll_init_irq();
}
+
+void __init mx23_soc_init(void)
+{
+ pinctrl_provide_dummies();
+}
+
+void __init mx28_soc_init(void)
+{
+ pinctrl_provide_dummies();
+}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 2/9] serial: amba-pl011: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Arnd Bergmann, Olof Johansson, Shawn Guo, linux-serial,
Greg Kroah-Hartman
Cc: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/tty/serial/amba-pl011.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 3d569cd..062ef8c 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -52,6 +52,7 @@
#include <linux/scatterlist.h>
#include <linux/delay.h>
#include <linux/types.h>
+#include <linux/pinctrl/consumer.h>
#include <asm/io.h>
#include <asm/sizes.h>
@@ -1916,6 +1917,7 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
{
struct uart_amba_port *uap;
struct vendor_data *vendor = id->data;
+ struct pinctrl *pinctrl;
void __iomem *base;
int i, ret;
@@ -1940,6 +1942,12 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
goto free;
}
+ pinctrl = devm_pinctrl_get_select_default(&dev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto unmap;
+ }
+
uap->clk = clk_get(&dev->dev, NULL);
if (IS_ERR(uap->clk)) {
ret = PTR_ERR(uap->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 2/9] serial: amba-pl011: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-serial at vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/tty/serial/amba-pl011.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 3d569cd..062ef8c 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -52,6 +52,7 @@
#include <linux/scatterlist.h>
#include <linux/delay.h>
#include <linux/types.h>
+#include <linux/pinctrl/consumer.h>
#include <asm/io.h>
#include <asm/sizes.h>
@@ -1916,6 +1917,7 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
{
struct uart_amba_port *uap;
struct vendor_data *vendor = id->data;
+ struct pinctrl *pinctrl;
void __iomem *base;
int i, ret;
@@ -1940,6 +1942,12 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
goto free;
}
+ pinctrl = devm_pinctrl_get_select_default(&dev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto unmap;
+ }
+
uap->clk = clk_get(&dev->dev, NULL);
if (IS_ERR(uap->clk)) {
ret = PTR_ERR(uap->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 3/9] serial: mxs-auart: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Arnd Bergmann, Olof Johansson, Shawn Guo, linux-serial,
Greg Kroah-Hartman
Cc: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/tty/serial/mxs-auart.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 55fd362..7081600 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -32,6 +32,7 @@
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <asm/cacheflush.h>
@@ -678,6 +679,7 @@ static int __devinit mxs_auart_probe(struct platform_device *pdev)
u32 version;
int ret = 0;
struct resource *r;
+ struct pinctrl *pinctrl;
s = kzalloc(sizeof(struct mxs_auart_port), GFP_KERNEL);
if (!s) {
@@ -685,6 +687,12 @@ static int __devinit mxs_auart_probe(struct platform_device *pdev)
goto out;
}
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto out_free;
+ }
+
s->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(s->clk)) {
ret = PTR_ERR(s->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 3/9] serial: mxs-auart: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-serial at vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/tty/serial/mxs-auart.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 55fd362..7081600 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -32,6 +32,7 @@
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <asm/cacheflush.h>
@@ -678,6 +679,7 @@ static int __devinit mxs_auart_probe(struct platform_device *pdev)
u32 version;
int ret = 0;
struct resource *r;
+ struct pinctrl *pinctrl;
s = kzalloc(sizeof(struct mxs_auart_port), GFP_KERNEL);
if (!s) {
@@ -685,6 +687,12 @@ static int __devinit mxs_auart_probe(struct platform_device *pdev)
goto out;
}
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto out_free;
+ }
+
s->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(s->clk)) {
ret = PTR_ERR(s->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 4/9] mmc: mxs-mmc: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Arnd Bergmann, Olof Johansson, Shawn Guo, linux-mmc
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Chris Ball <cjb@laptop.org>
---
drivers/mmc/host/mxs-mmc.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index e3f5af9..bb03ddd 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -39,6 +39,7 @@
#include <linux/regulator/consumer.h>
#include <linux/module.h>
#include <linux/fsl/mxs-dma.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/mxs.h>
#include <mach/common.h>
@@ -682,6 +683,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
struct mmc_host *mmc;
struct resource *iores, *dmares, *r;
struct mxs_mmc_platform_data *pdata;
+ struct pinctrl *pinctrl;
int ret = 0, irq_err, irq_dma;
dma_cap_mask_t mask;
@@ -719,6 +721,12 @@ static int mxs_mmc_probe(struct platform_device *pdev)
host->irq = irq_err;
host->sdio_irq_en = 0;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto out_iounmap;
+ }
+
host->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 4/9] mmc: mxs-mmc: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Chris Ball <cjb@laptop.org>
---
drivers/mmc/host/mxs-mmc.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index e3f5af9..bb03ddd 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -39,6 +39,7 @@
#include <linux/regulator/consumer.h>
#include <linux/module.h>
#include <linux/fsl/mxs-dma.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/mxs.h>
#include <mach/common.h>
@@ -682,6 +683,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
struct mmc_host *mmc;
struct resource *iores, *dmares, *r;
struct mxs_mmc_platform_data *pdata;
+ struct pinctrl *pinctrl;
int ret = 0, irq_err, irq_dma;
dma_cap_mask_t mask;
@@ -719,6 +721,12 @@ static int mxs_mmc_probe(struct platform_device *pdev)
host->irq = irq_err;
host->sdio_irq_en = 0;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto out_iounmap;
+ }
+
host->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 5/9] mtd: nand: gpmi: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Olof Johansson, Artem Bityutskiy, Shawn Guo, linux-mtd, Arnd Bergmann
Cc: linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 9ec51ce..8478fd9 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -24,6 +24,7 @@
#include <linux/module.h>
#include <linux/mtd/gpmi-nand.h>
#include <linux/mtd/partitions.h>
+#include <linux/pinctrl/consumer.h>
#include "gpmi-nand.h"
/* add our owner bbt descriptor */
@@ -476,6 +477,7 @@ acquire_err:
static int __devinit acquire_resources(struct gpmi_nand_data *this)
{
struct resources *res = &this->resources;
+ struct pinctrl *pinctrl;
int ret;
ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME);
@@ -494,6 +496,12 @@ static int __devinit acquire_resources(struct gpmi_nand_data *this)
if (ret)
goto exit_dma_channels;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto exit_pin;
+ }
+
res->clock = clk_get(&this->pdev->dev, NULL);
if (IS_ERR(res->clock)) {
pr_err("can not get the clock\n");
@@ -503,6 +511,7 @@ static int __devinit acquire_resources(struct gpmi_nand_data *this)
return 0;
exit_clock:
+exit_pin:
release_dma_channels(this);
exit_dma_channels:
release_bch_irq(this);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 5/9] mtd: nand: gpmi: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-mtd at lists.infradead.org
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 9ec51ce..8478fd9 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -24,6 +24,7 @@
#include <linux/module.h>
#include <linux/mtd/gpmi-nand.h>
#include <linux/mtd/partitions.h>
+#include <linux/pinctrl/consumer.h>
#include "gpmi-nand.h"
/* add our owner bbt descriptor */
@@ -476,6 +477,7 @@ acquire_err:
static int __devinit acquire_resources(struct gpmi_nand_data *this)
{
struct resources *res = &this->resources;
+ struct pinctrl *pinctrl;
int ret;
ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME);
@@ -494,6 +496,12 @@ static int __devinit acquire_resources(struct gpmi_nand_data *this)
if (ret)
goto exit_dma_channels;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto exit_pin;
+ }
+
res->clock = clk_get(&this->pdev->dev, NULL);
if (IS_ERR(res->clock)) {
pr_err("can not get the clock\n");
@@ -503,6 +511,7 @@ static int __devinit acquire_resources(struct gpmi_nand_data *this)
return 0;
exit_clock:
+exit_pin:
release_dma_channels(this);
exit_dma_channels:
release_bch_irq(this);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
[parent not found: <1336353374-28939-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* [PATCH RESEND 6/9] i2c: mxs: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Arnd Bergmann, Olof Johansson, Shawn Guo,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Signed-off-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/i2c/busses/i2c-mxs.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 3d471d5..7c7711d 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -26,6 +26,7 @@
#include <linux/platform_device.h>
#include <linux/jiffies.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/common.h>
@@ -323,10 +324,15 @@ static int __devinit mxs_i2c_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct mxs_i2c_dev *i2c;
struct i2c_adapter *adap;
+ struct pinctrl *pinctrl;
struct resource *res;
resource_size_t res_size;
int err, irq;
+ pinctrl = devm_pinctrl_get_select_default(dev);
+ if (IS_ERR(pinctrl))
+ return PTR_ERR(pinctrl);
+
i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL);
if (!i2c)
return -ENOMEM;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 6/9] i2c: mxs: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-i2c at vger.kernel.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/i2c/busses/i2c-mxs.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 3d471d5..7c7711d 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -26,6 +26,7 @@
#include <linux/platform_device.h>
#include <linux/jiffies.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/common.h>
@@ -323,10 +324,15 @@ static int __devinit mxs_i2c_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct mxs_i2c_dev *i2c;
struct i2c_adapter *adap;
+ struct pinctrl *pinctrl;
struct resource *res;
resource_size_t res_size;
int err, irq;
+ pinctrl = devm_pinctrl_get_select_default(dev);
+ if (IS_ERR(pinctrl))
+ return PTR_ERR(pinctrl);
+
i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL);
if (!i2c)
return -ENOMEM;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 7/9] ASoC: mxs-saif: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Olof Johansson, alsa-devel, Shawn Guo, Arnd Bergmann, Mark Brown
Cc: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/mxs/mxs-saif.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index 53f4fd8..7fd224b 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -25,6 +25,7 @@
#include <linux/delay.h>
#include <linux/time.h>
#include <linux/fsl/mxs-dma.h>
+#include <linux/pinctrl/consumer.h>
#include <sound/core.h>
#include <sound/pcm.h>
#include <sound/pcm_params.h>
@@ -625,6 +626,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
struct resource *iores, *dmares;
struct mxs_saif *saif;
struct mxs_saif_platform_data *pdata;
+ struct pinctrl *pinctrl;
int ret = 0;
if (pdev->id >= ARRAY_SIZE(mxs_saif))
@@ -650,6 +652,12 @@ static int mxs_saif_probe(struct platform_device *pdev)
saif->master_id = saif->id;
}
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ return ret;
+ }
+
saif->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(saif->clk)) {
ret = PTR_ERR(saif->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 7/9] ASoC: mxs-saif: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: alsa-devel at alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/mxs/mxs-saif.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index 53f4fd8..7fd224b 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -25,6 +25,7 @@
#include <linux/delay.h>
#include <linux/time.h>
#include <linux/fsl/mxs-dma.h>
+#include <linux/pinctrl/consumer.h>
#include <sound/core.h>
#include <sound/pcm.h>
#include <sound/pcm_params.h>
@@ -625,6 +626,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
struct resource *iores, *dmares;
struct mxs_saif *saif;
struct mxs_saif_platform_data *pdata;
+ struct pinctrl *pinctrl;
int ret = 0;
if (pdev->id >= ARRAY_SIZE(mxs_saif))
@@ -650,6 +652,12 @@ static int mxs_saif_probe(struct platform_device *pdev)
saif->master_id = saif->id;
}
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ return ret;
+ }
+
saif->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(saif->clk)) {
ret = PTR_ERR(saif->clk);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH RESEND 7/9] ASoC: mxs-saif: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 12:04 ` Mark Brown
-1 siblings, 0 replies; 34+ messages in thread
From: Mark Brown @ 2012-05-07 12:04 UTC (permalink / raw)
To: Shawn Guo; +Cc: Olof Johansson, alsa-devel, Arnd Bergmann, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]
On Mon, May 07, 2012 at 09:16:12AM +0800, Shawn Guo wrote:
> Cc: alsa-devel@alsa-project.org
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH RESEND 8/9] video: mxsfb: adopt pinctrl support
2012-05-07 1:16 ` Shawn Guo
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-fbdev@vger.kernel.org
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/video/mxsfb.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 4a89f88..6c6bc57 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -45,6 +45,7 @@
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/mxsfb.h>
#define REG_SET 4
@@ -756,6 +757,7 @@ static int __devinit mxsfb_probe(struct platform_device *pdev)
struct mxsfb_info *host;
struct fb_info *fb_info;
struct fb_modelist *modelist;
+ struct pinctrl *pinctrl;
int i, ret;
if (!pdata) {
@@ -793,6 +795,12 @@ static int __devinit mxsfb_probe(struct platform_device *pdev)
host->devdata = &mxsfb_devdata[pdev->id_entry->driver_data];
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto error_getpin;
+ }
+
host->clk = clk_get(&host->pdev->dev, NULL);
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
@@ -848,6 +856,7 @@ error_init_fb:
error_pseudo_pallette:
clk_put(host->clk);
error_getclock:
+error_getpin:
iounmap(host->base);
error_ioremap:
framebuffer_release(fb_info);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* [PATCH RESEND 8/9] video: mxsfb: adopt pinctrl support
@ 2012-05-07 1:16 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-fbdev at vger.kernel.org
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/video/mxsfb.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 4a89f88..6c6bc57 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -45,6 +45,7 @@
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
+#include <linux/pinctrl/consumer.h>
#include <mach/mxsfb.h>
#define REG_SET 4
@@ -756,6 +757,7 @@ static int __devinit mxsfb_probe(struct platform_device *pdev)
struct mxsfb_info *host;
struct fb_info *fb_info;
struct fb_modelist *modelist;
+ struct pinctrl *pinctrl;
int i, ret;
if (!pdata) {
@@ -793,6 +795,12 @@ static int __devinit mxsfb_probe(struct platform_device *pdev)
host->devdata = &mxsfb_devdata[pdev->id_entry->driver_data];
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto error_getpin;
+ }
+
host->clk = clk_get(&host->pdev->dev, NULL);
if (IS_ERR(host->clk)) {
ret = PTR_ERR(host->clk);
@@ -848,6 +856,7 @@ error_init_fb:
error_pseudo_pallette:
clk_put(host->clk);
error_getclock:
+error_getpin:
iounmap(host->base);
error_ioremap:
framebuffer_release(fb_info);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH RESEND 9/9] ARM: mxs: enable pinctrl support
2012-05-07 1:16 ` Shawn Guo
` (10 preceding siblings ...)
(?)
@ 2012-05-07 1:16 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 1:16 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/Kconfig | 1 +
arch/arm/mach-mxs/Kconfig | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index cf006d4..c67494f 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -469,6 +469,7 @@ config ARCH_MXS
select CLKDEV_LOOKUP
select CLKSRC_MMIO
select HAVE_CLK_PREPARE
+ select PINCTRL
help
Support for Freescale MXS-based family of processors
diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
index c57f996..07d5383 100644
--- a/arch/arm/mach-mxs/Kconfig
+++ b/arch/arm/mach-mxs/Kconfig
@@ -9,11 +9,13 @@ config SOC_IMX23
bool
select CPU_ARM926T
select HAVE_PWM
+ select PINCTRL_IMX23
config SOC_IMX28
bool
select CPU_ARM926T
select HAVE_PWM
+ select PINCTRL_IMX28
comment "MXS platforms:"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
2012-05-07 1:16 ` Shawn Guo
(?)
(?)
@ 2012-05-07 7:14 ` Dong Aisheng
-1 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 7:14 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, linux-fbdev, Chris Ball, Arnd Bergmann,
Florian Tobias Schandinat, Artem Bityutskiy, Mark Brown,
linux-mmc, alsa-devel, Wolfram Sang, linux-mtd, linux-i2c,
linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 09:16:05AM +0800, Shawn Guo wrote:
> [Resend to have subsystem lists Cc-ed]
>
> With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
> device tree conversion can start basing on that support. This series
> adopts pinctrl support for mxs device drivers with a dummy pinctrl
> state provided for non-DT boot, so that the pinctrl call in the device
> drivers will be bypassed for non-DT probe while it starts working for
> DT probe.
>
> To ease the merge process, I would like to ask Arnd and Olof to pull
> pinctrl tree as a dependency in arm-soc and have this series go through
> arm-soc.
>
As IMX, basically i'd prefer to add pinctrl states in dts file at the
same time within the patch or using a separate patch to add them before
this series to avoid breaking the exist platforms.
However i noted that for mxs, most drivers here are still not dt capable,
so it may be ok to not add their pinctrl state at this time.
But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
dt capable, so with this patch applied, the mx28 dt boot will fail.
Maybe we should at least add pinctrl states for amba-pl011 first.
> Regards,
> Shawn
>
> Shawn Guo (9):
> ARM: mxs: enable pinctrl dummy states
> serial: amba-pl011: adopt pinctrl support
BTW, will this one break other platforms using this driver?
> serial: mxs-auart: adopt pinctrl support
> mmc: mxs-mmc: adopt pinctrl support
> mtd: nand: gpmi: adopt pinctrl support
> i2c: mxs: adopt pinctrl support
> ASoC: mxs-saif: adopt pinctrl support
> video: mxsfb: adopt pinctrl support
> ARM: mxs: enable pinctrl support
>
> arch/arm/Kconfig | 1 +
> arch/arm/mach-mxs/Kconfig | 2 ++
> arch/arm/mach-mxs/include/mach/common.h | 2 ++
> arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
> arch/arm/mach-mxs/mach-m28evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
> arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
> arch/arm/mach-mxs/mach-tx28.c | 2 ++
> arch/arm/mach-mxs/mm.c | 11 +++++++++++
> drivers/i2c/busses/i2c-mxs.c | 6 ++++++
> drivers/mmc/host/mxs-mmc.c | 8 ++++++++
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
> drivers/tty/serial/amba-pl011.c | 8 ++++++++
> drivers/tty/serial/mxs-auart.c | 8 ++++++++
> drivers/video/mxsfb.c | 9 +++++++++
> sound/soc/mxs/mxs-saif.c | 8 ++++++++
> 17 files changed, 84 insertions(+), 0 deletions(-)
>
> --
> 1.7.5.4
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:14 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 7:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 07, 2012 at 09:16:05AM +0800, Shawn Guo wrote:
> [Resend to have subsystem lists Cc-ed]
>
> With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
> device tree conversion can start basing on that support. This series
> adopts pinctrl support for mxs device drivers with a dummy pinctrl
> state provided for non-DT boot, so that the pinctrl call in the device
> drivers will be bypassed for non-DT probe while it starts working for
> DT probe.
>
> To ease the merge process, I would like to ask Arnd and Olof to pull
> pinctrl tree as a dependency in arm-soc and have this series go through
> arm-soc.
>
As IMX, basically i'd prefer to add pinctrl states in dts file at the
same time within the patch or using a separate patch to add them before
this series to avoid breaking the exist platforms.
However i noted that for mxs, most drivers here are still not dt capable,
so it may be ok to not add their pinctrl state at this time.
But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
dt capable, so with this patch applied, the mx28 dt boot will fail.
Maybe we should at least add pinctrl states for amba-pl011 first.
> Regards,
> Shawn
>
> Shawn Guo (9):
> ARM: mxs: enable pinctrl dummy states
> serial: amba-pl011: adopt pinctrl support
BTW, will this one break other platforms using this driver?
> serial: mxs-auart: adopt pinctrl support
> mmc: mxs-mmc: adopt pinctrl support
> mtd: nand: gpmi: adopt pinctrl support
> i2c: mxs: adopt pinctrl support
> ASoC: mxs-saif: adopt pinctrl support
> video: mxsfb: adopt pinctrl support
> ARM: mxs: enable pinctrl support
>
> arch/arm/Kconfig | 1 +
> arch/arm/mach-mxs/Kconfig | 2 ++
> arch/arm/mach-mxs/include/mach/common.h | 2 ++
> arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
> arch/arm/mach-mxs/mach-m28evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
> arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
> arch/arm/mach-mxs/mach-tx28.c | 2 ++
> arch/arm/mach-mxs/mm.c | 11 +++++++++++
> drivers/i2c/busses/i2c-mxs.c | 6 ++++++
> drivers/mmc/host/mxs-mmc.c | 8 ++++++++
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
> drivers/tty/serial/amba-pl011.c | 8 ++++++++
> drivers/tty/serial/mxs-auart.c | 8 ++++++++
> drivers/video/mxsfb.c | 9 +++++++++
> sound/soc/mxs/mxs-saif.c | 8 ++++++++
> 17 files changed, 84 insertions(+), 0 deletions(-)
>
> --
> 1.7.5.4
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:14 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 7:14 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-fbdev, Arnd Bergmann, Florian Tobias Schandinat,
Artem Bityutskiy, Mark Brown, linux-mmc, alsa-devel,
Wolfram Sang, linux-mtd, linux-i2c, linux-serial,
Greg Kroah-Hartman, Olof Johansson, Chris Ball, linux-arm-kernel
On Mon, May 07, 2012 at 09:16:05AM +0800, Shawn Guo wrote:
> [Resend to have subsystem lists Cc-ed]
>
> With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
> device tree conversion can start basing on that support. This series
> adopts pinctrl support for mxs device drivers with a dummy pinctrl
> state provided for non-DT boot, so that the pinctrl call in the device
> drivers will be bypassed for non-DT probe while it starts working for
> DT probe.
>
> To ease the merge process, I would like to ask Arnd and Olof to pull
> pinctrl tree as a dependency in arm-soc and have this series go through
> arm-soc.
>
As IMX, basically i'd prefer to add pinctrl states in dts file at the
same time within the patch or using a separate patch to add them before
this series to avoid breaking the exist platforms.
However i noted that for mxs, most drivers here are still not dt capable,
so it may be ok to not add their pinctrl state at this time.
But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
dt capable, so with this patch applied, the mx28 dt boot will fail.
Maybe we should at least add pinctrl states for amba-pl011 first.
> Regards,
> Shawn
>
> Shawn Guo (9):
> ARM: mxs: enable pinctrl dummy states
> serial: amba-pl011: adopt pinctrl support
BTW, will this one break other platforms using this driver?
> serial: mxs-auart: adopt pinctrl support
> mmc: mxs-mmc: adopt pinctrl support
> mtd: nand: gpmi: adopt pinctrl support
> i2c: mxs: adopt pinctrl support
> ASoC: mxs-saif: adopt pinctrl support
> video: mxsfb: adopt pinctrl support
> ARM: mxs: enable pinctrl support
>
> arch/arm/Kconfig | 1 +
> arch/arm/mach-mxs/Kconfig | 2 ++
> arch/arm/mach-mxs/include/mach/common.h | 2 ++
> arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
> arch/arm/mach-mxs/mach-m28evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
> arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
> arch/arm/mach-mxs/mach-tx28.c | 2 ++
> arch/arm/mach-mxs/mm.c | 11 +++++++++++
> drivers/i2c/busses/i2c-mxs.c | 6 ++++++
> drivers/mmc/host/mxs-mmc.c | 8 ++++++++
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
> drivers/tty/serial/amba-pl011.c | 8 ++++++++
> drivers/tty/serial/mxs-auart.c | 8 ++++++++
> drivers/video/mxsfb.c | 9 +++++++++
> sound/soc/mxs/mxs-saif.c | 8 ++++++++
> 17 files changed, 84 insertions(+), 0 deletions(-)
>
> --
> 1.7.5.4
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:14 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 7:14 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, linux-fbdev, Chris Ball, Arnd Bergmann,
Florian Tobias Schandinat, Artem Bityutskiy, Mark Brown,
linux-mmc, alsa-devel, Wolfram Sang, linux-mtd, linux-i2c,
linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 09:16:05AM +0800, Shawn Guo wrote:
> [Resend to have subsystem lists Cc-ed]
>
> With pinctrl-mxs driver (DT only) applied on pinctrl tree, the mxs
> device tree conversion can start basing on that support. This series
> adopts pinctrl support for mxs device drivers with a dummy pinctrl
> state provided for non-DT boot, so that the pinctrl call in the device
> drivers will be bypassed for non-DT probe while it starts working for
> DT probe.
>
> To ease the merge process, I would like to ask Arnd and Olof to pull
> pinctrl tree as a dependency in arm-soc and have this series go through
> arm-soc.
>
As IMX, basically i'd prefer to add pinctrl states in dts file at the
same time within the patch or using a separate patch to add them before
this series to avoid breaking the exist platforms.
However i noted that for mxs, most drivers here are still not dt capable,
so it may be ok to not add their pinctrl state at this time.
But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
dt capable, so with this patch applied, the mx28 dt boot will fail.
Maybe we should at least add pinctrl states for amba-pl011 first.
> Regards,
> Shawn
>
> Shawn Guo (9):
> ARM: mxs: enable pinctrl dummy states
> serial: amba-pl011: adopt pinctrl support
BTW, will this one break other platforms using this driver?
> serial: mxs-auart: adopt pinctrl support
> mmc: mxs-mmc: adopt pinctrl support
> mtd: nand: gpmi: adopt pinctrl support
> i2c: mxs: adopt pinctrl support
> ASoC: mxs-saif: adopt pinctrl support
> video: mxsfb: adopt pinctrl support
> ARM: mxs: enable pinctrl support
>
> arch/arm/Kconfig | 1 +
> arch/arm/mach-mxs/Kconfig | 2 ++
> arch/arm/mach-mxs/include/mach/common.h | 2 ++
> arch/arm/mach-mxs/mach-apx4devkit.c | 2 ++
> arch/arm/mach-mxs/mach-m28evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx23evk.c | 2 ++
> arch/arm/mach-mxs/mach-mx28evk.c | 2 ++
> arch/arm/mach-mxs/mach-stmp378x_devb.c | 2 ++
> arch/arm/mach-mxs/mach-tx28.c | 2 ++
> arch/arm/mach-mxs/mm.c | 11 +++++++++++
> drivers/i2c/busses/i2c-mxs.c | 6 ++++++
> drivers/mmc/host/mxs-mmc.c | 8 ++++++++
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 +++++++++
> drivers/tty/serial/amba-pl011.c | 8 ++++++++
> drivers/tty/serial/mxs-auart.c | 8 ++++++++
> drivers/video/mxsfb.c | 9 +++++++++
> sound/soc/mxs/mxs-saif.c | 8 ++++++++
> 17 files changed, 84 insertions(+), 0 deletions(-)
>
> --
> 1.7.5.4
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
2012-05-07 7:14 ` Dong Aisheng
(?)
(?)
@ 2012-05-07 7:47 ` Shawn Guo
-1 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 7:47 UTC (permalink / raw)
To: Dong Aisheng
Cc: linux-arm-kernel, linux-fbdev, Chris Ball, Arnd Bergmann,
Florian Tobias Schandinat, Artem Bityutskiy, Mark Brown,
linux-mmc, alsa-devel, Wolfram Sang, linux-mtd, linux-i2c,
linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> As IMX, basically i'd prefer to add pinctrl states in dts file at the
> same time within the patch or using a separate patch to add them before
> this series to avoid breaking the exist platforms.
>
> However i noted that for mxs, most drivers here are still not dt capable,
> so it may be ok to not add their pinctrl state at this time.
>
There no mxs driver on mainline that has been DT aware of. What I'm
going to do is to ask Arnd abandon the mxs/dt branch I sent him before
and send him an updated one with the whole mxs DT support based on
mxs common clk and pinctrl series.
> But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> dt capable, so with this patch applied, the mx28 dt boot will fail.
> Maybe we should at least add pinctrl states for amba-pl011 first.
>
The updated mxs/dt will have pinctrl defined in dts for each device
that is converted to DT.
> > Shawn Guo (9):
> > ARM: mxs: enable pinctrl dummy states
> > serial: amba-pl011: adopt pinctrl support
> BTW, will this one break other platforms using this driver?
>
If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
turn on the support, they should provide pinctrl state either dummy or
real one.
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 34+ messages in thread
* [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:47 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 7:47 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> As IMX, basically i'd prefer to add pinctrl states in dts file at the
> same time within the patch or using a separate patch to add them before
> this series to avoid breaking the exist platforms.
>
> However i noted that for mxs, most drivers here are still not dt capable,
> so it may be ok to not add their pinctrl state at this time.
>
There no mxs driver on mainline that has been DT aware of. What I'm
going to do is to ask Arnd abandon the mxs/dt branch I sent him before
and send him an updated one with the whole mxs DT support based on
mxs common clk and pinctrl series.
> But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> dt capable, so with this patch applied, the mx28 dt boot will fail.
> Maybe we should at least add pinctrl states for amba-pl011 first.
>
The updated mxs/dt will have pinctrl defined in dts for each device
that is converted to DT.
> > Shawn Guo (9):
> > ARM: mxs: enable pinctrl dummy states
> > serial: amba-pl011: adopt pinctrl support
> BTW, will this one break other platforms using this driver?
>
If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
turn on the support, they should provide pinctrl state either dummy or
real one.
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:47 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 7:47 UTC (permalink / raw)
To: Dong Aisheng
Cc: linux-fbdev, Arnd Bergmann, Florian Tobias Schandinat,
Artem Bityutskiy, Mark Brown, linux-mmc, alsa-devel,
Wolfram Sang, linux-mtd, linux-i2c, linux-serial,
Greg Kroah-Hartman, Olof Johansson, Chris Ball, linux-arm-kernel
On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> As IMX, basically i'd prefer to add pinctrl states in dts file at the
> same time within the patch or using a separate patch to add them before
> this series to avoid breaking the exist platforms.
>
> However i noted that for mxs, most drivers here are still not dt capable,
> so it may be ok to not add their pinctrl state at this time.
>
There no mxs driver on mainline that has been DT aware of. What I'm
going to do is to ask Arnd abandon the mxs/dt branch I sent him before
and send him an updated one with the whole mxs DT support based on
mxs common clk and pinctrl series.
> But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> dt capable, so with this patch applied, the mx28 dt boot will fail.
> Maybe we should at least add pinctrl states for amba-pl011 first.
>
The updated mxs/dt will have pinctrl defined in dts for each device
that is converted to DT.
> > Shawn Guo (9):
> > ARM: mxs: enable pinctrl dummy states
> > serial: amba-pl011: adopt pinctrl support
> BTW, will this one break other platforms using this driver?
>
If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
turn on the support, they should provide pinctrl state either dummy or
real one.
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 7:47 ` Shawn Guo
0 siblings, 0 replies; 34+ messages in thread
From: Shawn Guo @ 2012-05-07 7:47 UTC (permalink / raw)
To: Dong Aisheng
Cc: linux-arm-kernel, linux-fbdev, Chris Ball, Arnd Bergmann,
Florian Tobias Schandinat, Artem Bityutskiy, Mark Brown,
linux-mmc, alsa-devel, Wolfram Sang, linux-mtd, linux-i2c,
linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> As IMX, basically i'd prefer to add pinctrl states in dts file at the
> same time within the patch or using a separate patch to add them before
> this series to avoid breaking the exist platforms.
>
> However i noted that for mxs, most drivers here are still not dt capable,
> so it may be ok to not add their pinctrl state at this time.
>
There no mxs driver on mainline that has been DT aware of. What I'm
going to do is to ask Arnd abandon the mxs/dt branch I sent him before
and send him an updated one with the whole mxs DT support based on
mxs common clk and pinctrl series.
> But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> dt capable, so with this patch applied, the mx28 dt boot will fail.
> Maybe we should at least add pinctrl states for amba-pl011 first.
>
The updated mxs/dt will have pinctrl defined in dts for each device
that is converted to DT.
> > Shawn Guo (9):
> > ARM: mxs: enable pinctrl dummy states
> > serial: amba-pl011: adopt pinctrl support
> BTW, will this one break other platforms using this driver?
>
If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
turn on the support, they should provide pinctrl state either dummy or
real one.
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
2012-05-07 7:47 ` Shawn Guo
(?)
(?)
@ 2012-05-07 8:01 ` Dong Aisheng
-1 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 7:56 UTC (permalink / raw)
To: Shawn Guo
Cc: Dong Aisheng-B29396, linux-arm-kernel, linux-fbdev, Chris Ball,
Arnd Bergmann, Florian Tobias Schandinat, Artem Bityutskiy,
Mark Brown, linux-mmc, alsa-devel, Wolfram Sang, linux-mtd,
linux-i2c, linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 03:47:00PM +0800, Shawn Guo wrote:
> On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> > As IMX, basically i'd prefer to add pinctrl states in dts file at the
> > same time within the patch or using a separate patch to add them before
> > this series to avoid breaking the exist platforms.
> >
> > However i noted that for mxs, most drivers here are still not dt capable,
> > so it may be ok to not add their pinctrl state at this time.
> >
> There no mxs driver on mainline that has been DT aware of. What I'm
> going to do is to ask Arnd abandon the mxs/dt branch I sent him before
> and send him an updated one with the whole mxs DT support based on
> mxs common clk and pinctrl series.
>
> > But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> > dt capable, so with this patch applied, the mx28 dt boot will fail.
> > Maybe we should at least add pinctrl states for amba-pl011 first.
> >
> The updated mxs/dt will have pinctrl defined in dts for each device
> that is converted to DT.
>
Well, i did not see amba-pl011 pinctrl states defined in this patch.
But it would be ok if you can get it done and applied before this patch.
> > > Shawn Guo (9):
> > > ARM: mxs: enable pinctrl dummy states
> > > serial: amba-pl011: adopt pinctrl support
> > BTW, will this one break other platforms using this driver?
> >
> If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
> turn on the support, they should provide pinctrl state either dummy or
> real one.
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 8:01 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 8:01 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 07, 2012 at 03:47:00PM +0800, Shawn Guo wrote:
> On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> > As IMX, basically i'd prefer to add pinctrl states in dts file at the
> > same time within the patch or using a separate patch to add them before
> > this series to avoid breaking the exist platforms.
> >
> > However i noted that for mxs, most drivers here are still not dt capable,
> > so it may be ok to not add their pinctrl state at this time.
> >
> There no mxs driver on mainline that has been DT aware of. What I'm
> going to do is to ask Arnd abandon the mxs/dt branch I sent him before
> and send him an updated one with the whole mxs DT support based on
> mxs common clk and pinctrl series.
>
> > But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> > dt capable, so with this patch applied, the mx28 dt boot will fail.
> > Maybe we should at least add pinctrl states for amba-pl011 first.
> >
> The updated mxs/dt will have pinctrl defined in dts for each device
> that is converted to DT.
>
Well, i did not see amba-pl011 pinctrl states defined in this patch.
But it would be ok if you can get it done and applied before this patch.
> > > Shawn Guo (9):
> > > ARM: mxs: enable pinctrl dummy states
> > > serial: amba-pl011: adopt pinctrl support
> > BTW, will this one break other platforms using this driver?
> >
> If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
> turn on the support, they should provide pinctrl state either dummy or
> real one.
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 8:01 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 8:01 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-fbdev, Arnd Bergmann, Florian Tobias Schandinat,
Artem Bityutskiy, Mark Brown, linux-mmc, alsa-devel,
Wolfram Sang, linux-mtd, linux-i2c, linux-serial,
Greg Kroah-Hartman, Olof Johansson, Chris Ball,
Dong Aisheng-B29396, linux-arm-kernel
On Mon, May 07, 2012 at 03:47:00PM +0800, Shawn Guo wrote:
> On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> > As IMX, basically i'd prefer to add pinctrl states in dts file at the
> > same time within the patch or using a separate patch to add them before
> > this series to avoid breaking the exist platforms.
> >
> > However i noted that for mxs, most drivers here are still not dt capable,
> > so it may be ok to not add their pinctrl state at this time.
> >
> There no mxs driver on mainline that has been DT aware of. What I'm
> going to do is to ask Arnd abandon the mxs/dt branch I sent him before
> and send him an updated one with the whole mxs DT support based on
> mxs common clk and pinctrl series.
>
> > But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> > dt capable, so with this patch applied, the mx28 dt boot will fail.
> > Maybe we should at least add pinctrl states for amba-pl011 first.
> >
> The updated mxs/dt will have pinctrl defined in dts for each device
> that is converted to DT.
>
Well, i did not see amba-pl011 pinctrl states defined in this patch.
But it would be ok if you can get it done and applied before this patch.
> > > Shawn Guo (9):
> > > ARM: mxs: enable pinctrl dummy states
> > > serial: amba-pl011: adopt pinctrl support
> > BTW, will this one break other platforms using this driver?
> >
> If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
> turn on the support, they should provide pinctrl state either dummy or
> real one.
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [alsa-devel] [PATCH RESEND 0/9] Enable pinctrl support for mach-mxs
@ 2012-05-07 8:01 ` Dong Aisheng
0 siblings, 0 replies; 34+ messages in thread
From: Dong Aisheng @ 2012-05-07 8:01 UTC (permalink / raw)
To: Shawn Guo
Cc: Dong Aisheng-B29396, linux-arm-kernel, linux-fbdev, Chris Ball,
Arnd Bergmann, Florian Tobias Schandinat, Artem Bityutskiy,
Mark Brown, linux-mmc, alsa-devel, Wolfram Sang, linux-mtd,
linux-i2c, linux-serial, Greg Kroah-Hartman, Olof Johansson
On Mon, May 07, 2012 at 03:47:00PM +0800, Shawn Guo wrote:
> On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote:
> > As IMX, basically i'd prefer to add pinctrl states in dts file at the
> > same time within the patch or using a separate patch to add them before
> > this series to avoid breaking the exist platforms.
> >
> > However i noted that for mxs, most drivers here are still not dt capable,
> > so it may be ok to not add their pinctrl state at this time.
> >
> There no mxs driver on mainline that has been DT aware of. What I'm
> going to do is to ask Arnd abandon the mxs/dt branch I sent him before
> and send him an updated one with the whole mxs DT support based on
> mxs common clk and pinctrl series.
>
> > But for the patch "serial: amba-pl011: adopt pinctrl support" since it is
> > dt capable, so with this patch applied, the mx28 dt boot will fail.
> > Maybe we should at least add pinctrl states for amba-pl011 first.
> >
> The updated mxs/dt will have pinctrl defined in dts for each device
> that is converted to DT.
>
Well, i did not see amba-pl011 pinctrl states defined in this patch.
But it would be ok if you can get it done and applied before this patch.
> > > Shawn Guo (9):
> > > ARM: mxs: enable pinctrl dummy states
> > > serial: amba-pl011: adopt pinctrl support
> > BTW, will this one break other platforms using this driver?
> >
> If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they
> turn on the support, they should provide pinctrl state either dummy or
> real one.
>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 34+ messages in thread