From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback
Date: Mon, 7 May 2012 11:52:09 -0400 [thread overview]
Message-ID: <20120507155209.GX32472@redhat.com> (raw)
In-Reply-To: <20120507131021.GE23858@gmail.com>
On Mon, May 07, 2012 at 03:10:21PM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > The end result of this more
> > complicated-looking-diff-than-it-really-is, is a patch that
> > mostly reverts
> >
> > 3603a25 x86, reboot: Use NMI instead of REBOOT_VECTOR to stop cpus
> >
> > and instead just sticks another if-case after the REBOOT_IRQ
> > and checks to see if online_cpus are still > 1, and if so,
> > clobber the rest of the cpus with an NMI.
>
> Ok, would be nice to shape this as a 'dumb' revert as-is, and do
> the simple change in a separate patch, or so. That makes it
> easier to review (and easier to debug, should it break).
Heh. I thought about that. I can do that and resend.
Cheers,
Don
next prev parent reply other threads:[~2012-05-07 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 20:24 [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-04-27 16:42 ` Seiji Aguchi
2012-05-03 2:45 ` Don Zickus
2012-05-07 13:10 ` Ingo Molnar
2012-05-07 15:52 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 20:27 [PATCH 0/2 v2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-13 20:27 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-03-02 20:41 ` Seiji Aguchi
2012-03-02 21:11 ` Don Zickus
2012-03-02 21:55 ` Seiji Aguchi
2012-02-10 21:02 [PATCH 0/2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-10 21:02 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507155209.GX32472@redhat.com \
--to=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.