From: Seiji Aguchi <seiji.aguchi@hds.com>
To: Don Zickus <dzickus@redhat.com>, "x86@kernel.org" <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"mjg@redhat.com" <mjg@redhat.com>,
"levinsasha928@gmail.com" <levinsasha928@gmail.com>
Subject: RE: [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback
Date: Fri, 2 Mar 2012 15:41:57 -0500 [thread overview]
Message-ID: <5C4C569E8A4B9B42A84A977CF070A35B2DACAECA8F@USINDEVS01.corp.hds.com> (raw)
In-Reply-To: <1329164860-668-2-git-send-email-dzickus@redhat.com>
> + /* if the REBOOT_VECTOR didn't work, try with the NMI */
> + if ((num_online_cpus() > 1) && (!smp_no_nmi_ipi)) {
> + if (register_nmi_handler(NMI_LOCAL, smp_stop_nmi_callback,
> + NMI_FLAG_FIRST, "smp_stop"))
register_nmi_handler() doesn't work if kernel panics in nmi context because kzalloc() is called in register_nmi_handler() and
it may sleep.
register_nmi_handler() should be replaced with notifier_chain like kdump does.
Seiji
next prev parent reply other threads:[~2012-03-02 20:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 20:27 [PATCH 0/2 v2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-13 20:27 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-03-02 20:41 ` Seiji Aguchi [this message]
2012-03-02 21:11 ` Don Zickus
2012-03-02 21:55 ` Seiji Aguchi
2012-02-13 20:27 ` [PATCH 2/2] x86, reschedule: check to see if system is shutting down Don Zickus
2012-02-13 21:22 ` Seiji Aguchi
2012-02-13 22:43 ` Don Zickus
2012-02-15 11:26 ` Peter Zijlstra
2012-02-15 14:54 ` Don Zickus
2012-02-15 14:57 ` Peter Zijlstra
2012-02-15 15:57 ` Don Zickus
2012-02-15 17:59 ` Peter Zijlstra
2012-02-16 3:14 ` Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2012-03-29 20:24 [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-04-27 16:42 ` Seiji Aguchi
2012-05-03 2:45 ` Don Zickus
2012-05-07 13:10 ` Ingo Molnar
2012-05-07 15:52 ` Don Zickus
2012-02-10 21:02 [PATCH 0/2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-10 21:02 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C4C569E8A4B9B42A84A977CF070A35B2DACAECA8F@USINDEVS01.corp.hds.com \
--to=seiji.aguchi@hds.com \
--cc=ak@linux.intel.com \
--cc=dzickus@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.