From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clkdev: Add default clkdev.h
Date: Mon, 14 May 2012 19:03:03 +0000 [thread overview]
Message-ID: <201205141903.04121.arnd@arndb.de> (raw)
In-Reply-To: <1337005167-22628-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Monday 14 May 2012, Mark Brown wrote:
> Ease the deployment of clkdev by providing a default asm/clkdev.h which
> will be used if the arch does not have an include/asm/clkdev.h.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/asm-generic/Kbuild.asm | 4 ++++
> include/asm-generic/clkdev.h | 26 ++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 include/asm-generic/clkdev.h
>
Good idea!
>diff --git a/include/asm-generic/Kbuild.asm b/include/asm-generic/Kbuild.asm
>index c5d2e5d..da121e0 100644
>--- a/include/asm-generic/Kbuild.asm
>+++ b/include/asm-generic/Kbuild.asm
>@@ -13,6 +13,10 @@ ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/a.out.h \
> header-y += a.out.h
> endif
>
>+ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/clkdev.h),)
>+generic-y += clkdev.h
>+endif
>+
> header-y += auxvec.h
> header-y += bitsperlong.h
> header-y += byteorder.h
I'm not completely sure about this part. It should work just fine, but we haven't
done this for any of the other asm/* headers. If we decide to list generic header
files in Kconfig.asm that automatically get added to architectures, I would prefer
doing it with a nicer syntax so we can do it for a lot of the other header files
too. For now, I'd prefer to just add the file manually to the asm/Kbuild files
in the architectures where it makes sense (e.g. all but s390).
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clkdev: Add default clkdev.h
Date: Mon, 14 May 2012 19:03:03 +0000 [thread overview]
Message-ID: <201205141903.04121.arnd@arndb.de> (raw)
In-Reply-To: <1337005167-22628-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Monday 14 May 2012, Mark Brown wrote:
> Ease the deployment of clkdev by providing a default asm/clkdev.h which
> will be used if the arch does not have an include/asm/clkdev.h.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/asm-generic/Kbuild.asm | 4 ++++
> include/asm-generic/clkdev.h | 26 ++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)
> create mode 100644 include/asm-generic/clkdev.h
>
Good idea!
>diff --git a/include/asm-generic/Kbuild.asm b/include/asm-generic/Kbuild.asm
>index c5d2e5d..da121e0 100644
>--- a/include/asm-generic/Kbuild.asm
>+++ b/include/asm-generic/Kbuild.asm
>@@ -13,6 +13,10 @@ ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/a.out.h \
> header-y += a.out.h
> endif
>
>+ifeq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/clkdev.h),)
>+generic-y += clkdev.h
>+endif
>+
> header-y += auxvec.h
> header-y += bitsperlong.h
> header-y += byteorder.h
I'm not completely sure about this part. It should work just fine, but we haven't
done this for any of the other asm/* headers. If we decide to list generic header
files in Kconfig.asm that automatically get added to architectures, I would prefer
doing it with a nicer syntax so we can do it for a lot of the other header files
too. For now, I'd prefer to just add the file manually to the asm/Kbuild files
in the architectures where it makes sense (e.g. all but s390).
Arnd
next prev parent reply other threads:[~2012-05-14 19:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 14:19 [PATCH] clkdev: Add default clkdev.h Mark Brown
2012-05-14 14:19 ` Mark Brown
2012-05-14 19:03 ` Arnd Bergmann [this message]
2012-05-14 19:03 ` Arnd Bergmann
2012-05-14 19:09 ` Mark Brown
2012-05-14 19:09 ` Mark Brown
2012-06-14 11:22 Mark Brown
2012-07-02 18:04 Mark Brown
2012-07-03 2:00 ` Stephen Rothwell
2012-07-03 10:12 ` Mark Brown
2012-07-03 11:16 ` Arnd Bergmann
2012-07-03 11:48 ` Mark Brown
2012-07-03 12:05 ` Stephen Rothwell
2012-07-03 12:33 ` Mark Brown
2012-07-03 13:15 ` Stephen Rothwell
2012-07-03 13:39 ` Arnd Bergmann
2012-07-03 13:47 ` Mark Brown
2012-07-09 22:23 ` Mike Turquette
2012-07-09 23:30 ` Russell King - ARM Linux
2012-07-10 17:22 ` Mark Brown
2012-07-10 18:07 ` Arnd Bergmann
2012-07-11 2:44 ` Paul Mundt
2012-07-11 6:32 ` Arnd Bergmann
2012-07-03 15:23 Mark Brown
2012-07-03 15:29 ` Stephen Rothwell
2012-07-04 8:00 ` Geert Uytterhoeven
2012-07-04 9:22 ` Mark Brown
2012-07-03 17:04 Mark Brown
2012-07-03 22:07 ` Stephen Rothwell
2012-08-25 18:16 Mark Brown
2012-08-28 18:56 Mark Brown
2012-09-05 4:04 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205141903.04121.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.