* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
@ 2012-05-10 5:23 Donghwa Lee
2012-05-10 14:12 ` Minkyu Kang
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Donghwa Lee @ 2012-05-10 5:23 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-10 5:23 [U-Boot] [PATCH v5 2/3] create lib/tizen directory Donghwa Lee
@ 2012-05-10 14:12 ` Minkyu Kang
2012-05-14 5:31 ` Mike Frysinger
2012-05-24 21:56 ` Anatolij Gustschin
2 siblings, 0 replies; 9+ messages in thread
From: Minkyu Kang @ 2012-05-10 14:12 UTC (permalink / raw)
To: u-boot
On 10 May 2012 14:23, Donghwa Lee <dh09.lee@samsung.com> wrote:
> From 01bebda80c7cb128048e4c1c89f2b5b1cdbfd67d Mon Sep 17 00:00:00 2001
> From: Donghwa Lee <dh09.lee@samsung.com>
> Date: Thu, 10 May 2012 12:02:55 +0900
> Subject: [PATCH] v5: create lib/tizen directory
>
> This directory includes tizen logo data, common tizen library and so on.
>
> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changes for v4:
> ? ? ? ?- remove get_tizen_hd_logo* functions and get data directly
> ? ? ? ?- changes tizen hd logo data variables name
> ? ? ? ?- get_tizen_logo_info() uses parameter that vidinfo_t *vid.
>
> Changes for v3:
> ? ? ? ?- create common get logo infomation function.
> ? ? ? ?- define logo resolution
>
> Changes for v2:
> ? ? ? ?- create lib/tizen directory and moves logo data to lib/tizen.
> ? ? ? ?- create common tizen library function.
> ? ? ? ?- changes patch name from "LCD: add compressed 32bpp BMP image data"
> ? ? ? ?to crete lib/tizen directory
>
> Changes for v1:
> ? ? ? ?- moves to logo data from arch/arm to include/
>
> ?Makefile ? ? ? ? ? ? ? ? ? ? ? | ? ?1 +
> ?include/libtizen.h ? ? ? ? ? ? | ? 30 +
> ?lib/tizen/Makefile ? ? ? ? ? ? | ? 46 +
> ?lib/tizen/tizen.c ? ? ? ? ? ? ?| ? 40 +
> ?lib/tizen/tizen_hd_logo.h ? ? ?| 5071 ++++++++++++++++++++++++++++++++++++++++
> ?lib/tizen/tizen_hd_logo_data.h | ? 30 +
> ?6 files changed, 5218 insertions(+), 0 deletions(-)
> ?create mode 100644 include/libtizen.h
> ?create mode 100644 lib/tizen/Makefile
> ?create mode 100644 lib/tizen/tizen.c
> ?create mode 100644 lib/tizen/tizen_hd_logo.h
> ?create mode 100644 lib/tizen/tizen_hd_logo_data.h
>
Acked-by: Minkyu Kang <mk7.kang@samsung.com>
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-10 5:23 [U-Boot] [PATCH v5 2/3] create lib/tizen directory Donghwa Lee
2012-05-10 14:12 ` Minkyu Kang
@ 2012-05-14 5:31 ` Mike Frysinger
2012-05-14 5:37 ` Kyungmin Park
2012-05-24 21:56 ` Anatolij Gustschin
2 siblings, 1 reply; 9+ messages in thread
From: Mike Frysinger @ 2012-05-14 5:31 UTC (permalink / raw)
To: u-boot
On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
> Makefile | 1 +
> include/libtizen.h | 30 +
> lib/tizen/Makefile | 46 +
> lib/tizen/tizen.c | 40 +
> lib/tizen/tizen_hd_logo.h | 5071
> lib/tizen/tizen_hd_logo_data.h | 30 +
do you really need your own lib/tizen/ dir for a logo ? every one who doesn't
build this still has to waste time going into lib/tizen/ to create an empty
object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN too.
also, where are the boards that actually use this ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/e14c8035/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-14 5:31 ` Mike Frysinger
@ 2012-05-14 5:37 ` Kyungmin Park
2012-05-14 5:45 ` Mike Frysinger
0 siblings, 1 reply; 9+ messages in thread
From: Kyungmin Park @ 2012-05-14 5:37 UTC (permalink / raw)
To: u-boot
Hi,
On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
>> Makefile | 1 +
>> include/libtizen.h | 30 +
>> lib/tizen/Makefile | 46 +
>> lib/tizen/tizen.c | 40 +
>> lib/tizen/tizen_hd_logo.h | 5071
>> lib/tizen/tizen_hd_logo_data.h | 30 +
>
> do you really need your own lib/tizen/ dir for a logo ? every one who
> doesn't
> build this still has to waste time going into lib/tizen/ to create an empty
>
> object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN
> too.
It uses the same method as others does.
e.g., libfdt
In Makefile
LIBS += lib/libfdt/libfdt.o
In "lib/libfdt/Makefile"
SOBJS =
COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
>
> also, where are the boards that actually use this ?
board/samsung/trats uses this logo.
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-14 5:37 ` Kyungmin Park
@ 2012-05-14 5:45 ` Mike Frysinger
2012-05-14 7:27 ` Kyungmin Park
0 siblings, 1 reply; 9+ messages in thread
From: Mike Frysinger @ 2012-05-14 5:45 UTC (permalink / raw)
To: u-boot
On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
> >> Makefile | 1 +
> >> include/libtizen.h | 30 +
> >> lib/tizen/Makefile | 46 +
> >> lib/tizen/tizen.c | 40 +
> >> lib/tizen/tizen_hd_logo.h | 5071
> >>
> >> lib/tizen/tizen_hd_logo_data.h | 30 +
> >
> > do you really need your own lib/tizen/ dir for a logo ? every one who
> > doesn't
> > build this still has to waste time going into lib/tizen/ to create an
> > empty
> >
> > object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN
> > too.
>
> It uses the same method as others does.
> e.g., libfdt
>
> In Makefile
> LIBS += lib/libfdt/libfdt.o
>
> In "lib/libfdt/Makefile"
> SOBJS =
>
> COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
>
> COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
> COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
the difference is they have more than one CONFIG symbol going on, and their
code base is sizable, and many arches/boards utilize it. you're adding a
single file with a single function with a single CONFIG knob for a single
board.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/dc30be80/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-14 5:45 ` Mike Frysinger
@ 2012-05-14 7:27 ` Kyungmin Park
2012-05-15 5:14 ` Mike Frysinger
0 siblings, 1 reply; 9+ messages in thread
From: Kyungmin Park @ 2012-05-14 7:27 UTC (permalink / raw)
To: u-boot
On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
>> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
>> > On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
>> >> Makefile | 1 +
>> >> include/libtizen.h | 30 +
>> >> lib/tizen/Makefile | 46 +
>> >> lib/tizen/tizen.c | 40 +
>> >> lib/tizen/tizen_hd_logo.h | 5071
>> >>
>> >> lib/tizen/tizen_hd_logo_data.h | 30 +
>> >
>> > do you really need your own lib/tizen/ dir for a logo ? every one who
>> > doesn't
>> > build this still has to waste time going into lib/tizen/ to create an
>> > empty
>> >
>> > object. at least make the addition of lib/tizen/ depend on
>> > CONFIG_TIZEN
>> > too.
>>
>> It uses the same method as others does.
>> e.g., libfdt
>>
>> In Makefile
>> LIBS += lib/libfdt/libfdt.o
>>
>> In "lib/libfdt/Makefile"
>> SOBJS =
>>
>> COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
>>
>> COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
>> COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
>
> the difference is they have more than one CONFIG symbol going on, and their
>
> code base is sizable, and many arches/boards utilize it. you're adding a
> single file with a single function with a single CONFIG knob for a single
> board.
Right, So we asked it first, which directory is proper. and suggested
that the create the lib/tizen instead of others. since it's not
platform, nor soc specific.
Of course this suggestion from Wolfgang.
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-14 7:27 ` Kyungmin Park
@ 2012-05-15 5:14 ` Mike Frysinger
0 siblings, 0 replies; 9+ messages in thread
From: Mike Frysinger @ 2012-05-15 5:14 UTC (permalink / raw)
To: u-boot
On Monday 14 May 2012 03:27:55 Kyungmin Park wrote:
> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
> >> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> >> > On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
> >> >> Makefile | 1 +
> >> >> include/libtizen.h | 30 +
> >> >> lib/tizen/Makefile | 46 +
> >> >> lib/tizen/tizen.c | 40 +
> >> >> lib/tizen/tizen_hd_logo.h | 5071
> >> >> lib/tizen/tizen_hd_logo_data.h | 30 +
> >> >
> >> > do you really need your own lib/tizen/ dir for a logo ? every one who
> >> > doesn't
> >> > build this still has to waste time going into lib/tizen/ to create an
> >> > empty
> >> >
> >> > object. at least make the addition of lib/tizen/ depend on
> >> > CONFIG_TIZEN
> >> > too.
> >>
> >> It uses the same method as others does.
> >> e.g., libfdt
> >>
> >> In Makefile
> >> LIBS += lib/libfdt/libfdt.o
> >>
> >> In "lib/libfdt/Makefile"
> >> SOBJS =
> >>
> >> COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o
> >> fdt_wip.o
> >>
> >> COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
> >> COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
> >
> > the difference is they have more than one CONFIG symbol going on, and
> > their
> >
> > code base is sizable, and many arches/boards utilize it. you're adding a
> > single file with a single function with a single CONFIG knob for a single
> > board.
>
> Right, So we asked it first, which directory is proper. and suggested
> that the create the lib/tizen instead of others. since it's not
> platform, nor soc specific.
you can still do in the top level to avoid affecting other people:
ifeq ($(CONFIG_TIZEN),y)
LIBS += lib/tizen/libtizen.o
endif
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120515/fb96b4f3/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
2012-05-10 5:23 [U-Boot] [PATCH v5 2/3] create lib/tizen directory Donghwa Lee
2012-05-10 14:12 ` Minkyu Kang
2012-05-14 5:31 ` Mike Frysinger
@ 2012-05-24 21:56 ` Anatolij Gustschin
2 siblings, 0 replies; 9+ messages in thread
From: Anatolij Gustschin @ 2012-05-24 21:56 UTC (permalink / raw)
To: u-boot
Hi,
On Thu, 10 May 2012 14:23:40 +0900
Donghwa Lee <dh09.lee@samsung.com> wrote:
> From 01bebda80c7cb128048e4c1c89f2b5b1cdbfd67d Mon Sep 17 00:00:00 2001
> From: Donghwa Lee <dh09.lee@samsung.com>
> Date: Thu, 10 May 2012 12:02:55 +0900
> Subject: [PATCH] v5: create lib/tizen directory
>
> This directory includes tizen logo data, common tizen library and so on.
>
> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changes for v4:
> - remove get_tizen_hd_logo* functions and get data directly
> - changes tizen hd logo data variables name
> - get_tizen_logo_info() uses parameter that vidinfo_t *vid.
>
> Changes for v3:
> - create common get logo infomation function.
> - define logo resolution
>
> Changes for v2:
> - create lib/tizen directory and moves logo data to lib/tizen.
> - create common tizen library function.
> - changes patch name from "LCD: add compressed 32bpp BMP image data"
> to crete lib/tizen directory
>
> Changes for v1:
> - moves to logo data from arch/arm to include/
>
> Makefile | 1 +
> include/libtizen.h | 30 +
> lib/tizen/Makefile | 46 +
> lib/tizen/tizen.c | 40 +
> lib/tizen/tizen_hd_logo.h | 5071 ++++++++++++++++++++++++++++++++++++++++
> lib/tizen/tizen_hd_logo_data.h | 30 +
> 6 files changed, 5218 insertions(+), 0 deletions(-)
> create mode 100644 include/libtizen.h
> create mode 100644 lib/tizen/Makefile
> create mode 100644 lib/tizen/tizen.c
> create mode 100644 lib/tizen/tizen_hd_logo.h
> create mode 100644 lib/tizen/tizen_hd_logo_data.h
Applied to u-boot-video/master after changing to conditionally build
lib/tizen/ directory. Thanks.
Anatolij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v5 2/3] create lib/tizen directory
[not found] <0M4500GCQ6DX82K0@ms2.samsung.com>
@ 2012-05-17 0:54 ` Donghwa Lee
0 siblings, 0 replies; 9+ messages in thread
From: Donghwa Lee @ 2012-05-17 0:54 UTC (permalink / raw)
To: u-boot
> On Monday 14 May 2012 03:27:55 Kyungmin Park wrote:
>> On 5/14/12, Mike Frysinger wrote:
>> > On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
>> >> On 5/14/12, Mike Frysinger wrote:
>> >> > On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
>> >> >> Makefile | 1 +
>> >> >> include/libtizen.h | 30 +
>> >> >> lib/tizen/Makefile | 46 +
>> >> >> lib/tizen/tizen.c | 40 +
>> >> >> lib/tizen/tizen_hd_logo.h | 5071
>> >> >> lib/tizen/tizen_hd_logo_data.h | 30 +
>> >> >
>> >> > do you really need your own lib/tizen/ dir for a logo ? every one who
>> >> > doesn't
>> >> > build this still has to waste time going into lib/tizen/ to create an
>> >> > empty
>> >> >
>> >> > object. at least make the addition of lib/tizen/ depend on
>> >> > CONFIG_TIZEN
>> >> > too.
>> >>
>> >> It uses the same method as others does.
>> >> e.g., libfdt
>> >>
>> >> In Makefile
>> >> LIBS += lib/libfdt/libfdt.o
>> >>
>> >> In "lib/libfdt/Makefile"
>> >> SOBJS =
>> >>
>> >> COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o
>> >> fdt_wip.o
>> >>
>> >> COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
>> >> COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
>> >
>> > the difference is they have more than one CONFIG symbol going on, and
>> > their
>> >
>> > code base is sizable, and many arches/boards utilize it. you're adding a
>> > single file with a single function with a single CONFIG knob for a single
>> > board.
>>
>> Right, So we asked it first, which directory is proper. and suggested
>> that the create the lib/tizen instead of others. since it's not
>> platform, nor soc specific.
>
> you can still do in the top level to avoid affecting other people:
> ifeq ($(CONFIG_TIZEN),y)
> LIBS += lib/tizen/libtizen.o
> endif
> -mike
>
Ok, I will update it later.
Thank you,
Donghwa Lee.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-24 21:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-10 5:23 [U-Boot] [PATCH v5 2/3] create lib/tizen directory Donghwa Lee
2012-05-10 14:12 ` Minkyu Kang
2012-05-14 5:31 ` Mike Frysinger
2012-05-14 5:37 ` Kyungmin Park
2012-05-14 5:45 ` Mike Frysinger
2012-05-14 7:27 ` Kyungmin Park
2012-05-15 5:14 ` Mike Frysinger
2012-05-24 21:56 ` Anatolij Gustschin
[not found] <0M4500GCQ6DX82K0@ms2.samsung.com>
2012-05-17 0:54 ` Donghwa Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.