All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@laptop.org>
To: mchehab@infradead.org, corbet@lwn.net
Cc: linux-media@vger.kernel.org
Subject: [PATCH] mmp-camera: specify XO-1.75 clock speed
Date: Tue, 15 May 2012 20:43:31 +0100 (BST)	[thread overview]
Message-ID: <20120515194331.77C519D401E@zog.reactivated.net> (raw)

For the ov7670 camera to return images at the requested frame rate,
it needs to make calculations based on the clock speed, which is
a completely external factor (depends on the wiring of the system).

On the XO-1.75, which is the only known mmp-camera user, the camera
is clocked at 48MHz.

Pass this information to the ov7670 driver, to fix an issue where
a framerate faster than the requested amount was being provided.

Signed-off-by: Daniel Drake <dsd@laptop.org>
---
 drivers/media/video/marvell-ccic/mmp-driver.c |    7 +++++++
 1 file changed, 7 insertions(+)

Jon, is it OK to assume that XO-1.75 is the only mmp-camera user?

diff --git a/drivers/media/video/marvell-ccic/mmp-driver.c b/drivers/media/video/marvell-ccic/mmp-driver.c
index c4c17fe..0ba49c7 100644
--- a/drivers/media/video/marvell-ccic/mmp-driver.c
+++ b/drivers/media/video/marvell-ccic/mmp-driver.c
@@ -188,6 +188,13 @@ static int mmpcam_probe(struct platform_device *pdev)
 	mcam->chip_id = V4L2_IDENT_ARMADA610;
 	mcam->buffer_mode = B_DMA_sg;
 	spin_lock_init(&mcam->dev_lock);
+
+	/*
+	 * Set the clock speed for the XO-1.75; I don't believe this
+	 * driver has ever run anywhere else.
+	 */
+	mcam->clock_speed = 48;
+
 	/*
 	 * Get our I/O memory.
 	 */
-- 
1.7.10.1


             reply	other threads:[~2012-05-15 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 19:43 Daniel Drake [this message]
2012-05-16 21:12 ` [PATCH] mmp-camera: specify XO-1.75 clock speed Jonathan Corbet
2012-05-16 21:15   ` Daniel Drake
2012-05-20 15:18     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515194331.77C519D401E@zog.reactivated.net \
    --to=dsd@laptop.org \
    --cc=corbet@lwn.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.