All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Daniel Drake <dsd@laptop.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	mchehab@infradead.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] mmp-camera: specify XO-1.75 clock speed
Date: Sun, 20 May 2012 12:18:02 -0300	[thread overview]
Message-ID: <4FB90B2A.709@redhat.com> (raw)
In-Reply-To: <CAMLZHHTb+wgRiefVrA2rq0GCUPiBj4jm=kU2QGq1JGq+=6yCuA@mail.gmail.com>

Em 16-05-2012 18:15, Daniel Drake escreveu:
> On Wed, May 16, 2012 at 3:12 PM, Jonathan Corbet <corbet@lwn.net> wrote:
>> On Tue, 15 May 2012 20:43:31 +0100 (BST)
>> Daniel Drake <dsd@laptop.org> wrote:
>>
>>> Jon, is it OK to assume that XO-1.75 is the only mmp-camera user?
>>
>> It's the only one I know of at the moment, certainly.
>>
>> Even so, I think it would be a lot better to put this parameter into the
>> mmp_camera_platform_data structure instead of wiring it into the driver
>> source; it could then be set in olpc-xo-1-75.c with the other relevant
>> parameters.  I won't oppose the inclusion of this patch, but...any chance
>> it could be done that way?
> 
> I'll look into it. Please put this patch on pause for now.

I've marked this patch as "changes requested" at patchwork:
	http://patchwork.linuxtv.org/patch/11270/

I agree with Jon: adding such config stuff at platform data is better.

Regards,
Mauro

      reply	other threads:[~2012-05-20 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 19:43 [PATCH] mmp-camera: specify XO-1.75 clock speed Daniel Drake
2012-05-16 21:12 ` Jonathan Corbet
2012-05-16 21:15   ` Daniel Drake
2012-05-20 15:18     ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB90B2A.709@redhat.com \
    --to=mchehab@redhat.com \
    --cc=corbet@lwn.net \
    --cc=dsd@laptop.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.