* linux-next: build failure after merge of the final tree (battery tree related)
@ 2012-05-07 7:14 Stephen Rothwell
2012-05-07 8:26 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2012-05-07 7:14 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linux-next, linux-kernel, Mika Westerberg
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/power/smb347-charger.c: In function 'smb347_probe':
drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").
I have reverted that commit for today (and commit fcc015cda7df
"smb347-charger: Clean up battery attributes" that conflicted with the
revert).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (battery tree related)
2012-05-07 7:14 linux-next: build failure after merge of the final tree (battery tree related) Stephen Rothwell
@ 2012-05-07 8:26 ` Mika Westerberg
2012-05-16 6:12 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2012-05-07 8:26 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Anton Vorontsov, linux-next, linux-kernel
On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/power/smb347-charger.c: In function 'smb347_probe':
> drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>
> Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").
I'm unable to reproduce this on x86 build. I guess <linux/err.h> gets
included implicitly there.
Patch below should fix this. Anton, care to pick this one as well (or fold
it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)?
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] smb347-charger: include missing <linux/err.h>
Without the include we get build errors like:
drivers/power/smb347-charger.c: In function 'smb347_probe':
drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/power/smb347-charger.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
index 09d19d2..f8eedd8 100644
--- a/drivers/power/smb347-charger.c
+++ b/drivers/power/smb347-charger.c
@@ -11,6 +11,7 @@
* published by the Free Software Foundation.
*/
+#include <linux/err.h>
#include <linux/gpio.h>
#include <linux/kernel.h>
#include <linux/module.h>
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (battery tree related)
2012-05-07 8:26 ` Mika Westerberg
@ 2012-05-16 6:12 ` Stephen Rothwell
2012-05-19 0:16 ` Anton Vorontsov
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2012-05-16 6:12 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Anton Vorontsov, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]
Hi all,
On Mon, 7 May 2012 11:26:37 +0300 Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/power/smb347-charger.c: In function 'smb347_probe':
> > drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> > drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> >
> > Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").
>
> I'm unable to reproduce this on x86 build. I guess <linux/err.h> gets
> included implicitly there.
>
> Patch below should fix this. Anton, care to pick this one as well (or fold
> it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)?
>
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> Subject: [PATCH] smb347-charger: include missing <linux/err.h>
>
> Without the include we get build errors like:
>
> drivers/power/smb347-charger.c: In function 'smb347_probe':
> drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/power/smb347-charger.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> index 09d19d2..f8eedd8 100644
> --- a/drivers/power/smb347-charger.c
> +++ b/drivers/power/smb347-charger.c
> @@ -11,6 +11,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/err.h>
> #include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
Ping?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (battery tree related)
2012-05-16 6:12 ` Stephen Rothwell
@ 2012-05-19 0:16 ` Anton Vorontsov
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2012-05-19 0:16 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Mika Westerberg, linux-next, linux-kernel
On Wed, May 16, 2012 at 04:12:56PM +1000, Stephen Rothwell wrote:
[...]
> > diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> > index 09d19d2..f8eedd8 100644
> > --- a/drivers/power/smb347-charger.c
> > +++ b/drivers/power/smb347-charger.c
> > @@ -11,6 +11,7 @@
> > * published by the Free Software Foundation.
> > */
> >
> > +#include <linux/err.h>
> > #include <linux/gpio.h>
> > #include <linux/kernel.h>
> > #include <linux/module.h>
>
> Ping?
Applied, thank you!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the final tree (battery tree related)
@ 2011-04-21 22:05 Stephen Rothwell
2011-04-21 23:27 ` Anton Vorontsov
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2011-04-21 22:05 UTC (permalink / raw)
To: Anton Vorontsov
Cc: linux-next, linux-kernel, MyungJoo Ham, Martin Schwidefsky,
Heiko Carstens
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi Anton,
After merging the final tree, today's linux-next build (s390 allyesconfig)
failed like this:
drivers/built-in.o: In function `max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
drivers/power/max8903_charger.c:359: undefined reference to `free_irq'
Caused by commit b14a9ccc1ddd ("power_supply: Add driver for MAX8903
charger"). This driver needs some Kconfig dependency.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (battery tree related)
2011-04-21 22:05 Stephen Rothwell
@ 2011-04-21 23:27 ` Anton Vorontsov
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2011-04-21 23:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, MyungJoo Ham, Martin Schwidefsky,
Heiko Carstens
Hi Stephen,
On Fri, Apr 22, 2011 at 08:05:55AM +1000, Stephen Rothwell wrote:
> Hi Anton,
>
> After merging the final tree, today's linux-next build (s390 allyesconfig)
> failed like this:
>
> drivers/built-in.o: In function `max8903_remove':
> drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:359: undefined reference to `free_irq'
I added the following patch to the battery-2.6.git, so this should be
fixed now. Thanks!
commit 6f9efe76cb213e9b0dd89e465efaf9725f4bf492
Author: Anton Vorontsov <cbouatmailru@gmail.com>
Date: Fri Apr 22 03:08:22 2011 +0400
max8903_charger: Add GENERIC_HARDIRQS as a dependency (fixes S390 build)
S390 is special as it doesn't have IRQ lines, so these errors pop up:
drivers/built-in.o: In function 'max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:357: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:359: undefined reference to 'free_irq'
This commit fixes the issue by making the driver depend on
GENERIC_HARDIRQS feature.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 1f50ebc..cc019c9 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -205,6 +205,7 @@ config CHARGER_ISP1704
config CHARGER_MAX8903
tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
+ depends on GENERIC_HARDIRQS
help
Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
The driver supports controlling charger-enable and current-limit
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-19 0:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-07 7:14 linux-next: build failure after merge of the final tree (battery tree related) Stephen Rothwell
2012-05-07 8:26 ` Mika Westerberg
2012-05-16 6:12 ` Stephen Rothwell
2012-05-19 0:16 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2011-04-21 22:05 Stephen Rothwell
2011-04-21 23:27 ` Anton Vorontsov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.