* [patch] dlm: remove stray unlock
@ 2012-05-21 14:35 Dan Carpenter
2012-05-21 15:39 ` [Cluster-devel] " David Teigland
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-05-21 14:35 UTC (permalink / raw)
To: kernel-janitors
Smatch complains that we unlock this twice. It looks like an accidental
to me.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This was added in 525f31c1f3 ("dlm: fix race between remove and lookup")
Untested.
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 06063a3..1c10bf4 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -1570,7 +1570,6 @@ static void wait_pending_remove(struct dlm_rsb *r_new)
continue;
if (rsb_cmp(r_new, r->res_name, r->res_length))
continue;
- spin_unlock(&ls->ls_send_remove_spin);
log_debug(ls, "delay lookup %p for remove %p dir %d %s",
r_new, r, r_new->res_dir_nodeid, r_new->res_name);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] dlm: remove stray unlock
2012-05-21 14:35 [patch] dlm: remove stray unlock Dan Carpenter
@ 2012-05-21 15:39 ` David Teigland
0 siblings, 0 replies; 3+ messages in thread
From: David Teigland @ 2012-05-21 15:39 UTC (permalink / raw)
To: kernel-janitors
On Mon, May 21, 2012 at 05:35:26PM +0300, Dan Carpenter wrote:
> Smatch complains that we unlock this twice. It looks like an accidental
> to me.
Thanks, will fix that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [patch] dlm: remove stray unlock
@ 2012-05-21 15:39 ` David Teigland
0 siblings, 0 replies; 3+ messages in thread
From: David Teigland @ 2012-05-21 15:39 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Mon, May 21, 2012 at 05:35:26PM +0300, Dan Carpenter wrote:
> Smatch complains that we unlock this twice. It looks like an accidental
> to me.
Thanks, will fix that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-21 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-21 14:35 [patch] dlm: remove stray unlock Dan Carpenter
2012-05-21 15:39 ` David Teigland
2012-05-21 15:39 ` [Cluster-devel] " David Teigland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.