All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: do not disable netfront in dom0
@ 2012-05-20 11:45 Marek Marczykowski
  0 siblings, 0 replies; 17+ messages in thread
From: Marek Marczykowski @ 2012-05-20 11:45 UTC (permalink / raw)
  To: xen-devel
  Cc: Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, netdev,
	Marek Marczykowski, linux-kernel, virtualization

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
---
 drivers/net/xen-netfront.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 698b905..e31ebff 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1953,9 +1953,6 @@ static int __init netif_init(void)
 	if (!xen_domain())
 		return -ENODEV;
 
-	if (xen_initial_domain())
-		return 0;
-
 	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
 
 	return xenbus_register_frontend(&netfront_driver);
@@ -1965,9 +1962,6 @@ module_init(netif_init);
 
 static void __exit netif_exit(void)
 {
-	if (xen_initial_domain())
-		return;
-
 	xenbus_unregister_driver(&netfront_driver);
 }
 module_exit(netif_exit);
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-22 19:38     ` [Xen-devel] " David Miller
@ 2012-05-22 19:43       ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 17+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-22 19:43 UTC (permalink / raw)
  To: David Miller
  Cc: jeremy, Ian.Campbell, netdev, marmarek, virtualization,
	xen-devel, linux-kernel

On Tue, May 22, 2012 at 03:38:47PM -0400, David Miller wrote:
> From: Ian Campbell <Ian.Campbell@citrix.com>
> Date: Tue, 22 May 2012 20:30:28 +0100
> 
> > On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
> >> From: Marek Marczykowski <marmarek@invisiblethingslab.com>
> >> Date: Sun, 20 May 2012 13:45:10 +0200
> >> 
> >> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> >> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> >> > is the only way to get network access in dom0.
> >> > 
> >> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> >> 
> >> Someone please review this and I can merge it in via the 'net' tree if
> >> it looks OK to XEN folks.
> > 
> > Konrad is "Xen folks" and has acked it already but FWIW:
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Ok, but this patch doesn't appply cleanly at all to Linus's
> current tree nor my 'net' tree (which are equal right now).

Oh no! Marek, can you repin it please (along with all the Ack's on it).

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-22 19:30   ` [Xen-devel] " Ian Campbell
@ 2012-05-22 19:38     ` David Miller
  2012-05-22 19:38     ` [Xen-devel] " David Miller
  1 sibling, 0 replies; 17+ messages in thread
From: David Miller @ 2012-05-22 19:38 UTC (permalink / raw)
  To: Ian.Campbell
  Cc: jeremy, konrad.wilk, netdev, marmarek, virtualization, xen-devel,
	linux-kernel

From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Tue, 22 May 2012 20:30:28 +0100

> On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
>> From: Marek Marczykowski <marmarek@invisiblethingslab.com>
>> Date: Sun, 20 May 2012 13:45:10 +0200
>> 
>> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
>> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
>> > is the only way to get network access in dom0.
>> > 
>> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
>> 
>> Someone please review this and I can merge it in via the 'net' tree if
>> it looks OK to XEN folks.
> 
> Konrad is "Xen folks" and has acked it already but FWIW:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ok, but this patch doesn't appply cleanly at all to Linus's
current tree nor my 'net' tree (which are equal right now).

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-22 19:13   ` David Miller
  (?)
@ 2012-05-22 19:30   ` Ian Campbell
  -1 siblings, 0 replies; 17+ messages in thread
From: Ian Campbell @ 2012-05-22 19:30 UTC (permalink / raw)
  To: David Miller
  Cc: jeremy, konrad.wilk, netdev, marmarek, virtualization, xen-devel,
	linux-kernel

On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
> From: Marek Marczykowski <marmarek@invisiblethingslab.com>
> Date: Sun, 20 May 2012 13:45:10 +0200
> 
> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> > is the only way to get network access in dom0.
> > 
> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> 
> Someone please review this and I can merge it in via the 'net' tree if
> it looks OK to XEN folks.

Konrad is "Xen folks" and has acked it already but FWIW:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.

> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 ` Marek Marczykowski
@ 2012-05-22 19:13   ` David Miller
  -1 siblings, 0 replies; 17+ messages in thread
From: David Miller @ 2012-05-22 19:13 UTC (permalink / raw)
  To: marmarek
  Cc: xen-devel, virtualization, konrad.wilk, jeremy, netdev, linux-kernel

From: Marek Marczykowski <marmarek@invisiblethingslab.com>
Date: Sun, 20 May 2012 13:45:10 +0200

> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Someone please review this and I can merge it in via the 'net' tree if
it looks OK to XEN folks.

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
@ 2012-05-22 19:13   ` David Miller
  0 siblings, 0 replies; 17+ messages in thread
From: David Miller @ 2012-05-22 19:13 UTC (permalink / raw)
  To: marmarek
  Cc: jeremy, konrad.wilk, netdev, linux-kernel, virtualization, xen-devel

From: Marek Marczykowski <marmarek@invisiblethingslab.com>
Date: Sun, 20 May 2012 13:45:10 +0200

> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Someone please review this and I can merge it in via the 'net' tree if
it looks OK to XEN folks.

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 ` Marek Marczykowski
                   ` (3 preceding siblings ...)
  (?)
@ 2012-05-22 19:13 ` David Miller
  -1 siblings, 0 replies; 17+ messages in thread
From: David Miller @ 2012-05-22 19:13 UTC (permalink / raw)
  To: marmarek
  Cc: jeremy, konrad.wilk, netdev, linux-kernel, virtualization, xen-devel

From: Marek Marczykowski <marmarek@invisiblethingslab.com>
Date: Sun, 20 May 2012 13:45:10 +0200

> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Someone please review this and I can merge it in via the 'net' tree if
it looks OK to XEN folks.

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 ` Marek Marczykowski
@ 2012-05-22 18:34   ` Konrad Rzeszutek Wilk
  -1 siblings, 0 replies; 17+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-22 18:34 UTC (permalink / raw)
  To: Marek Marczykowski, davem
  Cc: xen-devel, virtualization, Jeremy Fitzhardinge, netdev, linux-kernel

On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>


> ---
>  drivers/net/xen-netfront.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e31ebff 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	if (xen_initial_domain())
> -		return 0;
> -
>  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>  
>  	return xenbus_register_frontend(&netfront_driver);
> @@ -1965,9 +1962,6 @@ module_init(netif_init);
>  
>  static void __exit netif_exit(void)
>  {
> -	if (xen_initial_domain())
> -		return;
> -
>  	xenbus_unregister_driver(&netfront_driver);
>  }
>  module_exit(netif_exit);
> -- 
> 1.7.4.4

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
@ 2012-05-22 18:34   ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 17+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-22 18:34 UTC (permalink / raw)
  To: Marek Marczykowski, davem
  Cc: netdev, Jeremy Fitzhardinge, virtualization, linux-kernel, xen-devel

On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>


> ---
>  drivers/net/xen-netfront.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e31ebff 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	if (xen_initial_domain())
> -		return 0;
> -
>  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>  
>  	return xenbus_register_frontend(&netfront_driver);
> @@ -1965,9 +1962,6 @@ module_init(netif_init);
>  
>  static void __exit netif_exit(void)
>  {
> -	if (xen_initial_domain())
> -		return;
> -
>  	xenbus_unregister_driver(&netfront_driver);
>  }
>  module_exit(netif_exit);
> -- 
> 1.7.4.4

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 ` Marek Marczykowski
  (?)
@ 2012-05-22 18:34 ` Konrad Rzeszutek Wilk
  -1 siblings, 0 replies; 17+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-22 18:34 UTC (permalink / raw)
  To: Marek Marczykowski, davem
  Cc: netdev, Jeremy Fitzhardinge, virtualization, linux-kernel, xen-devel

On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>


> ---
>  drivers/net/xen-netfront.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e31ebff 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	if (xen_initial_domain())
> -		return 0;
> -
>  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>  
>  	return xenbus_register_frontend(&netfront_driver);
> @@ -1965,9 +1962,6 @@ module_init(netif_init);
>  
>  static void __exit netif_exit(void)
>  {
> -	if (xen_initial_domain())
> -		return;
> -
>  	xenbus_unregister_driver(&netfront_driver);
>  }
>  module_exit(netif_exit);
> -- 
> 1.7.4.4

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-21 16:05   ` Ian Campbell
@ 2012-05-21 16:11     ` Stefano Stabellini
  0 siblings, 0 replies; 17+ messages in thread
From: Stefano Stabellini @ 2012-05-21 16:11 UTC (permalink / raw)
  To: Ian Campbell
  Cc: Konrad Rzeszutek Wilk, xen-devel, Marek Marczykowski, Stefano Stabellini

On Mon, 21 May 2012, Ian Campbell wrote:
> On Mon, 2012-05-21 at 16:58 +0100, Stefano Stabellini wrote:
> > On Sun, 20 May 2012, Marek Marczykowski wrote:
> > > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> > > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> > > is the only way to get network access in dom0.
> > > 
> > > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> > > ---
> > >  drivers/net/xen-netfront.c |    3 ---
> > >  1 files changed, 0 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> > > index 698b905..e5a161a 100644
> > > --- a/drivers/net/xen-netfront.c
> > > +++ b/drivers/net/xen-netfront.c
> > > @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
> > >  	if (!xen_domain())
> > >  		return -ENODEV;
> > >  
> > > -	if (xen_initial_domain())
> > > -		return 0;
> > > -
> > >  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
> > >  
> > >  	return xenbus_register_frontend(&netfront_driver);
> > 
> > you need something similar in netif_exit too
> 
> Do we need this in other *foo*front as well? e.g. block?

nope, xen-blkfront doesn't have any xen_initial_domain checks.
The other frontends with xen_initial_domain checks are:

drivers/input/misc/xen-kbdfront.c
drivers/video/xen-fbfront.c
drivers/pci/xen-pcifront.c

While it makes sense to keep xen-pcifront dom0 only for the moment, it
might be useful to remove the xen_initial_domain checks from xen-fbfront and
xen-kbdfront.

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-21 15:58 ` Stefano Stabellini
@ 2012-05-21 16:05   ` Ian Campbell
  2012-05-21 16:11     ` Stefano Stabellini
  0 siblings, 1 reply; 17+ messages in thread
From: Ian Campbell @ 2012-05-21 16:05 UTC (permalink / raw)
  To: Stefano Stabellini; +Cc: xen-devel, Marek Marczykowski, Konrad Rzeszutek Wilk

On Mon, 2012-05-21 at 16:58 +0100, Stefano Stabellini wrote:
> On Sun, 20 May 2012, Marek Marczykowski wrote:
> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> > is the only way to get network access in dom0.
> > 
> > Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> > ---
> >  drivers/net/xen-netfront.c |    3 ---
> >  1 files changed, 0 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> > index 698b905..e5a161a 100644
> > --- a/drivers/net/xen-netfront.c
> > +++ b/drivers/net/xen-netfront.c
> > @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
> >  	if (!xen_domain())
> >  		return -ENODEV;
> >  
> > -	if (xen_initial_domain())
> > -		return 0;
> > -
> >  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
> >  
> >  	return xenbus_register_frontend(&netfront_driver);
> 
> you need something similar in netif_exit too

Do we need this in other *foo*front as well? e.g. block?

Ian.

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 Marek Marczykowski
  2012-05-21 14:18 ` Konrad Rzeszutek Wilk
@ 2012-05-21 15:58 ` Stefano Stabellini
  2012-05-21 16:05   ` Ian Campbell
  1 sibling, 1 reply; 17+ messages in thread
From: Stefano Stabellini @ 2012-05-21 15:58 UTC (permalink / raw)
  To: Marek Marczykowski; +Cc: Konrad Rzeszutek Wilk, xen-devel

On Sun, 20 May 2012, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> ---
>  drivers/net/xen-netfront.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e5a161a 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	if (xen_initial_domain())
> -		return 0;
> -
>  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>  
>  	return xenbus_register_frontend(&netfront_driver);

you need something similar in netif_exit too

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] xen: do not disable netfront in dom0
  2012-05-20 11:45 Marek Marczykowski
@ 2012-05-21 14:18 ` Konrad Rzeszutek Wilk
  2012-05-21 15:58 ` Stefano Stabellini
  1 sibling, 0 replies; 17+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-05-21 14:18 UTC (permalink / raw)
  To: Marek Marczykowski; +Cc: xen-devel

On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Pls CC the network maintainer (and its list) and LKML.

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/net/xen-netfront.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e5a161a 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	if (xen_initial_domain())
> -		return 0;
> -
>  	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>  
>  	return xenbus_register_frontend(&netfront_driver);
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [PATCH] xen: do not disable netfront in dom0
@ 2012-05-20 11:45 ` Marek Marczykowski
  0 siblings, 0 replies; 17+ messages in thread
From: Marek Marczykowski @ 2012-05-20 11:45 UTC (permalink / raw)
  To: xen-devel
  Cc: Marek Marczykowski, virtualization, Konrad Rzeszutek Wilk,
	Jeremy Fitzhardinge, netdev, linux-kernel

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
---
 drivers/net/xen-netfront.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 698b905..e31ebff 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1953,9 +1953,6 @@ static int __init netif_init(void)
 	if (!xen_domain())
 		return -ENODEV;
 
-	if (xen_initial_domain())
-		return 0;
-
 	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
 
 	return xenbus_register_frontend(&netfront_driver);
@@ -1965,9 +1962,6 @@ module_init(netif_init);
 
 static void __exit netif_exit(void)
 {
-	if (xen_initial_domain())
-		return;
-
 	xenbus_unregister_driver(&netfront_driver);
 }
 module_exit(netif_exit);
-- 
1.7.4.4


^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [PATCH] xen: do not disable netfront in dom0
@ 2012-05-20 11:45 ` Marek Marczykowski
  0 siblings, 0 replies; 17+ messages in thread
From: Marek Marczykowski @ 2012-05-20 11:45 UTC (permalink / raw)
  To: xen-devel
  Cc: Jeremy Fitzhardinge, Konrad Rzeszutek Wilk, netdev,
	Marek Marczykowski, linux-kernel, virtualization

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
---
 drivers/net/xen-netfront.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 698b905..e31ebff 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1953,9 +1953,6 @@ static int __init netif_init(void)
 	if (!xen_domain())
 		return -ENODEV;
 
-	if (xen_initial_domain())
-		return 0;
-
 	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
 
 	return xenbus_register_frontend(&netfront_driver);
@@ -1965,9 +1962,6 @@ module_init(netif_init);
 
 static void __exit netif_exit(void)
 {
-	if (xen_initial_domain())
-		return;
-
 	xenbus_unregister_driver(&netfront_driver);
 }
 module_exit(netif_exit);
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [PATCH] xen: do not disable netfront in dom0
@ 2012-05-20 11:45 Marek Marczykowski
  2012-05-21 14:18 ` Konrad Rzeszutek Wilk
  2012-05-21 15:58 ` Stefano Stabellini
  0 siblings, 2 replies; 17+ messages in thread
From: Marek Marczykowski @ 2012-05-20 11:45 UTC (permalink / raw)
  To: xen-devel; +Cc: Marek Marczykowski

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
---
 drivers/net/xen-netfront.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 698b905..e5a161a 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1953,9 +1953,6 @@ static int __init netif_init(void)
 	if (!xen_domain())
 		return -ENODEV;
 
-	if (xen_initial_domain())
-		return 0;
-
 	printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
 
 	return xenbus_register_frontend(&netfront_driver);
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2012-05-22 19:43 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-20 11:45 [PATCH] xen: do not disable netfront in dom0 Marek Marczykowski
  -- strict thread matches above, loose matches on Subject: below --
2012-05-20 11:45 Marek Marczykowski
2012-05-21 14:18 ` Konrad Rzeszutek Wilk
2012-05-21 15:58 ` Stefano Stabellini
2012-05-21 16:05   ` Ian Campbell
2012-05-21 16:11     ` Stefano Stabellini
2012-05-20 11:45 Marek Marczykowski
2012-05-20 11:45 ` Marek Marczykowski
2012-05-22 18:34 ` Konrad Rzeszutek Wilk
2012-05-22 18:34 ` Konrad Rzeszutek Wilk
2012-05-22 18:34   ` Konrad Rzeszutek Wilk
2012-05-22 19:13 ` David Miller
2012-05-22 19:13   ` David Miller
2012-05-22 19:30   ` Ian Campbell
2012-05-22 19:30   ` [Xen-devel] " Ian Campbell
2012-05-22 19:38     ` David Miller
2012-05-22 19:38     ` [Xen-devel] " David Miller
2012-05-22 19:43       ` Konrad Rzeszutek Wilk
2012-05-22 19:13 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.