* [PATCH 3/3] I don`t know for what, but there`s dublicate item.
@ 2012-05-26 19:18 Volokh Konstantin
2012-05-30 19:43 ` Ezequiel Garcia
2012-05-31 7:08 ` [PATCH] media: video: bt8xx: Remove duplicated pixel format entry volokh
0 siblings, 2 replies; 7+ messages in thread
From: Volokh Konstantin @ 2012-05-26 19:18 UTC (permalink / raw)
To: linux-media; +Cc: Volokh Konstantin
Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
---
drivers/media/video/bt8xx/bttv-driver.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index e581b37..b4ee7de 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
.depth = 16,
.flags = FORMAT_FLAGS_PACKED,
},{
- .name = "4:2:2, packed, YUYV",
- .fourcc = V4L2_PIX_FMT_YUYV,
- .btformat = BT848_COLOR_FMT_YUY2,
- .depth = 16,
- .flags = FORMAT_FLAGS_PACKED,
- },{
.name = "4:2:2, packed, UYVY",
.fourcc = V4L2_PIX_FMT_UYVY,
.btformat = BT848_COLOR_FMT_YUY2,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] I don`t know for what, but there`s dublicate item.
2012-05-26 19:18 [PATCH 3/3] I don`t know for what, but there`s dublicate item Volokh Konstantin
@ 2012-05-30 19:43 ` Ezequiel Garcia
2012-05-30 20:05 ` Ezequiel Garcia
2012-05-31 7:08 ` [PATCH] media: video: bt8xx: Remove duplicated pixel format entry volokh
1 sibling, 1 reply; 7+ messages in thread
From: Ezequiel Garcia @ 2012-05-30 19:43 UTC (permalink / raw)
To: Volokh Konstantin; +Cc: linux-media
Hi,
On Sat, May 26, 2012 at 4:18 PM, Volokh Konstantin <volokh84@gmail.com> wrote:
> Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
> ---
> drivers/media/video/bt8xx/bttv-driver.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
> index e581b37..b4ee7de 100644
> --- a/drivers/media/video/bt8xx/bttv-driver.c
> +++ b/drivers/media/video/bt8xx/bttv-driver.c
> @@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
> .depth = 16,
> .flags = FORMAT_FLAGS_PACKED,
> },{
> - .name = "4:2:2, packed, YUYV",
> - .fourcc = V4L2_PIX_FMT_YUYV,
> - .btformat = BT848_COLOR_FMT_YUY2,
> - .depth = 16,
> - .flags = FORMAT_FLAGS_PACKED,
> - },{
> .name = "4:2:2, packed, UYVY",
> .fourcc = V4L2_PIX_FMT_UYVY,
> .btformat = BT848_COLOR_FMT_YUY2,
> --
> 1.7.7.6
>
The patch looks correct to me.
But the subject is *very* wrong. You should set it to something like:
"[bt8xx] Remove duplicated pixel format entry".
Also, the subject says [PATCH 3/3], where are the other patches?
As a newbie I used to do this kind of mistakes often. Now I try to let patches
sleep for a couple of days, and then review them once again before send them.
Also send them once to yourself before sending to the list,
so you get another chance to catch mistakes.
Hope it helps,
Ezequiel.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] I don`t know for what, but there`s dublicate item.
2012-05-30 19:43 ` Ezequiel Garcia
@ 2012-05-30 20:05 ` Ezequiel Garcia
2012-05-31 6:55 ` volokh
0 siblings, 1 reply; 7+ messages in thread
From: Ezequiel Garcia @ 2012-05-30 20:05 UTC (permalink / raw)
To: Volokh Konstantin; +Cc: linux-media
On Wed, May 30, 2012 at 4:43 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> But the subject is *very* wrong. You should set it to something like:
> "[bt8xx] Remove duplicated pixel format entry".
^^^^^^^^
Sorry this should be, "[PATCH] bt8xx: Remove duplicated pixel format entry".
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] I don`t know for what, but there`s dublicate item.
2012-05-30 20:05 ` Ezequiel Garcia
@ 2012-05-31 6:55 ` volokh
0 siblings, 0 replies; 7+ messages in thread
From: volokh @ 2012-05-31 6:55 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Volokh Konstantin, linux-media
On Wed, May 30, 2012 at 05:05:47PM -0300, Ezequiel Garcia wrote:
> On Wed, May 30, 2012 at 4:43 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> > But the subject is *very* wrong. You should set it to something like:
> > "[bt8xx] Remove duplicated pixel format entry".
> ^^^^^^^^
>
> Sorry this should be, "[PATCH] bt8xx: Remove duplicated pixel format entry".
> --
Thanks for correction
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] media: video: bt8xx: Remove duplicated pixel format entry.
2012-05-26 19:18 [PATCH 3/3] I don`t know for what, but there`s dublicate item Volokh Konstantin
2012-05-30 19:43 ` Ezequiel Garcia
@ 2012-05-31 7:08 ` volokh
2012-05-31 7:29 ` volokh
1 sibling, 1 reply; 7+ messages in thread
From: volokh @ 2012-05-31 7:08 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Volokh Konstantin, linux-media
Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
---
drivers/media/video/bt8xx/bttv-driver.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/bt8xx/bttv-driver.c
+b/drivers/media/video/bt8xx/bttv-driver.c
index e581b37..b4ee7de 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
.depth = 16,
.flags = FORMAT_FLAGS_PACKED,
},{
- .name = "4:2:2, packed, YUYV",
- .fourcc = V4L2_PIX_FMT_YUYV,
- .btformat = BT848_COLOR_FMT_YUY2,
- .depth = 16,
- .flags = FORMAT_FLAGS_PACKED,
- },{
.name = "4:2:2, packed, UYVY",
.fourcc = V4L2_PIX_FMT_UYVY,
.btformat = BT848_COLOR_FMT_YUY2,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] media: video: bt8xx: Remove duplicated pixel format entry.
2012-05-31 7:08 ` [PATCH] media: video: bt8xx: Remove duplicated pixel format entry volokh
@ 2012-05-31 7:29 ` volokh
0 siblings, 0 replies; 7+ messages in thread
From: volokh @ 2012-05-31 7:29 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Volokh Konstantin, linux-media
On Thu, May 31, 2012 at 11:08:51AM +0400, volokh@telros.ru wrote:
> Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
> ---
> drivers/media/video/bt8xx/bttv-driver.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/video/bt8xx/bttv-driver.c
> +b/drivers/media/video/bt8xx/bttv-driver.c
> index e581b37..b4ee7de 100644
> --- a/drivers/media/video/bt8xx/bttv-driver.c
> +++ b/drivers/media/video/bt8xx/bttv-driver.c
> @@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
> .depth = 16,
> .flags = FORMAT_FLAGS_PACKED,
> },{
> - .name = "4:2:2, packed, YUYV",
> - .fourcc = V4L2_PIX_FMT_YUYV,
> - .btformat = BT848_COLOR_FMT_YUY2,
> - .depth = 16,
> - .flags = FORMAT_FLAGS_PACKED,
> - },{
> .name = "4:2:2, packed, UYVY",
> .fourcc = V4L2_PIX_FMT_UYVY,
> .btformat = BT848_COLOR_FMT_YUY2,
> --
> 1.7.7.6
>
>
Sorry, This patch not applicable on new branch, something was changed.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] media: video: bt8xx: Remove duplicated pixel format entry.
@ 2012-05-31 7:49 Volokh Konstantin
0 siblings, 0 replies; 7+ messages in thread
From: Volokh Konstantin @ 2012-05-31 7:49 UTC (permalink / raw)
To: elezegarcia; +Cc: volokh84, linux-media
Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
---
drivers/media/video/bt8xx/bttv-driver.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index a9cfb0f..4e2f96f 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
.depth = 16,
.flags = FORMAT_FLAGS_PACKED,
},{
- .name = "4:2:2, packed, YUYV",
- .fourcc = V4L2_PIX_FMT_YUYV,
- .btformat = BT848_COLOR_FMT_YUY2,
- .depth = 16,
- .flags = FORMAT_FLAGS_PACKED,
- },{
.name = "4:2:2, packed, UYVY",
.fourcc = V4L2_PIX_FMT_UYVY,
.btformat = BT848_COLOR_FMT_YUY2,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-05-31 7:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-26 19:18 [PATCH 3/3] I don`t know for what, but there`s dublicate item Volokh Konstantin
2012-05-30 19:43 ` Ezequiel Garcia
2012-05-30 20:05 ` Ezequiel Garcia
2012-05-31 6:55 ` volokh
2012-05-31 7:08 ` [PATCH] media: video: bt8xx: Remove duplicated pixel format entry volokh
2012-05-31 7:29 ` volokh
2012-05-31 7:49 Volokh Konstantin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.