* [merged] pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command.patch removed from -mm tree
@ 2012-06-01 19:33 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-06-01 19:33 UTC (permalink / raw)
To: will.deacon, alan, axboe, viro, mm-commits
The patch titled
Subject: pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
has been removed from the -mm tree. Its filename was
pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
From: Will Deacon <will.deacon@arm.com>
Subject: pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error
handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl
command which they don't understand. Doing so will result in -ENOTTY
being returned to userspace, which matches the behaviour of the compat
layer if it fails to translate an ioctl command.
This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of -EINVAL
when passed an unknown ioctl command.
Signed-off-by: Will Deacon <will.deacon@arm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Alan Cox <alan@linux.intel.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/pipe.c~pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command fs/pipe.c
--- a/fs/pipe.c~pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command
+++ a/fs/pipe.c
@@ -693,7 +693,7 @@ static long pipe_ioctl(struct file *filp
return put_user(count, (int __user *)arg);
default:
- return -EINVAL;
+ return -ENOIOCTLCMD;
}
}
_
Patches currently in -mm which might be from will.deacon@arm.com are
origin.patch
linux-next.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-01 19:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-01 19:33 [merged] pipe-return-enoioctlcmd-instead-of-einval-on-unknown-ioctl-command.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.