All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Shubhrajyoti Datta
	<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Detlev Zundel" <dzu-ynQEQJNshbs@public.gmane.org>,
	"Dong Aisheng" <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"Fabio Estevam"
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"Linux ARM kernel"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"Sascha Hauer" <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"Shawn Guo" <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Stefano Babic" <sbabic-ynQEQJNshbs@public.gmane.org>,
	"Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"Wolfgang Denk" <wd-ynQEQJNshbs@public.gmane.org>,
	"Wolfram Sang" <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c
Date: Sat, 9 Jun 2012 15:10:31 +0200	[thread overview]
Message-ID: <201206091510.31232.marex@denx.de> (raw)
In-Reply-To: <CAM=Q2cvvwXimLY358ET69U6qCsGoxenYMNtApYbhpn4cCC0nUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Dear Shubhrajyoti Datta,

> >> > +struct mxs_i2c_speed_config {
> >> > +       uint32_t        timing0;
> >> > +       uint32_t        timing1;
> >> > +       uint32_t        timing2;
> >> > +};
> >> > +
> >> > +const struct mxs_i2c_speed_config mxs_i2c_95kHz_config = {
> >> 
> >> You are using 95k?
> > 
> > Yes
> > 
> >> Didnt understand this.
> > 
> > What exactly, it's running (according to the datasheet) at 95kHz.
> 
> Did you intend 100k?

I intended to stick with the datasheet, if you manage to find explanation for 
why they chose 95kHz, I'd be interested to hear it ... btw. 24MHz/95kHz gives 
pretty weird divider, which is quite suspicious.

> and approximating due to clock ... or some other limitaion?

Doesn't seem to be the case, see "btw" part above.

> That is what I was trying to understand.
> 
> >> > +       .timing0        = 0x00780030,
> >> > +       .timing1        = 0x00800030,
> >> > +       .timing2        = 0x0015000d,
> >> > +};

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c
Date: Sat, 9 Jun 2012 15:10:31 +0200	[thread overview]
Message-ID: <201206091510.31232.marex@denx.de> (raw)
In-Reply-To: <CAM=Q2cvvwXimLY358ET69U6qCsGoxenYMNtApYbhpn4cCC0nUg@mail.gmail.com>

Dear Shubhrajyoti Datta,

> >> > +struct mxs_i2c_speed_config {
> >> > +       uint32_t        timing0;
> >> > +       uint32_t        timing1;
> >> > +       uint32_t        timing2;
> >> > +};
> >> > +
> >> > +const struct mxs_i2c_speed_config mxs_i2c_95kHz_config = {
> >> 
> >> You are using 95k?
> > 
> > Yes
> > 
> >> Didnt understand this.
> > 
> > What exactly, it's running (according to the datasheet) at 95kHz.
> 
> Did you intend 100k?

I intended to stick with the datasheet, if you manage to find explanation for 
why they chose 95kHz, I'd be interested to hear it ... btw. 24MHz/95kHz gives 
pretty weird divider, which is quite suspicious.

> and approximating due to clock ... or some other limitaion?

Doesn't seem to be the case, see "btw" part above.

> That is what I was trying to understand.
> 
> >> > +       .timing0        = 0x00780030,
> >> > +       .timing1        = 0x00800030,
> >> > +       .timing2        = 0x0015000d,
> >> > +};

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-06-09 13:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 18:54 [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c Marek Vasut
2012-06-08 18:54 ` Marek Vasut
     [not found] ` <1339181689-22573-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-06-08 18:54   ` [PATCH 2/2 V2] MXS: Implement DMA support into mxs-i2c Marek Vasut
2012-06-08 18:54     ` Marek Vasut
2012-06-09  4:15   ` [PATCH 1/2 V2] MXS: Set I2C timing registers for mxs-i2c Shubhrajyoti Datta
2012-06-09  4:15     ` Shubhrajyoti Datta
     [not found]     ` <CAM=Q2cuv0NQTYJH=+d6Na+JK5rGYsLiSmuX7g8T-_Ry7bs3fRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-09 10:34       ` Marek Vasut
2012-06-09 10:34         ` Marek Vasut
     [not found]         ` <201206091234.47309.marex-ynQEQJNshbs@public.gmane.org>
2012-06-09 10:53           ` Sascha Hauer
2012-06-09 10:53             ` Sascha Hauer
     [not found]             ` <20120609105330.GF30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-09 11:11               ` Marek Vasut
2012-06-09 11:11                 ` Marek Vasut
     [not found]                 ` <201206091311.43229.marex-ynQEQJNshbs@public.gmane.org>
2012-06-09 11:25                   ` Sascha Hauer
2012-06-09 11:25                     ` Sascha Hauer
     [not found]                     ` <20120609112545.GH30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-09 11:40                       ` Marek Vasut
2012-06-09 11:40                         ` Marek Vasut
2012-06-09 12:46           ` Shubhrajyoti Datta
2012-06-09 12:46             ` Shubhrajyoti Datta
     [not found]             ` <CAM=Q2cvvwXimLY358ET69U6qCsGoxenYMNtApYbhpn4cCC0nUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-09 13:10               ` Marek Vasut [this message]
2012-06-09 13:10                 ` Marek Vasut
2012-07-06  6:09 Marek Vasut
2012-07-06  6:09 ` Marek Vasut
     [not found] ` <1341554956-17416-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-07-09 10:53   ` Wolfram Sang
2012-07-09 10:53     ` Wolfram Sang
     [not found]     ` <20120709105338.GE1296-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-09 11:07       ` Marek Vasut
2012-07-09 11:07         ` Marek Vasut
     [not found]         ` <201207091307.35860.marex-ynQEQJNshbs@public.gmane.org>
2012-07-09 12:05           ` Wolfram Sang
2012-07-09 12:05             ` Wolfram Sang
     [not found]             ` <20120709120523.GG1296-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-09 15:58               ` Marek Vasut
2012-07-09 15:58                 ` Marek Vasut
     [not found]                 ` <201207091758.22788.marex-ynQEQJNshbs@public.gmane.org>
2012-07-10 14:09                   ` Robert Schwebel
2012-07-10 14:09                     ` Robert Schwebel
     [not found]                     ` <20120710140911.GK20456-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-10 15:13                       ` Marek Vasut
2012-07-10 15:13                         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206091510.31232.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=dzu-ynQEQJNshbs@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=sbabic-ynQEQJNshbs@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=wd-ynQEQJNshbs@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.