All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 2/4] 6lowpan: Incorrect type in lowpan_alloc_new_frame() definition : tag is u8 but should be u16
@ 2012-06-11  4:39 Tony Cheneau
  0 siblings, 0 replies; only message in thread
From: Tony Cheneau @ 2012-06-11  4:39 UTC (permalink / raw)
  To: netdev, linux-zigbee-devel; +Cc: alex.bluesman.smirnov

lowpan_alloc_new_frame() takes u8 tag as an argument. Howerer,
its only caller, lowpan_process_data() passes down a u16. Hence,
the tag value got corrupted.
This prevent 6lowpan fragment reassembly after 256 fragmented packets
have been reassembled by the same recipient.
---
 net/ieee802154/6lowpan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index a52e795..af4f29b 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -654,7 +654,7 @@ static void lowpan_fragment_timer_expired(unsigned
long entry_addr) }
 
 static struct lowpan_fragment *
-lowpan_alloc_new_frame(struct sk_buff *skb, u8 iphc0, u8 len, u8 tag)
+lowpan_alloc_new_frame(struct sk_buff *skb, u8 iphc0, u8 len, u16 tag)
 {
 	struct lowpan_fragment *frame;
 
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-06-11  4:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-11  4:39 [PATCH net-next 2/4] 6lowpan: Incorrect type in lowpan_alloc_new_frame() definition : tag is u8 but should be u16 Tony Cheneau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.