All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Aaron Lu <aaron.lu@amd.com>, Holger Macht <holger@homac.de>,
	Matthew Garrett <mjg@redhat.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree
Date: Wed, 13 Jun 2012 12:00:50 +0100	[thread overview]
Message-ID: <20120613120050.164c3f29@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAF1ivSYBjw+UP3vP8RHaftjR8NJZEaHA1rtJ5ujDjkj-djHLTQ@mail.gmail.com>

On Wed, 13 Jun 2012 16:03:23 +0800
Lin Ming <ming.m.lin@intel.com> wrote:

> On Mon, May 28, 2012 at 5:51 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >> +static int is_pci_ata(struct device *dev)
> >> +{
> >> +     struct pci_dev *pdev;
> >> +
> >> +     if (!is_pci_dev(dev))
> >> +             return 0;
> >> +
> >> +     pdev = to_pci_dev(dev);
> >> +
> >> +     if ((pdev->class >> 8) != PCI_CLASS_STORAGE_SATA &&
> >> +         (pdev->class >> 8) != PCI_CLASS_STORAGE_IDE)
> >> +             return 0;
> >
> > This needs a better name. It doesn't check if a device is PCI ATA or
> > anything of the sort, it checks if its probably a device in compatibility
> > mode. A lot of controllers will in fact report RAID class or similar in
> > native mode.
> 
> How about compat_pci_ata?

Sounds reasonable. I'm not btw sure the test is entirely right, but I'm
not sure quite what you are trying to figure out from it and how ACPI
expects this mapping to work.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Aaron Lu <aaron.lu@amd.com>, Holger Macht <holger@homac.de>,
	Matthew Garrett <mjg@redhat.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree
Date: Wed, 13 Jun 2012 12:00:50 +0100	[thread overview]
Message-ID: <20120613120050.164c3f29@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAF1ivSYBjw+UP3vP8RHaftjR8NJZEaHA1rtJ5ujDjkj-djHLTQ@mail.gmail.com>

On Wed, 13 Jun 2012 16:03:23 +0800
Lin Ming <ming.m.lin@intel.com> wrote:

> On Mon, May 28, 2012 at 5:51 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >> +static int is_pci_ata(struct device *dev)
> >> +{
> >> +     struct pci_dev *pdev;
> >> +
> >> +     if (!is_pci_dev(dev))
> >> +             return 0;
> >> +
> >> +     pdev = to_pci_dev(dev);
> >> +
> >> +     if ((pdev->class >> 8) != PCI_CLASS_STORAGE_SATA &&
> >> +         (pdev->class >> 8) != PCI_CLASS_STORAGE_IDE)
> >> +             return 0;
> >
> > This needs a better name. It doesn't check if a device is PCI ATA or
> > anything of the sort, it checks if its probably a device in compatibility
> > mode. A lot of controllers will in fact report RAID class or similar in
> > native mode.
> 
> How about compat_pci_ata?

Sounds reasonable. I'm not btw sure the test is entirely right, but I'm
not sure quite what you are trying to figure out from it and how ACPI
expects this mapping to work.

Alan

  reply	other threads:[~2012-06-13 11:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28  5:08 [PATCH v4 0/13] SATA ZPODD support Lin Ming
2012-05-28  5:08 ` [PATCH v4 01/13] [SCSI]: add wrapper to access and set scsi_bus_type in struct acpi_bus_type Lin Ming
2012-05-29 12:26   ` Sergei Shtylyov
2012-05-28  5:08 ` [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree Lin Ming
2012-05-28  9:51   ` Alan Cox
2012-06-13  8:03     ` Lin Ming
2012-06-13 11:00       ` Alan Cox [this message]
2012-06-13 11:00         ` Alan Cox
2012-06-14  7:43         ` Lin Ming
2012-05-28  5:08 ` [PATCH v4 03/13] libata: migrate ACPI code over to new bindings Lin Ming
2012-05-28  5:08 ` [PATCH v4 04/13] libata: use correct PCI devices Lin Ming
2012-05-29 12:22   ` Sergei Shtylyov
2012-05-28  5:08 ` [PATCH v4 05/13] libata-acpi: set acpi state for SATA port Lin Ming
2012-05-28  5:08 ` [PATCH v4 06/13] libata-acpi: add ata port runtime D3Cold support Lin Ming
2012-05-28  5:08 ` [PATCH v4 07/13] libata-acpi: register/unregister device to/from power resource Lin Ming
2012-05-28  5:08 ` [PATCH v4 08/13] libata: detect Device Attention support Lin Ming
2012-05-28  5:08 ` [PATCH v4 09/13] libata: tell scsi layer device supports runtime power off Lin Ming
2012-05-28  5:08 ` [PATCH v4 10/13] [SCSI] pm: resume device if suspend failed Lin Ming
2012-05-28  5:08 ` [PATCH v4 11/13] [SCSI] sr: check support for device busy class events Lin Ming
2012-05-28  5:08 ` [PATCH v4 12/13] [SCSI] sr: support zero power ODD Lin Ming
2012-05-28  5:08 ` [PATCH v4 13/13] [SCSI] sr: make sure ODD is in resumed state in block ioctl Lin Ming
2012-05-28  9:44 ` [PATCH v4 0/13] SATA ZPODD support Alan Cox
2012-05-28  9:54   ` Alan Cox
2012-05-29 12:32     ` Lin Ming
2012-05-30  5:43       ` Aaron Lu
2012-05-30  5:43         ` Aaron Lu
2012-05-30  9:06         ` Fuzhou Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613120050.164c3f29@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=David.Woodhouse@intel.com \
    --cc=aaron.lu@amd.com \
    --cc=holger@homac.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.