* [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null
@ 2012-06-13 8:27 Sangbeom Kim
2012-06-13 17:44 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Sangbeom Kim @ 2012-06-13 8:27 UTC (permalink / raw)
To: 'Mark Brown', 'Liam Girdwood'; +Cc: linux-kernel, sbkim01
If ramp_delay is 0, delay value can be divided by zero.
This patch can fix the problem.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
drivers/regulator/s5m8767.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 4edf344..ce9dda2 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -451,7 +451,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
desc = reg_voltage_map[reg_id];
- if (old_sel < new_sel)
+ if ((old_sel < new_sel) && s5m8767->ramp_delay)
return DIV_ROUND_UP(desc->step * (new_sel - old_sel),
s5m8767->ramp_delay * 1000);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null
2012-06-13 8:27 [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null Sangbeom Kim
@ 2012-06-13 17:44 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-06-13 17:44 UTC (permalink / raw)
To: Sangbeom Kim; +Cc: 'Liam Girdwood', linux-kernel, sbkim01
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
On Wed, Jun 13, 2012 at 05:27:16PM +0900, Sangbeom Kim wrote:
> If ramp_delay is 0, delay value can be divided by zero.
> This patch can fix the problem.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-13 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-13 8:27 [PATCH 2/5] regulator: Fix the s5m8767a problem of the division by null Sangbeom Kim
2012-06-13 17:44 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.