All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon: (coretemp) Drop needless initialization
@ 2012-06-15 12:43 Jean Delvare
  2012-06-15 13:51 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2012-06-15 12:43 UTC (permalink / raw)
  To: lm-sensors

The value is overridden a few lines later.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 drivers/hwmon/coretemp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-3.5-rc2.orig/drivers/hwmon/coretemp.c	2012-06-15 14:26:40.000000000 +0200
+++ linux-3.5-rc2/drivers/hwmon/coretemp.c	2012-06-15 14:39:06.690271631 +0200
@@ -801,7 +801,7 @@ MODULE_DEVICE_TABLE(x86cpu, coretemp_ids
 
 static int __init coretemp_init(void)
 {
-	int i, err = -ENODEV;
+	int i, err;
 
 	/*
 	 * CPUID.06H.EAX[0] indicates whether the CPU has thermal


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: (coretemp) Drop needless initialization
  2012-06-15 12:43 [lm-sensors] [PATCH] hwmon: (coretemp) Drop needless initialization Jean Delvare
@ 2012-06-15 13:51 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2012-06-15 13:51 UTC (permalink / raw)
  To: lm-sensors

On Fri, Jun 15, 2012 at 08:43:53AM -0400, Jean Delvare wrote:
> The value is overridden a few lines later.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>

Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>

> ---
>  drivers/hwmon/coretemp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-3.5-rc2.orig/drivers/hwmon/coretemp.c	2012-06-15 14:26:40.000000000 +0200
> +++ linux-3.5-rc2/drivers/hwmon/coretemp.c	2012-06-15 14:39:06.690271631 +0200
> @@ -801,7 +801,7 @@ MODULE_DEVICE_TABLE(x86cpu, coretemp_ids
>  
>  static int __init coretemp_init(void)
>  {
> -	int i, err = -ENODEV;
> +	int i, err;
>  
>  	/*
>  	 * CPUID.06H.EAX[0] indicates whether the CPU has thermal
> 
> 
> -- 
> Jean Delvare
> 
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-15 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-15 12:43 [lm-sensors] [PATCH] hwmon: (coretemp) Drop needless initialization Jean Delvare
2012-06-15 13:51 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.