From: Apelete Seketeli <apelete@seketeli.net>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@openembedded.org,
Kristoffer Ericson <kristoffer.ericson@gmail.com>
Subject: Re: [PATCH 1/1] gtk+: Regenerate no-demos.patch and update recipe
Date: Tue, 19 Jun 2012 08:07:03 +0200 [thread overview]
Message-ID: <20120619060703.GA4845@hermes> (raw)
In-Reply-To: <20120619052932.GN3178@jama.jama.net>
Le 19-Jun-12, Martin Jansa a écrit:
> On Tue, Jun 19, 2012 at 01:42:10AM +0200, Apelete Seketeli wrote:
> > This fix regenerates the gtk+-2.20.1/no-demos.patch file because the
> > targeted Makefile.am file changed since gtk+-2.10.1.
> > The gtk+_2.20.1.bb recipe is also updated to fix an issue where
> > no-demos.patch was not taken into account during the do_patch() stage.
> >
> > Signed-off-by: Apelete Seketeli <apelete@seketeli.net>
> > ---
> > recipes/gtk+/gtk+-2.20.1/no-demos.patch | 7 ++++---
> > recipes/gtk+/gtk+_2.20.1.bb | 3 +--
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/recipes/gtk+/gtk+-2.20.1/no-demos.patch b/recipes/gtk+/gtk+-2.20.1/no-demos.patch
> > index 0fc4c48..ac0730d 100644
> > --- a/recipes/gtk+/gtk+-2.20.1/no-demos.patch
> > +++ b/recipes/gtk+/gtk+-2.20.1/no-demos.patch
> > @@ -1,7 +1,8 @@
> > ---- gtk+-2.10.1/Makefile.am.orig 2006-08-08 12:37:30.000000000 +0100
> > -+++ gtk+-2.10.1/Makefile.am 2006-08-08 12:37:48.000000000 +0100
> > -@@ -1,6 +1,6 @@
> > +--- gtk+-2.20.1/Makefile.am.orig 2012-06-18 22:40:19.348040648 +0200
> > ++++ gtk+-2.20.1/Makefile.am 2012-06-18 22:40:41.272149318 +0200
> > +@@ -1,7 +1,7 @@
> > ## Makefile.am for GTK+
> > + include $(top_srcdir)/Makefile.decl
> >
> > -SRC_SUBDIRS = gdk-pixbuf gdk gtk modules demos tests perf contrib
> > +SRC_SUBDIRS = gdk-pixbuf gdk gtk modules tests perf contrib
> > diff --git a/recipes/gtk+/gtk+_2.20.1.bb b/recipes/gtk+/gtk+_2.20.1.bb
> > index 9cffee1..6e3c291 100644
> > --- a/recipes/gtk+/gtk+_2.20.1.bb
> > +++ b/recipes/gtk+/gtk+_2.20.1.bb
> > @@ -1,10 +1,9 @@
> > require gtk+.inc
> >
> > -SRC_URI_append_virtclass-native = " file://no-demos.patch \
> > -"
> > SRC_URI_append = "file://gtk-dnd-grab-deadlock-fix.patch \
> > file://cross-nm.patch \
> > file://xkb-ifdef.patch \
> > + file://no-demos.patch \
>
> I guess this was because demos were working for target case and were
> intentionally disabled only for native..
In my oe setup I did not build gtk+-native. I added gtk+-native to the
ASSUME_PROVIDED list in local.conf instead, and installed
libgtk2.0-dev on my host machine.
As a consequence, I faced this gtk+ issue while baking a target
package, not a native one.
Do you mean I shouldn't have fixed the issue the way I did ? What
would be the best course of action then ?
Regards.
--
Apelete
next prev parent reply other threads:[~2012-06-19 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 23:42 [PATCH 0/1] gtk+: Regenerate no-demos.patch and update recipe Apelete Seketeli
2012-06-18 23:42 ` [PATCH 1/1] " Apelete Seketeli
2012-06-19 5:29 ` Martin Jansa
2012-06-19 6:07 ` Apelete Seketeli [this message]
2012-06-19 6:34 ` Martin Jansa
2012-06-19 19:56 ` Apelete Seketeli
2012-06-19 21:49 ` [oe-classic][gtk+][PATCH v2 0/2] gtk+: fix build issue by not building demo programs Apelete Seketeli
2012-06-19 21:52 ` [oe-classic][gtk+][PATCH v2 1/2] gtk+: Rebase gtk+-2.20.1/no-demos.patch Apelete Seketeli
2012-06-19 21:55 ` [oe-classic][gtk+][PATCH v2 2/2] gtk+: Add no-test-inline-pixbufs.patch to gtk+-2.20.1 Apelete Seketeli
2012-06-27 16:30 ` Apelete Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619060703.GA4845@hermes \
--to=apelete@seketeli.net \
--cc=kristoffer.ericson@gmail.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.