From: Konrad Rzeszutek Wilk <konrad@darnok.org> To: Rafael Aquini <aquini@redhat.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell <rusty@rustcorp.com.au>, "Michael S. Tsirkin" <mst@redhat.com>, Rik van Riel <riel@redhat.com> Subject: Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages Date: Tue, 26 Jun 2012 19:57:55 -0400 [thread overview] Message-ID: <20120626235754.GB14782@localhost.localdomain> (raw) In-Reply-To: <7f83427b3894af7969c67acc0f27ab5aa68b4279.1340665087.git.aquini@redhat.com> > +#if defined(CONFIG_VIRTIO_BALLOON) || defined(CONFIG_VIRTIO_BALLOON_MODULE) > +/* > + * Balloon pages special page->mapping. > + * users must properly allocate and initiliaze an instance of balloon_mapping, initialize > + * and set it as the page->mapping for balloon enlisted page instances. > + * > + * address_space_operations necessary methods for ballooned pages: > + * .migratepage - used to perform balloon's page migration (as is) > + * .invalidatepage - used to isolate a page from balloon's page list > + * .freepage - used to reinsert an isolated page to balloon's page list > + */ > +struct address_space *balloon_mapping; > +EXPORT_SYMBOL(balloon_mapping); Why don't you call this kvm_balloon_mapping - and when other balloon drivers use it, then change it to something more generic. Also at that future point the other balloon drivers might do it a bit differently so it might be that will be reworked completly.
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad@darnok.org> To: Rafael Aquini <aquini@redhat.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Rusty Russell <rusty@rustcorp.com.au>, "Michael S. Tsirkin" <mst@redhat.com>, Rik van Riel <riel@redhat.com> Subject: Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages Date: Tue, 26 Jun 2012 19:57:55 -0400 [thread overview] Message-ID: <20120626235754.GB14782@localhost.localdomain> (raw) In-Reply-To: <7f83427b3894af7969c67acc0f27ab5aa68b4279.1340665087.git.aquini@redhat.com> > +#if defined(CONFIG_VIRTIO_BALLOON) || defined(CONFIG_VIRTIO_BALLOON_MODULE) > +/* > + * Balloon pages special page->mapping. > + * users must properly allocate and initiliaze an instance of balloon_mapping, initialize > + * and set it as the page->mapping for balloon enlisted page instances. > + * > + * address_space_operations necessary methods for ballooned pages: > + * .migratepage - used to perform balloon's page migration (as is) > + * .invalidatepage - used to isolate a page from balloon's page list > + * .freepage - used to reinsert an isolated page to balloon's page list > + */ > +struct address_space *balloon_mapping; > +EXPORT_SYMBOL(balloon_mapping); Why don't you call this kvm_balloon_mapping - and when other balloon drivers use it, then change it to something more generic. Also at that future point the other balloon drivers might do it a bit differently so it might be that will be reworked completly. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-26 23:58 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-25 23:25 [PATCH 0/4] make balloon pages movable by compaction Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:31 ` Konrad Rzeszutek Wilk 2012-06-25 23:31 ` Konrad Rzeszutek Wilk 2012-06-25 23:31 ` Konrad Rzeszutek Wilk 2012-06-25 23:57 ` Rafael Aquini 2012-06-25 23:57 ` Rafael Aquini 2012-06-25 23:57 ` Rafael Aquini 2012-06-26 10:17 ` Mel Gorman 2012-06-26 10:17 ` Mel Gorman 2012-06-26 16:52 ` Andi Kleen 2012-06-26 16:52 ` Andi Kleen 2012-06-26 16:54 ` Andi Kleen 2012-06-26 16:54 ` Andi Kleen 2012-06-26 16:54 ` Andi Kleen 2012-06-26 20:15 ` Mel Gorman 2012-06-26 20:15 ` Mel Gorman 2012-06-26 20:34 ` Andi Kleen 2012-06-26 20:34 ` Andi Kleen 2012-06-26 20:34 ` Andi Kleen 2012-06-27 9:42 ` Mel Gorman 2012-06-27 9:42 ` Mel Gorman 2012-06-27 9:42 ` Mel Gorman 2012-06-26 20:15 ` Mel Gorman 2012-06-26 16:52 ` Andi Kleen 2012-06-26 22:01 ` Rafael Aquini 2012-06-26 22:01 ` Rafael Aquini 2012-06-26 22:01 ` Rafael Aquini 2012-06-26 10:17 ` Mel Gorman 2012-06-26 13:17 ` Rik van Riel 2012-06-26 13:17 ` Rik van Riel 2012-06-26 13:17 ` Rik van Riel 2012-06-26 13:20 ` Mel Gorman 2012-06-26 13:20 ` Mel Gorman 2012-06-26 13:20 ` Mel Gorman 2012-06-26 23:57 ` Konrad Rzeszutek Wilk [this message] 2012-06-26 23:57 ` Konrad Rzeszutek Wilk 2012-06-27 15:17 ` Rafael Aquini 2012-06-27 15:17 ` Rafael Aquini 2012-06-27 15:30 ` Konrad Rzeszutek Wilk 2012-06-27 15:30 ` Konrad Rzeszutek Wilk 2012-06-27 15:30 ` Konrad Rzeszutek Wilk 2012-06-27 15:17 ` Rafael Aquini 2012-06-26 23:57 ` Konrad Rzeszutek Wilk 2012-06-25 23:25 ` [PATCH 2/4] virtio_balloon: handle concurrent accesses to virtio_balloon struct elements Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` [PATCH 3/4] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` [PATCH 4/4] mm: add vm event counters for balloon pages compaction Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini 2012-06-25 23:25 ` Rafael Aquini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120626235754.GB14782@localhost.localdomain \ --to=konrad@darnok.org \ --cc=aquini@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mst@redhat.com \ --cc=riel@redhat.com \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.