All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Frank Swiderski <fes@google.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	riel@redhat.com, Andrea Arcangeli <aarcange@redhat.com>,
	mikew@google.com, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] Add a page cache-backed balloon device driver.
Date: Wed, 27 Jun 2012 15:10:46 +0530	[thread overview]
Message-ID: <20120627094046.GE19023@amit.redhat.com> (raw)
In-Reply-To: <1340742778-11282-1-git-send-email-fes@google.com>

On (Tue) 26 Jun 2012 [13:32:58], Frank Swiderski wrote:
> This implementation of a virtio balloon driver uses the page cache to
> "store" pages that have been released to the host.  The communication
> (outside of target counts) is one way--the guest notifies the host when
> it adds a page to the page cache, allowing the host to madvise(2) with
> MADV_DONTNEED.  Reclaim in the guest is therefore automatic and implicit
> (via the regular page reclaim).  This means that inflating the balloon
> is similar to the existing balloon mechanism, but the deflate is
> different--it re-uses existing Linux kernel functionality to
> automatically reclaim.

This is a good idea for a guest co-operative balloon driver.  I don't
think it'll replace the original driver.  The traditional balloon
model is essentially driven by the host to increase guest density on
the host.  This driver can't work in that case.  However, using both
the types of drivers will be helpful, as unused pages on the guest
will be able to be used by the host.

Balbir Singh had done some work earlier on a guest co-operative
balloon driver, but AFAIR it was with modification of the existing
virtio-balloon driver.

I don't think a separate driver is necessary for the functionality,
though.  Perhaps just a new config space item which mentions how many
pages are present in the page cache, so that host do some accounting
as well.

		Amit

WARNING: multiple messages have this Message-ID (diff)
From: Amit Shah <amit.shah@redhat.com>
To: Frank Swiderski <fes@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	riel@redhat.com, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org, mikew@google.com,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] Add a page cache-backed balloon device driver.
Date: Wed, 27 Jun 2012 15:10:46 +0530	[thread overview]
Message-ID: <20120627094046.GE19023@amit.redhat.com> (raw)
In-Reply-To: <1340742778-11282-1-git-send-email-fes@google.com>

On (Tue) 26 Jun 2012 [13:32:58], Frank Swiderski wrote:
> This implementation of a virtio balloon driver uses the page cache to
> "store" pages that have been released to the host.  The communication
> (outside of target counts) is one way--the guest notifies the host when
> it adds a page to the page cache, allowing the host to madvise(2) with
> MADV_DONTNEED.  Reclaim in the guest is therefore automatic and implicit
> (via the regular page reclaim).  This means that inflating the balloon
> is similar to the existing balloon mechanism, but the deflate is
> different--it re-uses existing Linux kernel functionality to
> automatically reclaim.

This is a good idea for a guest co-operative balloon driver.  I don't
think it'll replace the original driver.  The traditional balloon
model is essentially driven by the host to increase guest density on
the host.  This driver can't work in that case.  However, using both
the types of drivers will be helpful, as unused pages on the guest
will be able to be used by the host.

Balbir Singh had done some work earlier on a guest co-operative
balloon driver, but AFAIR it was with modification of the existing
virtio-balloon driver.

I don't think a separate driver is necessary for the functionality,
though.  Perhaps just a new config space item which mentions how many
pages are present in the page cache, so that host do some accounting
as well.

		Amit

  parent reply	other threads:[~2012-06-27  9:40 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 20:32 [PATCH] Add a page cache-backed balloon device driver Frank Swiderski
2012-06-26 20:40 ` Rik van Riel
2012-06-26 20:40   ` Rik van Riel
2012-06-26 21:31   ` Frank Swiderski
2012-06-26 21:31     ` Frank Swiderski
2012-06-26 21:45     ` Rik van Riel
2012-06-26 21:45       ` Rik van Riel
2012-06-26 23:45       ` Frank Swiderski
2012-06-27  9:04         ` Michael S. Tsirkin
2012-06-27  9:04           ` Michael S. Tsirkin
2012-06-26 21:47     ` Michael S. Tsirkin
2012-06-26 21:47       ` Michael S. Tsirkin
2012-06-26 23:21       ` Frank Swiderski
2012-06-26 23:21         ` Frank Swiderski
2012-06-27  9:02         ` Michael S. Tsirkin
2012-06-27  9:02           ` Michael S. Tsirkin
2012-07-02  0:29         ` Rusty Russell
2012-07-02  0:29           ` Rusty Russell
2012-09-03  6:35           ` Paolo Bonzini
2012-09-03  6:35             ` Paolo Bonzini
2012-09-06  1:35             ` Rusty Russell
2012-09-06  1:35               ` Rusty Russell
2012-06-26 21:41 ` Michael S. Tsirkin
2012-06-26 21:41   ` Michael S. Tsirkin
2012-06-27  2:56   ` Rusty Russell
2012-06-27  2:56     ` Rusty Russell
2012-06-27 15:48     ` Frank Swiderski
2012-06-27 15:48       ` Frank Swiderski
2012-06-27 16:06       ` Michael S. Tsirkin
2012-06-27 16:06         ` Michael S. Tsirkin
2012-06-27 16:08         ` Frank Swiderski
2012-06-27 16:08           ` Frank Swiderski
2012-06-27  9:40 ` Amit Shah [this message]
2012-06-27  9:40   ` Amit Shah
2012-08-30  8:57 ` Michael S. Tsirkin
2012-08-30  8:57   ` Michael S. Tsirkin
2012-09-03 15:09 ` Avi Kivity
2012-09-03 15:09   ` Avi Kivity
2012-09-10  9:05 ` Michael S. Tsirkin
2012-09-10  9:05   ` Michael S. Tsirkin
2012-09-10 17:37   ` Mike Waychison
2012-09-10 17:37     ` Mike Waychison
2012-09-10 18:04     ` Rik van Riel
2012-09-10 18:04       ` Rik van Riel
2012-09-10 18:29       ` Mike Waychison
2012-09-10 18:29         ` Mike Waychison
2012-09-10 19:59     ` Michael S. Tsirkin
2012-09-10 19:59       ` Michael S. Tsirkin
2012-09-10 19:59       ` Michael S. Tsirkin
2012-09-10 20:49       ` Mike Waychison
2012-09-10 20:49         ` Mike Waychison
2012-09-10 21:10         ` Michael S. Tsirkin
2012-09-10 21:10           ` Michael S. Tsirkin
2012-10-30 15:29           ` Michael S. Tsirkin
2012-10-30 15:29             ` Michael S. Tsirkin
2012-10-30 16:25             ` Mike Waychison
2012-10-30 16:25               ` Mike Waychison
2012-09-12  5:25         ` Rusty Russell
2012-09-12  5:25           ` Rusty Russell
2012-06-26 20:32 Frank Swiderski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627094046.GE19023@amit.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=fes@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mst@redhat.com \
    --cc=riel@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.