All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dave Airlie <airlied@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i2c/ch7006: Convert to dev_pm_ops
Date: Wed, 27 Jun 2012 12:10:22 +0100	[thread overview]
Message-ID: <20120627111022.GB308@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAPM=9txnD5zoFrUya3dn4x6RnSsP4xyg+YLJvXr42K8T5EkY6w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On Wed, Jun 27, 2012 at 10:21:46AM +0100, Dave Airlie wrote:

> Thanks for this and I like the fact its been posted 5 times but never
> compiled once.

It's hard to remember since it was so long ago that I wrote the patch
but I rather suspect the reason this didn't happen is that it's actually
fairly hard to enable for test builds as the relevant Kconfig is buried
in a different directory (it's done as part of the Nouveau driver) with
no immediate relationship with the code.  That said...

> Can you at least test compile it?

...it could also be that the build error I get when I enable CONFIG_DRM
with -next is a long standing one:

In file included from include/drm/drmP.h:75,
                 from drivers/gpu/drm/drm_auth.c:36:
include/drm/drm.h:47: fatal error: sys/ioccom.h: No such file or directory
compilation terminated.
make[3]: *** [drivers/gpu/drm/drm_auth.o] Error 1

The error here seems to be that you're relying on __linux__ to decide if
you're building the kernel but that's not something you can rely on, we
can build the kernel with a freestanding compiler and the compiler will
only define this if it targets a Linux userspace.  I happen to do pretty
much all of my kernel builds with a freestanding compiler.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-06-27 11:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12  1:45 [PATCH] drm/i2c/ch7006: Convert to dev_pm_ops Mark Brown
2012-06-27  9:21 ` Dave Airlie
2012-06-27 11:10   ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-07 11:14 Mark Brown
2012-06-27 11:04 Mark Brown
2012-06-05 15:17 Mark Brown
2012-05-03 10:58 Mark Brown
2012-04-02 22:41 Mark Brown
2012-03-22 20:14 Mark Brown
2012-03-23  1:20 ` Francisco Jerez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627111022.GB308@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.