All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i2c/ch7006: Convert to dev_pm_ops
Date: Wed, 27 Jun 2012 10:21:46 +0100	[thread overview]
Message-ID: <CAPM=9txnD5zoFrUya3dn4x6RnSsP4xyg+YLJvXr42K8T5EkY6w@mail.gmail.com> (raw)
In-Reply-To: <1339465514-10766-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Tue, Jun 12, 2012 at 2:45 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> The I2C specific suspend and resume functions have been deprecated and
> printing a warning on boot for over a year, dev_pm_ops should be used
> instead so convert to that.
>
> Also remove the suspend function since all it does is log.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Acked-by: Francisco Jerez <currojerez@riseup.net>

Thanks for this and I like the fact its been posted 5 times but never
compiled once.

Can you at least test compile it?

comment below:

>
> -}
> +       struct i2c_client *client = to_i2c_device(dev);

This isn't a function ^^

Dave.

  reply	other threads:[~2012-06-27  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12  1:45 [PATCH] drm/i2c/ch7006: Convert to dev_pm_ops Mark Brown
2012-06-27  9:21 ` Dave Airlie [this message]
2012-06-27 11:10   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-08-07 11:14 Mark Brown
2012-06-27 11:04 Mark Brown
2012-06-05 15:17 Mark Brown
2012-05-03 10:58 Mark Brown
2012-04-02 22:41 Mark Brown
2012-03-22 20:14 Mark Brown
2012-03-23  1:20 ` Francisco Jerez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM=9txnD5zoFrUya3dn4x6RnSsP4xyg+YLJvXr42K8T5EkY6w@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.