* [PATCH] crypto: algapi - Fix hang on crypto allocation
@ 2012-06-27 11:31 Steffen Klassert
2012-06-27 12:58 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Klassert @ 2012-06-27 11:31 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto
git commit 398710379 (crypto: algapi - Move larval completion
into algboss) replaced accidentally a call to complete_all() by
a call to complete(). This causes a hang on crypto allocation
if we have more than one larval waiter. This pach restores the
call to complete_all().
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
crypto/algboss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/crypto/algboss.c b/crypto/algboss.c
index f97027e..769219b 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -87,7 +87,7 @@ static int cryptomgr_probe(void *data)
crypto_tmpl_put(tmpl);
out:
- complete(param->completion);
+ complete_all(param->completion);
kfree(param);
module_put_and_exit(0);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: algapi - Fix hang on crypto allocation
2012-06-27 11:31 [PATCH] crypto: algapi - Fix hang on crypto allocation Steffen Klassert
@ 2012-06-27 12:58 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2012-06-27 12:58 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto
On Wed, Jun 27, 2012 at 01:31:01PM +0200, Steffen Klassert wrote:
> git commit 398710379 (crypto: algapi - Move larval completion
> into algboss) replaced accidentally a call to complete_all() by
> a call to complete(). This causes a hang on crypto allocation
> if we have more than one larval waiter. This pach restores the
> call to complete_all().
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Good catch! Patch applied.
Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-27 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-27 11:31 [PATCH] crypto: algapi - Fix hang on crypto allocation Steffen Klassert
2012-06-27 12:58 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.