All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tj@kernel.org" <tj@kernel.org>
To: shyju pv <shyju.pv@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	Sanil kumar <sanil.kumar@huawei.com>,
	Masanari Iida <standby24x7@gmail.com>,
	Li Zefan <lizefan@huawei.com>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]
Date: Wed, 27 Jun 2012 16:02:30 -0700	[thread overview]
Message-ID: <20120627230230.GT15811@google.com> (raw)
In-Reply-To: <20120627182903.GP15811@google.com>

Hello,

Does the following patch make the problem go away?

Thank you.

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 2097684..f9556cf 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3644,6 +3644,7 @@ static void cgroup_event_remove(struct work_struct *work)
 	eventfd_ctx_put(event->eventfd);
 	kfree(event);
 	dput(cgrp->dentry);
+	deactivate_super(cgrp->root->sb);
 }
 
 /*
@@ -3770,6 +3771,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
 	 * destroying subsystem state objects. Let's take reference to cgroup
 	 * directory dentry to do that.
 	 */
+	atomic_inc(&cgrp->root->sb->s_active);
 	dget(cgrp->dentry);
 
 	spin_lock(&cgrp->event_list_lock);

WARNING: multiple messages have this Message-ID (diff)
From: "tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: shyju pv <shyju.pv-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Sanil kumar <sanil.kumar-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Masanari Iida
	<standby24x7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]
Date: Wed, 27 Jun 2012 16:02:30 -0700	[thread overview]
Message-ID: <20120627230230.GT15811@google.com> (raw)
In-Reply-To: <20120627182903.GP15811-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

Hello,

Does the following patch make the problem go away?

Thank you.

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 2097684..f9556cf 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3644,6 +3644,7 @@ static void cgroup_event_remove(struct work_struct *work)
 	eventfd_ctx_put(event->eventfd);
 	kfree(event);
 	dput(cgrp->dentry);
+	deactivate_super(cgrp->root->sb);
 }
 
 /*
@@ -3770,6 +3771,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
 	 * destroying subsystem state objects. Let's take reference to cgroup
 	 * directory dentry to do that.
 	 */
+	atomic_inc(&cgrp->root->sb->s_active);
 	dget(cgrp->dentry);
 
 	spin_lock(&cgrp->event_list_lock);

  reply	other threads:[~2012-06-27 23:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 19:08 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup] shyju pv
2012-06-24 19:08 ` shyju pv
2012-06-26 23:00 ` Masanari Iida
2012-06-26 23:00   ` Masanari Iida
2012-06-27 18:29 ` tj
2012-06-27 18:29   ` tj-DgEjT+Ai2ygdnm+yROfE0A
2012-06-27 23:02   ` tj [this message]
2012-06-27 23:02     ` tj-DgEjT+Ai2ygdnm+yROfE0A
2012-06-28 14:09     ` Masanari Iida
2012-06-28 14:09       ` Masanari Iida
2012-06-28  6:07   ` Li Zefan
2012-06-28  6:07   ` Li Zefan
2012-06-28 18:07     ` tj
2012-06-28 18:07       ` tj-DgEjT+Ai2ygdnm+yROfE0A
2012-06-29  2:20       ` Li Zefan
2012-06-29  2:20         ` Li Zefan
2012-06-29 16:58         ` tj
2012-06-29 16:58           ` tj-DgEjT+Ai2ygdnm+yROfE0A
2012-06-29 18:07           ` Masanari Iida
2012-06-30  6:13           ` Li Zefan
2012-06-30  6:13             ` Li Zefan
2012-06-30  6:47             ` Al Viro
2012-06-30  6:47               ` Al Viro
2012-06-30  7:04               ` Tejun Heo
2012-06-30  7:04                 ` Tejun Heo
2012-06-30  8:34                 ` Al Viro
2012-06-30  8:34                   ` Al Viro
2012-07-03 17:10                   ` Tejun Heo
2012-07-03 17:10                     ` Tejun Heo
2012-07-03 17:38                     ` [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode Tejun Heo
2012-07-03 17:38                       ` Tejun Heo
2012-07-04  5:40                       ` Li Zefan
2012-07-04  5:40                         ` Li Zefan
2012-07-09 17:11                         ` Tejun Heo
2012-07-09 17:11                           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627230230.GT15811@google.com \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=sanil.kumar@huawei.com \
    --cc=shyju.pv@huawei.com \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.