[LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Markos Chandras]

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Hi, please review the attached patch

-- 
markos

[-- Attachment #2: 0009-realtime-lib-Makefile-Fix-path-for-config.mk.patch --]
[-- Type: text/plain, Size: 950 bytes --]

From 34eab5207f365db3ed43614bb499a8863ca2ca82 Mon Sep 17 00:00:00 2001
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 15 Dec 2011 12:14:47 +0000
Subject: [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

The autotools in realtime subfolders overwrites the top level autotools
variables. To avoid this problem, we use relative
paths instead of using variables that may or may not be have been
overwritten  by another autotools build.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 testcases/realtime/lib/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/realtime/lib/Makefile b/testcases/realtime/lib/Makefile
index 8860549..ecf4b5c 100644
--- a/testcases/realtime/lib/Makefile
+++ b/testcases/realtime/lib/Makefile
@@ -22,7 +22,7 @@
 
 top_srcdir		?= ../../..
 
-include $(top_srcdir)/../config.mk
+include ../config.mk
 
 CFLAGS			+= -D_GNU_SOURCE
 
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Garrett Cooper]

On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Markos Chandras]

On 01/03/2012 07:24 PM, Garrett Cooper wrote:
> On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras
> <Markos.Chandras@imgtec.com>  wrote:
>> Hi, please review the attached patch
>
> No -- this breaks out-of-tree compiles.
> -Garrett
But without this patch, the in-tree 'distclean' target is broken

-- 
markos


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Garrett Cooper]

On Wed, Jan 4, 2012 at 3:20 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> On 01/03/2012 07:24 PM, Garrett Cooper wrote:
>>
>> On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras
>> <Markos.Chandras@imgtec.com>  wrote:
>>>
>>> Hi, please review the attached patch
>>
>>
>> No -- this breaks out-of-tree compiles.
>> -Garrett
>
> But without this patch, the in-tree 'distclean' target is broken

    Hmmm... it worked once upon a time. I'll look at this when I have a chance.
Thanks,
-Garrett

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Cyril Hrubis]

Hi!
> >>> Hi, please review the attached patch
> >>
> >>
> >> No -- this breaks out-of-tree compiles.
> >> -Garrett
> >
> > But without this patch, the in-tree 'distclean' target is broken
> 
>     Hmmm... it worked once upon a time. I'll look at this when I have a chance.

It's broken since 21e14b79ce269f27be8ce49475dc49c5bc5838bd, reverting it
fixed the build.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[Cyril Hrubis]

Hi!
> > >>> Hi, please review the attached patch
> > >>
> > >>
> > >> No -- this breaks out-of-tree compiles.
> > >> -Garrett
> > >
> > > But without this patch, the in-tree 'distclean' target is broken
> > 
> >     Hmmm... it worked once upon a time. I'll look at this when I have a chance.
> 
> It's broken since 21e14b79ce269f27be8ce49475dc49c5bc5838bd, reverting it
> fixed the build.

Ping. Any chance you will look at this, the out of tree build is broken
without that patch and the in tree with.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

[chrubis]

[-- Attachment #1: Type: text/plain, Size: 65 bytes --]

Hi!
What about attached patch?

-- 
Cyril Hrubis
chrubis@suse.cz

[-- Attachment #2: 0001-Fix-realtime-build.patch --]
[-- Type: text/x-patch, Size: 1070 bytes --]

From 36ae7233c9606b78edcb2ca0eaf1a0a926cbd470 Mon Sep 17 00:00:00 2001
From: Cyril Hrubis <chrubis@suse.cz>
Date: Wed, 20 Jun 2012 17:14:57 +0200
Subject: [PATCH 1/3] Fix realtime build.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 testcases/realtime/lib/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/realtime/lib/Makefile b/testcases/realtime/lib/Makefile
index 8860549..fc4784b 100644
--- a/testcases/realtime/lib/Makefile
+++ b/testcases/realtime/lib/Makefile
@@ -2,6 +2,7 @@
 #    realtime/lib Makefile.
 #
 #    Copyright (C) 2009, Cisco Systems Inc.
+#    Copyright (C) 2012  Cyril Hrubis <chrubis@suse.cz>
 #
 #    This program is free software; you can redistribute it and/or modify
 #    it under the terms of the GNU General Public License as published by
@@ -22,9 +23,9 @@
 
 top_srcdir		?= ../../..
 
-include $(top_srcdir)/../config.mk
+include $(top_srcdir)/include/mk/env_pre.mk
 
-CFLAGS			+= -D_GNU_SOURCE
+CFLAGS			+= -D_GNU_SOURCE -I../include/
 
 LDLIBS			+= -lpthread -lrt -lm
 
-- 
1.7.3.4


[-- Attachment #3: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list