From: David Miller <davem@davemloft.net>
To: jitendra.kalsaria@qlogic.com
Cc: netdev@vger.kernel.org, ron.mercer@qlogic.com,
Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors.
Date: Mon, 02 Jul 2012 18:41:34 -0700 (PDT) [thread overview]
Message-ID: <20120702.184134.1131493483786674336.davem@davemloft.net> (raw)
In-Reply-To: <20120702.183826.1521103644475572622.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 02 Jul 2012 18:38:26 -0700 (PDT)
> From: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
> Date: Mon, 2 Jul 2012 18:30:47 -0700
>
>> As per your comments, TX ring full is not expected behavior? All I
>> can think of increasing the TX queue to 1024 and clean-up in timer
>> instead of interrupt?
>
> Your transmit function should never be invoked when the queue is
> full, logic elsewhere in your driver should have stopped the queue
> therefore preventing further invocations of your transmit function
> until you wake the queue when space is liberated in the TX ring.
BTW, did it even occur to you that there is a kernel log message here
in this code path for a reason?
That log message is there because this event is unexpected and a
driver error.
next prev parent reply other threads:[~2012-07-03 1:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 23:41 [PATCH net 0/7] qlge: bug fix Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors Jitendra Kalsaria
2012-07-03 0:18 ` David Miller
2012-07-03 1:30 ` Jitendra Kalsaria
2012-07-03 1:38 ` David Miller
2012-07-03 1:41 ` David Miller [this message]
2012-07-03 3:28 ` Krishna Kumar2
2012-07-03 19:38 ` Jitendra Kalsaria
2012-07-03 20:27 ` Eric Dumazet
2012-07-03 22:22 ` Francois Romieu
2012-07-03 22:33 ` Jitendra Kalsaria
2012-07-03 23:14 ` David Miller
2012-07-02 23:41 ` [PATCH net 2/7] qlge: Stand-up card should not report supporting wol Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 3/7] qlge: Garbage values shown in extra info during selftest Jitendra Kalsaria
2012-07-05 7:23 ` David Miller
2012-07-05 17:13 ` Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 4/7] qlge: Fixed double pci free upon tx_ring->q allocation failure Jitendra Kalsaria
2012-07-03 1:22 ` Ben Hutchings
2012-07-03 5:56 ` Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 5/7] qlge: Categorize receive frame errors from firmware Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 6/7] qlge: refactoring of ethtool stats Jitendra Kalsaria
2012-07-03 1:24 ` Ben Hutchings
2012-07-03 1:26 ` David Miller
2012-07-02 23:41 ` [PATCH net 7/7] qlge: Bumped driver version to 1.00.00.31 Jitendra Kalsaria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702.184134.1131493483786674336.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.