Re: [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors.

From: Krishna Kumar2 <krkumar2@in.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: Dept_NX_Linux_NIC_Driver@qlogic.com,
	jitendra.kalsaria@qlogic.com, netdev@vger.kernel.org,
	ron.mercer@qlogic.com
Subject: Re: [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors.
Date: Tue, 3 Jul 2012 08:58:35 +0530	[thread overview]
Message-ID: <OFE8F5E8D9.DB59CE9B-ON65257A30.00128DF8-65257A30.00132AAC@in.ibm.com> (raw)
In-Reply-To: <20120702.184134.1131493483786674336.davem@davemloft.net>

> David Miller <davem@davemloft.net> 07/03/2012 07:11 AM
>
> >> As per your comments, TX ring full is not expected behavior? All I
> >> can think of increasing the TX queue to 1024 and clean-up in timer
> >> instead of interrupt?
> >
> > Your transmit function should never be invoked when the queue is
> > full, logic elsewhere in your driver should have stopped the queue
> > therefore preventing further invocations of your transmit function
> > until you wake the queue when space is liberated in the TX ring.
>
> BTW, did it even occur to you that there is a kernel log message here
> in this code path for a reason?
>
> That log message is there because this event is unexpected and a
> driver error.

Correctly coded drivers check for this condition:
"atomic_read(&tx_ring->tx_count) < 2" (without the
unlikely) once again at the end of the xmit and stop
the queue if required. Also, the message should be changed
to show that reaching here is an error.

thanks,
- KK