All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Dong Aisheng <dong.aisheng@linaro.org>,
	linux-can@vger.kernel.org
Subject: Re: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support
Date: Mon, 2 Jul 2012 09:52:09 +0800	[thread overview]
Message-ID: <20120702015206.GA21003@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <4FF0D401.4050101@pengutronix.de>

On Mon, Jul 02, 2012 at 12:49:37AM +0200, Marc Kleine-Budde wrote:
> > +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > +	if (IS_ERR(pinctrl))
> > +		return PTR_ERR(pinctrl);
> > +
> >  	if (pdev->dev.of_node) {
> >  		const u32 *clock_freq_p;
> 
> I'm on mx28 and trying to load the flexcan driver via DT, but
> devm_pinctrl_get_select_default fails with -19.
> 
You need to have pinctrl state setup in dts, some like:

http://article.gmane.org/gmane.linux.ports.arm.kernel/174148

> What am I doing wrong? Will this fail with the same error on non DT
> platforms?
> 
No, it will not, because a dummy pinctrl state is provided by
calling pinctrl_provide_dummies() in mx28_soc_init().

-- 
Regards,
Shawn


WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support
Date: Mon, 2 Jul 2012 09:52:09 +0800	[thread overview]
Message-ID: <20120702015206.GA21003@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <4FF0D401.4050101@pengutronix.de>

On Mon, Jul 02, 2012 at 12:49:37AM +0200, Marc Kleine-Budde wrote:
> > +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > +	if (IS_ERR(pinctrl))
> > +		return PTR_ERR(pinctrl);
> > +
> >  	if (pdev->dev.of_node) {
> >  		const u32 *clock_freq_p;
> 
> I'm on mx28 and trying to load the flexcan driver via DT, but
> devm_pinctrl_get_select_default fails with -19.
> 
You need to have pinctrl state setup in dts, some like:

http://article.gmane.org/gmane.linux.ports.arm.kernel/174148

> What am I doing wrong? Will this fail with the same error on non DT
> platforms?
> 
No, it will not, because a dummy pinctrl state is provided by
calling pinctrl_provide_dummies() in mx28_soc_init().

-- 
Regards,
Shawn

  reply	other threads:[~2012-07-02  1:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07  0:53 [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers Shawn Guo
2012-05-07  0:53 ` Shawn Guo
2012-05-07  0:53 ` [PATCH RESEND 1/5] tty: serial: imx: adopt pinctrl support Shawn Guo
2012-05-07  0:53   ` Shawn Guo
2012-05-08  3:43   ` Dong Aisheng
2012-05-08  3:43     ` Dong Aisheng
2012-05-07  0:53 ` [PATCH RESEND 2/5] net: fec: " Shawn Guo
2012-05-07  0:53   ` Shawn Guo
2012-05-08  3:44   ` Dong Aisheng
2012-05-08  3:44     ` Dong Aisheng
2012-05-11 22:31   ` David Miller
2012-05-11 22:31     ` David Miller
2012-05-07  0:53 ` [PATCH RESEND 3/5] can: flexcan: " Shawn Guo
2012-05-07  0:53   ` Shawn Guo
2012-05-07  8:06   ` Marc Kleine-Budde
2012-05-07  8:06     ` Marc Kleine-Budde
2012-05-07  8:17     ` Shawn Guo
2012-05-07  8:17       ` Shawn Guo
2012-05-07  8:29       ` Marc Kleine-Budde
2012-05-07  8:29         ` Marc Kleine-Budde
2012-05-08  3:44   ` Dong Aisheng
2012-05-08  3:44     ` Dong Aisheng
2012-07-01 22:49   ` Marc Kleine-Budde
2012-07-01 22:49     ` Marc Kleine-Budde
2012-07-02  1:52     ` Shawn Guo [this message]
2012-07-02  1:52       ` Shawn Guo
2012-07-03 10:00       ` Marc Kleine-Budde
2012-07-03 10:00         ` Marc Kleine-Budde
     [not found] ` <1336352040-28447-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-07  0:53   ` [PATCH RESEND 4/5] i2c: imx: " Shawn Guo
2012-05-07  0:53     ` Shawn Guo
     [not found]     ` <1336352040-28447-5-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-05-08  3:45       ` Dong Aisheng
2012-05-08  3:45         ` Dong Aisheng
2012-05-07  0:54   ` [PATCH RESEND 5/5] spi/imx: " Shawn Guo
2012-05-07  0:54     ` Shawn Guo
2012-05-08  3:45     ` Dong Aisheng
2012-05-08  3:45       ` Dong Aisheng
     [not found]       ` <20120508034545.GJ23607-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-05-20  4:40         ` Grant Likely
2012-05-20  4:40           ` Grant Likely
2012-05-20  5:19           ` Shawn Guo
2012-05-20  5:19             ` Shawn Guo
2012-05-07  6:50 ` [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers Dong Aisheng
2012-05-07  6:50   ` Dong Aisheng
2012-05-07  6:50   ` Dong Aisheng
2012-05-07  7:34   ` Shawn Guo
2012-05-07  7:34     ` Shawn Guo
2012-05-07  7:53     ` Dong Aisheng
2012-05-07  7:53       ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702015206.GA21003@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dong.aisheng@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=olof@lixom.net \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.