All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v6] sctp: be more restrictive in transport selection on bundled sacks
Date: Mon, 2 Jul 2012 08:25:31 -0400	[thread overview]
Message-ID: <20120702122531.GA29681@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20120701234424.GA23935@neilslaptop.think-freely.org>

On Sun, Jul 01, 2012 at 07:44:25PM -0400, Neil Horman wrote:
> On Sun, Jul 01, 2012 at 02:43:19PM -0700, David Miller wrote:
> > From: Neil Horman <nhorman@tuxdriver.com>
> > Date: Sun, 1 Jul 2012 08:47:50 -0400
> > 
> > > Perhaps we could modify the SubmittingPatches document to indicate that an
> > > Acked-by from a subsystem maintainer implicitly confers authority on the
> > > upstream receiver to request reasonable stylistic changes that don't affect the
> > > functionality of the patch in the interests of maintaining coding conventions.
> > 
> > Yes, that would make sense.
> > 
> 
> 
> I'll propose it in a few days.
> Neil
> 
How does this language sound to you?


diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c379a2a..1eaaeb1 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -414,6 +414,16 @@ the part which affects that maintainer's code.  Judgement should be used here.
 When in doubt people should refer to the original discussion in the mailing
 list archives.
 
+Note that an Acked-by: From a subsystem maintainer on a given patch confers
+upon the tree maintainer integrating the path the authority to carry those Acks
+forward through subsequent versions of a patch, as long as those versions do not
+significantly impact the functionality of the patch.  For example, say the isdn
+subsystem maintainer sends an Acked-by: on version 1 of a patch bound for the
+networking tree.  The networking maintainer then requests that some comments in
+the code be modified to comply with the CodingStyle document.  The networking
+tree maintanier may reapply the subsystem maintainers Acked-by: to the new
+version as no significant changes were made to the patch functionality.
+
 If a person has had the opportunity to comment on a patch, but has not
 provided such comments, you may optionally add a "Cc:" tag to the patch.
 This is the only tag which might be added without an explicit action by the

WARNING: multiple messages have this Message-ID (diff)
From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v6] sctp: be more restrictive in transport selection on bundled sacks
Date: Mon, 02 Jul 2012 12:25:31 +0000	[thread overview]
Message-ID: <20120702122531.GA29681@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20120701234424.GA23935@neilslaptop.think-freely.org>

On Sun, Jul 01, 2012 at 07:44:25PM -0400, Neil Horman wrote:
> On Sun, Jul 01, 2012 at 02:43:19PM -0700, David Miller wrote:
> > From: Neil Horman <nhorman@tuxdriver.com>
> > Date: Sun, 1 Jul 2012 08:47:50 -0400
> > 
> > > Perhaps we could modify the SubmittingPatches document to indicate that an
> > > Acked-by from a subsystem maintainer implicitly confers authority on the
> > > upstream receiver to request reasonable stylistic changes that don't affect the
> > > functionality of the patch in the interests of maintaining coding conventions.
> > 
> > Yes, that would make sense.
> > 
> 
> 
> I'll propose it in a few days.
> Neil
> 
How does this language sound to you?


diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c379a2a..1eaaeb1 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -414,6 +414,16 @@ the part which affects that maintainer's code.  Judgement should be used here.
 When in doubt people should refer to the original discussion in the mailing
 list archives.
 
+Note that an Acked-by: From a subsystem maintainer on a given patch confers
+upon the tree maintainer integrating the path the authority to carry those Acks
+forward through subsequent versions of a patch, as long as those versions do not
+significantly impact the functionality of the patch.  For example, say the isdn
+subsystem maintainer sends an Acked-by: on version 1 of a patch bound for the
+networking tree.  The networking maintainer then requests that some comments in
+the code be modified to comply with the CodingStyle document.  The networking
+tree maintanier may reapply the subsystem maintainers Acked-by: to the new
+version as no significant changes were made to the patch functionality.
+
 If a person has had the opportunity to comment on a patch, but has not
 provided such comments, you may optionally add a "Cc:" tag to the patch.
 This is the only tag which might be added without an explicit action by the

  reply	other threads:[~2012-07-02 12:25 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 20:31 [PATCH] sctp: be mroe restrictive in transport selection on bundled sacks Neil Horman
2012-06-26 20:31 ` Neil Horman
2012-06-27  4:05 ` David Miller
2012-06-27  4:05   ` David Miller
2012-06-27 10:24   ` Neil Horman
2012-06-27 10:24     ` Neil Horman
2012-06-27 13:20     ` Vlad Yasevich
2012-06-27 13:20       ` Vlad Yasevich
2012-06-27 13:22       ` Neil Horman
2012-06-27 13:22         ` Neil Horman
2012-06-27 14:23 ` [PATCH v2] sctp: be more " Neil Horman
2012-06-27 15:10   ` Vlad Yasevich
2012-06-27 17:28     ` Neil Horman
2012-06-27 19:44       ` Vlad Yasevich
2012-06-27 19:44         ` Vlad Yasevich
2012-06-28 15:33         ` Neil Horman
2012-06-28 15:33           ` Neil Horman
2012-06-28 15:58           ` Vlad Yasevich
2012-06-28 15:58             ` Vlad Yasevich
2012-06-28 18:07             ` Neil Horman
2012-06-28 18:07               ` Neil Horman
2012-06-28 18:22               ` Vlad Yasevich
2012-06-28 18:22                 ` Vlad Yasevich
2012-06-28 18:36                 ` Neil Horman
2012-06-28 18:36                   ` Neil Horman
2012-06-28 20:14                 ` Neil Horman
2012-06-28 20:14                   ` Neil Horman
2012-06-29 16:34 ` [PATCH v3] " Neil Horman
2012-06-29 18:29   ` Vlad Yasevich
2012-06-29 18:43     ` Neil Horman
2012-06-29 19:15       ` Vlad Yasevich
2012-06-29 19:21         ` Neil Horman
2012-06-29 19:24 ` [PATCH v4] " Neil Horman
2012-06-29 19:24   ` Neil Horman
2012-06-29 20:15 ` [PATCH v5] " Neil Horman
2012-06-29 20:15   ` Neil Horman
2012-06-29 20:19   ` Vlad Yasevich
2012-06-29 20:19     ` Vlad Yasevich
2012-06-29 23:34   ` David Miller
2012-06-29 23:34     ` David Miller
2012-06-30 12:26     ` Neil Horman
2012-06-30 12:26       ` Neil Horman
2012-07-01  0:38       ` David Miller
2012-07-01  0:38         ` David Miller
2012-06-30 13:04 ` [PATCH v6] " Neil Horman
2012-06-30 13:04   ` Neil Horman
2012-07-01  0:39   ` David Miller
2012-07-01  0:39     ` David Miller
2012-07-01  3:17     ` Vlad Yasevich
2012-07-01  3:17       ` Vlad Yasevich
2012-07-01  5:44       ` David Miller
2012-07-01  5:44         ` David Miller
2012-07-01 12:47     ` Neil Horman
2012-07-01 12:47       ` Neil Horman
2012-07-01 21:43       ` David Miller
2012-07-01 21:43         ` David Miller
2012-07-01 23:44         ` Neil Horman
2012-07-01 23:44           ` Neil Horman
2012-07-02 12:25           ` Neil Horman [this message]
2012-07-02 12:25             ` Neil Horman
2012-07-03  0:10             ` David Miller
2012-07-03  0:10               ` David Miller
2012-07-03 18:45             ` Jan Ceuleers
2012-07-03 18:45               ` Jan Ceuleers
2012-07-03 23:42               ` Neil Horman
2012-07-03 23:42                 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120702122531.GA29681@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.