[PATCH] wireless: fix leak found by coverity

[PATCH] wireless: fix leak found by coverity

[Alan Cox]

From: Alan Cox <alan@linux.intel.com>

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/net/wireless/mwifiex/cfg80211.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
index 97de652..497a05a 100644
--- a/drivers/net/wireless/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/mwifiex/cfg80211.c
@@ -1003,6 +1003,7 @@ static int mwifiex_cfg80211_start_ap(struct wiphy *wiphy,
 	case NL80211_HIDDEN_SSID_ZERO_CONTENTS:
 		/* firmware doesn't support this type of hidden SSID */
 	default:
+		kfree(bss_cfg);
 		return -EINVAL;
 	}
 

RE: [PATCH] wireless: fix leak found by coverity

[Bing Zhao]

SGkgQWxhbiwNCg0KPiBTdWJqZWN0OiBbUEFUQ0hdIHdpcmVsZXNzOiBmaXggbGVhayBmb3VuZCBi
eSBjb3Zlcml0eQ0KDQpJJ3ZlIHNlbnQgYSBzaW1pbGFyIHBhdGNoIHRvIGxpbnV4LXdpcmVsZXNz
IGxpc3QuDQoNCltQQVRDSCAzLjVdIG13aWZpZXg6IGZpeCBDb3Zlcml0eSBTQ0FOIENJRCA3MDkw
Nzg6IFJlc291cmNlIGxlYWsgKFJFU09VUkNFX0xFQUspDQoNCmh0dHA6Ly9tYXJjLmluZm8vP2w9
bGludXgtd2lyZWxlc3MmbT0xMzQxMzU2NDM3Mjc0MjQmdz0yDQoNClRoYW5rcywNCkJpbmcNCg0K
PiANCj4gRnJvbTogQWxhbiBDb3ggPGFsYW5AbGludXguaW50ZWwuY29tPg0KPiANCj4gU2lnbmVk
LW9mZi1ieTogQWxhbiBDb3ggPGFsYW5AbGludXguaW50ZWwuY29tPg0KPiAtLS0NCj4gDQo+ICBk
cml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L2NmZzgwMjExLmMgfCAgICAxICsNCj4gIDEgZmls
ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL213aWZpZXgvY2ZnODAyMTEuYyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZp
ZXgvY2ZnODAyMTEuYw0KPiBpbmRleCA5N2RlNjUyLi40OTdhMDVhIDEwMDY0NA0KPiAtLS0gYS9k
cml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L2NmZzgwMjExLmMNCj4gKysrIGIvZHJpdmVycy9u
ZXQvd2lyZWxlc3MvbXdpZmlleC9jZmc4MDIxMS5jDQo+IEBAIC0xMDAzLDYgKzEwMDMsNyBAQCBz
dGF0aWMgaW50IG13aWZpZXhfY2ZnODAyMTFfc3RhcnRfYXAoc3RydWN0IHdpcGh5ICp3aXBoeSwN
Cj4gIAljYXNlIE5MODAyMTFfSElEREVOX1NTSURfWkVST19DT05URU5UUzoNCj4gIAkJLyogZmly
bXdhcmUgZG9lc24ndCBzdXBwb3J0IHRoaXMgdHlwZSBvZiBoaWRkZW4gU1NJRCAqLw0KPiAgCWRl
ZmF1bHQ6DQo+ICsJCWtmcmVlKGJzc19jZmcpOw0KPiAgCQlyZXR1cm4gLUVJTlZBTDsNCj4gIAl9
DQo+IA0KDQo=

RE: [PATCH] wireless: fix leak found by coverity

[Bing Zhao]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1102 bytes --]

Hi Alan,

> Subject: [PATCH] wireless: fix leak found by coverity

I've sent a similar patch to linux-wireless list.

[PATCH 3.5] mwifiex: fix Coverity SCAN CID 709078: Resource leak (RESOURCE_LEAK)

http://marc.info/?l=linux-wireless&m=134135643727424&w=2

Thanks,
Bing

> 
> From: Alan Cox <alan@linux.intel.com>
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/net/wireless/mwifiex/cfg80211.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
> index 97de652..497a05a 100644
> --- a/drivers/net/wireless/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> @@ -1003,6 +1003,7 @@ static int mwifiex_cfg80211_start_ap(struct wiphy *wiphy,
>  	case NL80211_HIDDEN_SSID_ZERO_CONTENTS:
>  		/* firmware doesn't support this type of hidden SSID */
>  	default:
> +		kfree(bss_cfg);
>  		return -EINVAL;
>  	}
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥