* regulator: Does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able?
@ 2012-07-06 2:36 Axel Lin
2012-07-06 11:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-07-06 2:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Brown, Kyungmin Park, Liam Girdwood, MyungJoo Ham
Just wandering does it make sense to set the same ops for
[en|dis]able and set_suspend_[en|dis]able callbacks.
Or these drivers need fix?
max8952:
static struct regulator_ops max8952_ops = {
.list_voltage = max8952_list_voltage,
.is_enabled = max8952_is_enabled,
.enable = max8952_enable,
.disable = max8952_disable,
.get_voltage_sel = max8952_get_voltage_sel,
.set_voltage_sel = max8952_set_voltage_sel,
.set_suspend_disable = max8952_disable,
};
max8998:
static struct regulator_ops max8998_ldo_ops = {
.list_voltage = max8998_list_voltage,
.is_enabled = max8998_ldo_is_enabled,
.enable = max8998_ldo_enable,
.disable = max8998_ldo_disable,
.get_voltage_sel = max8998_get_voltage_sel,
.set_voltage = max8998_set_voltage_ldo,
.set_suspend_enable = max8998_ldo_enable,
.set_suspend_disable = max8998_ldo_disable,
};
static struct regulator_ops max8998_buck_ops = {
.list_voltage = max8998_list_voltage,
.is_enabled = max8998_ldo_is_enabled,
.enable = max8998_ldo_enable,
.disable = max8998_ldo_disable,
.get_voltage_sel = max8998_get_voltage_sel,
.set_voltage = max8998_set_voltage_buck,
.set_voltage_time_sel = max8998_set_voltage_buck_time_sel,
.set_suspend_enable = max8998_ldo_enable,
.set_suspend_disable = max8998_ldo_disable,
};
static struct regulator_ops max8998_others_ops = {
.is_enabled = max8998_ldo_is_enabled,
.enable = max8998_ldo_enable,
.disable = max8998_ldo_disable,
.set_suspend_enable = max8998_ldo_enable,
.set_suspend_disable = max8998_ldo_disable,
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: regulator: Does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able?
2012-07-06 2:36 regulator: Does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able? Axel Lin
@ 2012-07-06 11:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-07-06 11:06 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Kyungmin Park, Liam Girdwood, MyungJoo Ham
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Fri, Jul 06, 2012 at 10:36:27AM +0800, Axel Lin wrote:
> Just wandering does it make sense to set the same ops for
> [en|dis]able and set_suspend_[en|dis]able callbacks.
>
> Or these drivers need fix?
These drivers needo to be fixed, using the same ops for both is actively
broken.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-06 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-06 2:36 regulator: Does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able? Axel Lin
2012-07-06 11:06 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.