All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 14/16] ipv4: Kill dst_copy_metrics() call from ipv4_blackhole_route().
@ 2012-07-10 15:07 David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2012-07-10 15:07 UTC (permalink / raw)
  To: netdev


Blackhole routes have a COW metrics operation that returns NULL
always, therefore this dst_copy_metrics() call did absolutely
nothing.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/ipv4/route.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 1678b57..a967df5 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2668,7 +2668,6 @@ struct dst_entry *ipv4_blackhole_route(struct net *net, struct dst_entry *dst_or
 		new->__use = 1;
 		new->input = dst_discard;
 		new->output = dst_discard;
-		dst_copy_metrics(new, &ort->dst);
 
 		new->dev = ort->dst.dev;
 		if (new->dev)
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-10 15:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-10 15:07 [PATCH 14/16] ipv4: Kill dst_copy_metrics() call from ipv4_blackhole_route() David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.