All of lore.kernel.org
 help / color / mirror / Atom feed
* [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be us
@ 2012-07-10  0:40 wfg
  2012-07-10  7:21 ` [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may b Lars-Peter Clausen
  0 siblings, 1 reply; 2+ messages in thread
From: wfg @ 2012-07-10  0:40 UTC (permalink / raw)
  To: kernel-janitors

Hi Lars-Peter,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   f12db36d3fd7ab75c29015c32a12d49697e11f61
commit: da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b [84/99] staging:iio:max1363: Do not return error code in interrupt handler

All warnings:

drivers/staging/iio/adc/max1363_ring.c: In function 'max1363_trigger_handler':
drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be used uninitialized in this function [-Wmaybe-uninitialized]

vim +87 drivers/staging/iio/adc/max1363_ring.c
    84	
    85	done:
    86		iio_trigger_notify_done(indio_dev->trig);
  > 87		kfree(rxbuf);
    88	
    89		return IRQ_HANDLED;
    90	}

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may b
  2012-07-10  0:40 [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be us wfg
@ 2012-07-10  7:21 ` Lars-Peter Clausen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2012-07-10  7:21 UTC (permalink / raw)
  To: kernel-janitors

On 07/10/2012 02:40 AM, wfg@linux.intel.com wrote:
> Hi Lars-Peter,
> 
> There are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
> head:   f12db36d3fd7ab75c29015c32a12d49697e11f61
> commit: da0f01e1ed88b4ac650d884e4e2ee11c9cd4d83b [84/99] staging:iio:max1363: Do not return error code in interrupt handler
> 
> All warnings:
> 
> drivers/staging/iio/adc/max1363_ring.c: In function 'max1363_trigger_handler':
> drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 

Yea, known issue. I somehow managed to send out an outdated version of the
patch, the one I have locally does not have this issue. Will send out a fix
shortly.

Thanks for reporting.
- Lars

> vim +87 drivers/staging/iio/adc/max1363_ring.c
>     84	
>     85	done:
>     86		iio_trigger_notify_done(indio_dev->trig);
>   > 87		kfree(rxbuf);
>     88	
>     89		return IRQ_HANDLED;
>     90	}
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-10  7:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-10  0:40 [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may be us wfg
2012-07-10  7:21 ` [staging:staging-next 84/99] drivers/staging/iio/adc/max1363_ring.c:87:7: warning: 'rxbuf' may b Lars-Peter Clausen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.