From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment
Date: Tue, 10 Jul 2012 03:55:29 +0200 [thread overview]
Message-ID: <201207100355.29187.marex@denx.de> (raw)
In-Reply-To: <CAA3CPjULfaPpPqyZFOe2wbNYFVqvxyrczYx-s4S=-SRUwoQqmQ@mail.gmail.com>
Dear Ilya Yanok,
> Hi Marek,
>
> On Sun, Jul 8, 2012 at 7:08 AM, Marek Vasut <marex@denx.de> wrote:
> > - /* Invalidate the memory area occupied by buffer */
> > - invalidate_dcache_range(((uint32_t)buffer & ~31),
> > - ((uint32_t)buffer & ~31) + roundup(length, 32));
> > + /*
> > + * Invalidate the memory area occupied by buffer
> > + * Don't try to fix the buffer alignment, if it isn't properly
> > + * aligned it's upper layer's fault so let
> > invalidate_dcache_range()
> > + * vow about it. But we have to fix the length as it's actual
> > + * transfer length and can be unaligned. This is potentially
> > + * dangerous operation, it's responsibility of the calling
> > + * code to make sure enough space is reserved.
> > + */
> > + invalidate_dcache_range((uint32_t)buffer,
> > + ALIGN_END_ADDR(u8, buffer, length));
>
> We shouldn't use ALIGN_END_ADDR here. This can lead to strange results on
> systems with ARCH_DMA_MINALIGN < 32.
Good point, ALIGN_END_ADDR should align it to max(32, length) ?
> Regards, Ilya.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-10 1:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 3:08 [U-Boot] [PATCH 1/2] common.h: Introduce DEFINE_CACHE_ALIGN_BUFFER Marek Vasut
2012-07-08 3:08 ` [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Marek Vasut
2012-07-08 10:04 ` Ilya Yanok
2012-07-08 18:51 ` Marek Vasut
2012-07-08 20:52 ` Tom Rini
2012-07-08 21:36 ` Marek Vasut
2012-07-09 18:37 ` Ilya Yanok
2012-07-10 1:55 ` Marek Vasut [this message]
2012-07-14 22:11 ` Ilya Yanok
2012-07-14 22:08 ` Ilya Yanok
2012-07-15 8:07 ` Marek Vasut
2012-07-15 8:55 ` Ilya Yanok
2012-07-15 9:42 ` Marek Vasut
2012-07-08 12:23 ` [U-Boot] [PATCH 1/2] common.h: Introduce DEFINE_CACHE_ALIGN_BUFFER Ilya Yanok
2012-07-08 18:55 ` Marek Vasut
2012-07-20 4:01 ` Mike Frysinger
2012-07-20 11:31 ` Marek Vasut
2012-07-20 21:47 ` Mike Frysinger
2012-07-20 21:50 ` Tom Rini
2012-07-21 17:22 ` Mike Frysinger
2012-07-23 15:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207100355.29187.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.