All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <ilya.yanok@cogentembedded.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment
Date: Sun, 15 Jul 2012 02:11:07 +0400	[thread overview]
Message-ID: <CAA3CPjVb9wsRcdzAJiUtZEoNrwx2tRYTRTaTLG2iK+u2uvosvw@mail.gmail.com> (raw)
In-Reply-To: <201207100355.29187.marex@denx.de>

Dear Marek,

On Tue, Jul 10, 2012 at 5:55 AM, Marek Vasut <marex@denx.de> wrote:

>
> > > +       invalidate_dcache_range((uint32_t)buffer,
> > > +               ALIGN_END_ADDR(u8, buffer, length));
> >
> > We shouldn't use ALIGN_END_ADDR here. This can lead to strange results on
> > systems with ARCH_DMA_MINALIGN < 32.
>
>
> Good point, ALIGN_END_ADDR should align it to max(32, length) ?
>
> Hm.. no, actually we should align buffer length to ARCH_DMA_MINALIGN.

Regards, Ilya.

  reply	other threads:[~2012-07-14 22:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-08  3:08 [U-Boot] [PATCH 1/2] common.h: Introduce DEFINE_CACHE_ALIGN_BUFFER Marek Vasut
2012-07-08  3:08 ` [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment Marek Vasut
2012-07-08 10:04   ` Ilya Yanok
2012-07-08 18:51     ` Marek Vasut
2012-07-08 20:52       ` Tom Rini
2012-07-08 21:36         ` Marek Vasut
2012-07-09 18:37   ` Ilya Yanok
2012-07-10  1:55     ` Marek Vasut
2012-07-14 22:11       ` Ilya Yanok [this message]
2012-07-14 22:08   ` Ilya Yanok
2012-07-15  8:07     ` Marek Vasut
2012-07-15  8:55       ` Ilya Yanok
2012-07-15  9:42         ` Marek Vasut
2012-07-08 12:23 ` [U-Boot] [PATCH 1/2] common.h: Introduce DEFINE_CACHE_ALIGN_BUFFER Ilya Yanok
2012-07-08 18:55   ` Marek Vasut
2012-07-20  4:01 ` Mike Frysinger
2012-07-20 11:31   ` Marek Vasut
2012-07-20 21:47     ` Mike Frysinger
2012-07-20 21:50       ` Tom Rini
2012-07-21 17:22         ` Mike Frysinger
2012-07-23 15:24           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA3CPjVb9wsRcdzAJiUtZEoNrwx2tRYTRTaTLG2iK+u2uvosvw@mail.gmail.com \
    --to=ilya.yanok@cogentembedded.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.