* [PATCH] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper
@ 2012-07-07 17:32 Julian Anastasov
2012-07-10 8:57 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Julian Anastasov @ 2012-07-07 17:32 UTC (permalink / raw)
To: Simon Horman; +Cc: lvs-devel
The FTP application indirectly depends on the
nf_conntrack_ftp helper for proper NAT support. If the
module is not loaded, IPVS can resize the packets for the
command connection, eg. PASV response but the SEQ adjustment
logic in ipv4_confirm is not called without helper.
Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
net/netfilter/ipvs/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
index f987138..8b2cffd 100644
--- a/net/netfilter/ipvs/Kconfig
+++ b/net/netfilter/ipvs/Kconfig
@@ -250,7 +250,8 @@ comment 'IPVS application helper'
config IP_VS_FTP
tristate "FTP protocol helper"
- depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT
+ depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT && \
+ NF_CONNTRACK_FTP
select IP_VS_NFCT
---help---
FTP is a protocol that transfers IP address and/or port number in
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper
2012-07-07 17:32 [PATCH] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper Julian Anastasov
@ 2012-07-10 8:57 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2012-07-10 8:57 UTC (permalink / raw)
To: Julian Anastasov; +Cc: lvs-devel
On Sat, Jul 07, 2012 at 08:32:12PM +0300, Julian Anastasov wrote:
> The FTP application indirectly depends on the
> nf_conntrack_ftp helper for proper NAT support. If the
> module is not loaded, IPVS can resize the packets for the
> command connection, eg. PASV response but the SEQ adjustment
> logic in ipv4_confirm is not called without helper.
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Thanks, I have added this to my ipvs-next tree
for inclusion in 3.6.
> ---
> net/netfilter/ipvs/Kconfig | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig
> index f987138..8b2cffd 100644
> --- a/net/netfilter/ipvs/Kconfig
> +++ b/net/netfilter/ipvs/Kconfig
> @@ -250,7 +250,8 @@ comment 'IPVS application helper'
>
> config IP_VS_FTP
> tristate "FTP protocol helper"
> - depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT
> + depends on IP_VS_PROTO_TCP && NF_CONNTRACK && NF_NAT && \
> + NF_CONNTRACK_FTP
> select IP_VS_NFCT
> ---help---
> FTP is a protocol that transfers IP address and/or port number in
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-10 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-07 17:32 [PATCH] ipvs: ip_vs_ftp depends on nf_conntrack_ftp helper Julian Anastasov
2012-07-10 8:57 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.