All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix building with autoconf version older than 2.60.
@ 2012-07-09 17:24 Andreas Schneider
       [not found] ` <1341854687-17786-1-git-send-email-asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schneider @ 2012-07-09 17:24 UTC (permalink / raw)
  To: linux-cifs-u79uwXL29TY76Z2rM5mHXA, jlayton-eUNUBHrolfbYtjvyW6yDsg
  Cc: Andreas Schneider

From: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>

AC_PROG_SED is only avaliable in recent autoconf versions.
Use AC_CHECK_PROG instead if AC_PROG_SED is not present.

Signed-off-by: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>
---
 configure.ac |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 0dd1155..f95a2de 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,10 +44,15 @@ AC_ARG_VAR(ROOTSBINDIR, [Location where files ordinarily under /sbin should be i
 
 # Checks for programs.
 AC_PROG_CC
-AC_PROG_SED
 AC_GNU_SOURCE
 AM_PROG_CC_C_O
 
+# AC_PROG_SED is only avaliable in recent autoconf versions.
+# Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
+ifdef([AC_PROG_SED],
+      [AC_PROG_SED],
+      [AC_CHECK_PROG(SED, sed, sed)])
+
 # Checks for typedefs, structures, and compiler characteristics.
 AC_HEADER_STDBOOL
 AC_TYPE_UID_T
-- 
1.7.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix building with autoconf version older than 2.60.
       [not found] ` <1341854687-17786-1-git-send-email-asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
@ 2012-07-09 18:01   ` Jeff Layton
  2012-07-10 17:17   ` Jeff Layton
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2012-07-09 18:01 UTC (permalink / raw)
  To: Andreas Schneider; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA, Andreas Schneider

On Mon,  9 Jul 2012 19:24:47 +0200
Andreas Schneider <asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:

> From: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>
> 
> AC_PROG_SED is only avaliable in recent autoconf versions.
> Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
> 
> Signed-off-by: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>
> ---
>  configure.ac |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0dd1155..f95a2de 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -44,10 +44,15 @@ AC_ARG_VAR(ROOTSBINDIR, [Location where files ordinarily under /sbin should be i
>  
>  # Checks for programs.
>  AC_PROG_CC
> -AC_PROG_SED
>  AC_GNU_SOURCE
>  AM_PROG_CC_C_O
>  
> +# AC_PROG_SED is only avaliable in recent autoconf versions.
> +# Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
> +ifdef([AC_PROG_SED],
> +      [AC_PROG_SED],
> +      [AC_CHECK_PROG(SED, sed, sed)])
> +
>  # Checks for typedefs, structures, and compiler characteristics.
>  AC_HEADER_STDBOOL
>  AC_TYPE_UID_T

Looks fine...

The AC_PROG_SED in the later versions of autoconf do quite a bit more
to verify that sed actually works, but our use of sed is very simple in
cifs-utils so this should be ok.

I'll plan to commit the patch in a day or two if no one objects.

Thanks,
-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix building with autoconf version older than 2.60.
       [not found] ` <1341854687-17786-1-git-send-email-asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
  2012-07-09 18:01   ` Jeff Layton
@ 2012-07-10 17:17   ` Jeff Layton
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2012-07-10 17:17 UTC (permalink / raw)
  To: Andreas Schneider; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA, Andreas Schneider

On Mon,  9 Jul 2012 19:24:47 +0200
Andreas Schneider <asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:

> From: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>
> 
> AC_PROG_SED is only avaliable in recent autoconf versions.
> Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
> 
> Signed-off-by: Andreas Schneider <asn-a6JcYMd0PQ1abyy8hY48cw@public.gmane.org>
> ---
>  configure.ac |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0dd1155..f95a2de 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -44,10 +44,15 @@ AC_ARG_VAR(ROOTSBINDIR, [Location where files ordinarily under /sbin should be i
>  
>  # Checks for programs.
>  AC_PROG_CC
> -AC_PROG_SED
>  AC_GNU_SOURCE
>  AM_PROG_CC_C_O
>  
> +# AC_PROG_SED is only avaliable in recent autoconf versions.
> +# Use AC_CHECK_PROG instead if AC_PROG_SED is not present.
> +ifdef([AC_PROG_SED],
> +      [AC_PROG_SED],
> +      [AC_CHECK_PROG(SED, sed, sed)])
> +
>  # Checks for typedefs, structures, and compiler characteristics.
>  AC_HEADER_STDBOOL
>  AC_TYPE_UID_T

Merged...
-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-10 17:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-09 17:24 [PATCH] Fix building with autoconf version older than 2.60 Andreas Schneider
     [not found] ` <1341854687-17786-1-git-send-email-asn-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2012-07-09 18:01   ` Jeff Layton
2012-07-10 17:17   ` Jeff Layton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.