All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: tps65910: correct init value of n_voltages
@ 2012-07-09 14:57 Laxman Dewangan
  2012-07-10 16:17 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Laxman Dewangan @ 2012-07-09 14:57 UTC (permalink / raw)
  To: lrg, broonie; +Cc: axel.lin, linux-kernel, Laxman Dewangan

Recent change in the core driver to get the maximum voltage
is based on the (n_voltages -1) steps of voltage.
For the tps65910, the (n_voltages -1)th step voltage is
calculated based on the callback function list_voltage.
This function direct maps the datasheet and adjust the
first few steps for initial voltage as per datasheet,
and hence initialize the n_voltages based on datasheet.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
This patch is created on top of
[PATCH V2] regulator: tps65910: add support for input supply
whcih is applied. But I am not able to see in regulator/for-next.
So assuming that it is applied and hence locally apply patch
before creating this patch.

 drivers/regulator/tps65910-regulator.c |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index e319d96..64c93e0 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -194,66 +194,66 @@ static struct tps_info tps65911_regs[] = {
 	{
 		.name = "vdd1",
 		.vin_name = "vcc1",
-		.n_voltages = 73,
+		.n_voltages = 0x4C,
 		.enable_time_us = 350,
 	},
 	{
 		.name = "vdd2",
 		.vin_name = "vcc2",
-		.n_voltages = 73,
+		.n_voltages = 0x4C,
 		.enable_time_us = 350,
 	},
 	{
 		.name = "vddctrl",
-		.n_voltages = 65,
+		.n_voltages = 0x44,
 		.enable_time_us = 900,
 	},
 	{
 		.name = "ldo1",
 		.vin_name = "vcc6",
-		.n_voltages = 47,
+		.n_voltages = 0x33,
 		.enable_time_us = 420,
 	},
 	{
 		.name = "ldo2",
 		.vin_name = "vcc6",
-		.n_voltages = 47,
+		.n_voltages = 0x33,
 		.enable_time_us = 420,
 	},
 	{
 		.name = "ldo3",
 		.vin_name = "vcc5",
-		.n_voltages = 24,
+		.n_voltages = 0x1A,
 		.enable_time_us = 230,
 	},
 	{
 		.name = "ldo4",
 		.vin_name = "vcc5",
-		.n_voltages = 47,
+		.n_voltages = 0x33,
 		.enable_time_us = 230,
 	},
 	{
 		.name = "ldo5",
 		.vin_name = "vcc4",
-		.n_voltages = 24,
+		.n_voltages = 0x1A,
 		.enable_time_us = 230,
 	},
 	{
 		.name = "ldo6",
 		.vin_name = "vcc3",
-		.n_voltages = 24,
+		.n_voltages = 0x1A,
 		.enable_time_us = 230,
 	},
 	{
 		.name = "ldo7",
 		.vin_name = "vcc3",
-		.n_voltages = 24,
+		.n_voltages = 0x1A,
 		.enable_time_us = 230,
 	},
 	{
 		.name = "ldo8",
 		.vin_name = "vcc3",
-		.n_voltages = 24,
+		.n_voltages = 0x1A,
 		.enable_time_us = 230,
 	},
 };
-- 
1.7.1.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: tps65910: correct init value of n_voltages
  2012-07-09 14:57 [PATCH] regulator: tps65910: correct init value of n_voltages Laxman Dewangan
@ 2012-07-10 16:17 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-07-10 16:17 UTC (permalink / raw)
  To: Laxman Dewangan; +Cc: lrg, axel.lin, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

On Mon, Jul 09, 2012 at 08:27:13PM +0530, Laxman Dewangan wrote:
> Recent change in the core driver to get the maximum voltage
> is based on the (n_voltages -1) steps of voltage.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-10 16:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-09 14:57 [PATCH] regulator: tps65910: correct init value of n_voltages Laxman Dewangan
2012-07-10 16:17 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.