From: Michal Hocko <mhocko@suse.cz>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging
Date: Tue, 10 Jul 2012 18:22:50 +0200 [thread overview]
Message-ID: <20120710162249.GA29114@tiehlicka.suse.cz> (raw)
In-Reply-To: <20120710065448.GB6096@kernel>
On Tue 10-07-12 14:54:48, Wanpeng Li wrote:
> On Tue, Jul 10, 2012 at 08:21:04AM +0200, Michal Hocko wrote:
> >On Tue 10-07-12 14:10:21, Wanpeng Li wrote:
> >> On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote:
> >> >On Thu 05-07-12 02:45:00, Johannes Weiner wrote:
> >> >> It does not matter to __mem_cgroup_try_charge() if the passed mm is
> >> >> NULL or init_mm, it will charge the root memcg in either case.
> >>
> >> You can also change the comment in __mem_cgroup_try_charge :
> >>
> >> "if so charge the init_mm" => "if so charge the root memcg"
> >
> >This is already in place:
> >"
> >If mm is NULL and the caller doesn't pass a valid memcg pointer, that is
> >treated as a charge to root_mem_cgroup.
> >"
>
> IIUC, if still keep comment "if so charge the init_mm" is not correct,
> since pages in pagecache aren't mapped into any processes' ptes,
> so mm is NULL, and these pages which in pagecache are not belong
> to init_mm, the comment should be changed. :-)
Fair enough. I guess Johannes will change that in the next post.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging
Date: Tue, 10 Jul 2012 18:22:50 +0200 [thread overview]
Message-ID: <20120710162249.GA29114@tiehlicka.suse.cz> (raw)
In-Reply-To: <20120710065448.GB6096@kernel>
On Tue 10-07-12 14:54:48, Wanpeng Li wrote:
> On Tue, Jul 10, 2012 at 08:21:04AM +0200, Michal Hocko wrote:
> >On Tue 10-07-12 14:10:21, Wanpeng Li wrote:
> >> On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote:
> >> >On Thu 05-07-12 02:45:00, Johannes Weiner wrote:
> >> >> It does not matter to __mem_cgroup_try_charge() if the passed mm is
> >> >> NULL or init_mm, it will charge the root memcg in either case.
> >>
> >> You can also change the comment in __mem_cgroup_try_charge :
> >>
> >> "if so charge the init_mm" => "if so charge the root memcg"
> >
> >This is already in place:
> >"
> >If mm is NULL and the caller doesn't pass a valid memcg pointer, that is
> >treated as a charge to root_mem_cgroup.
> >"
>
> IIUC, if still keep comment "if so charge the init_mm" is not correct,
> since pages in pagecache aren't mapped into any processes' ptes,
> so mm is NULL, and these pages which in pagecache are not belong
> to init_mm, the comment should be changed. :-)
Fair enough. I guess Johannes will change that in the next post.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
To: Wanpeng Li <liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging
Date: Tue, 10 Jul 2012 18:22:50 +0200 [thread overview]
Message-ID: <20120710162249.GA29114@tiehlicka.suse.cz> (raw)
In-Reply-To: <20120710065448.GB6096@kernel>
On Tue 10-07-12 14:54:48, Wanpeng Li wrote:
> On Tue, Jul 10, 2012 at 08:21:04AM +0200, Michal Hocko wrote:
> >On Tue 10-07-12 14:10:21, Wanpeng Li wrote:
> >> On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote:
> >> >On Thu 05-07-12 02:45:00, Johannes Weiner wrote:
> >> >> It does not matter to __mem_cgroup_try_charge() if the passed mm is
> >> >> NULL or init_mm, it will charge the root memcg in either case.
> >>
> >> You can also change the comment in __mem_cgroup_try_charge :
> >>
> >> "if so charge the init_mm" => "if so charge the root memcg"
> >
> >This is already in place:
> >"
> >If mm is NULL and the caller doesn't pass a valid memcg pointer, that is
> >treated as a charge to root_mem_cgroup.
> >"
>
> IIUC, if still keep comment "if so charge the init_mm" is not correct,
> since pages in pagecache aren't mapped into any processes' ptes,
> so mm is NULL, and these pages which in pagecache are not belong
> to init_mm, the comment should be changed. :-)
Fair enough. I guess Johannes will change that in the next post.
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
next prev parent reply other threads:[~2012-07-10 16:22 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 0:44 [patch 00/11] mm: memcg: charge/uncharge improvements Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-05 0:44 ` [patch 01/11] mm: memcg: fix compaction/migration failing due to memcg limits Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:27 ` Kamezawa Hiroyuki
2012-07-09 2:27 ` Kamezawa Hiroyuki
2012-07-09 2:27 ` Kamezawa Hiroyuki
2012-07-09 14:15 ` Michal Hocko
2012-07-09 14:15 ` Michal Hocko
2012-07-09 14:15 ` Michal Hocko
2012-07-05 0:44 ` [patch 02/11] mm: swapfile: clean up unuse_pte race handling Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:29 ` Kamezawa Hiroyuki
2012-07-09 2:29 ` Kamezawa Hiroyuki
2012-07-09 14:22 ` Michal Hocko
2012-07-09 14:22 ` Michal Hocko
2012-07-09 14:22 ` Michal Hocko
2012-07-05 0:44 ` [patch 03/11] mm: shmem: do not try to uncharge known swapcache pages Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:33 ` Kamezawa Hiroyuki
2012-07-09 2:33 ` Kamezawa Hiroyuki
2012-07-09 14:46 ` Michal Hocko
2012-07-09 14:46 ` Michal Hocko
2012-07-09 20:37 ` Hugh Dickins
2012-07-09 20:37 ` Hugh Dickins
2012-07-10 17:16 ` Michal Hocko
2012-07-10 17:16 ` Michal Hocko
2012-07-10 17:16 ` Michal Hocko
2012-07-11 18:48 ` Hugh Dickins
2012-07-11 18:48 ` Hugh Dickins
2012-07-11 18:48 ` Hugh Dickins
2012-07-12 13:51 ` Michal Hocko
2012-07-12 13:51 ` Michal Hocko
2012-07-09 20:11 ` Hugh Dickins
2012-07-09 20:11 ` Hugh Dickins
2012-07-09 20:11 ` Hugh Dickins
2012-07-05 0:44 ` [patch 04/11] mm: memcg: push down PageSwapCache check into uncharge entry functions Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:42 ` Kamezawa Hiroyuki
2012-07-09 2:42 ` Kamezawa Hiroyuki
2012-07-09 2:42 ` Kamezawa Hiroyuki
2012-07-09 7:36 ` Johannes Weiner
2012-07-09 7:36 ` Johannes Weiner
2012-07-09 7:36 ` Johannes Weiner
2012-07-09 15:02 ` Michal Hocko
2012-07-09 15:02 ` Michal Hocko
2012-07-09 15:02 ` Michal Hocko
2012-07-05 0:44 ` [patch 05/11] mm: memcg: only check for PageSwapCache when uncharging anon Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:49 ` Kamezawa Hiroyuki
2012-07-09 2:49 ` Kamezawa Hiroyuki
2012-07-09 2:49 ` Kamezawa Hiroyuki
2012-07-09 15:05 ` Michal Hocko
2012-07-09 15:05 ` Michal Hocko
2012-07-05 0:44 ` [patch 06/11] mm: memcg: move swapin charge functions above callsites Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:50 ` Kamezawa Hiroyuki
2012-07-09 2:50 ` Kamezawa Hiroyuki
2012-07-09 2:50 ` Kamezawa Hiroyuki
2012-07-09 15:10 ` Michal Hocko
2012-07-09 15:10 ` Michal Hocko
2012-07-05 0:44 ` [patch 07/11] mm: memcg: remove unneeded shmem charge type Johannes Weiner
2012-07-05 0:44 ` Johannes Weiner
2012-07-09 2:51 ` Kamezawa Hiroyuki
2012-07-09 2:51 ` Kamezawa Hiroyuki
2012-07-09 15:17 ` Michal Hocko
2012-07-09 15:17 ` Michal Hocko
2012-07-09 15:17 ` Michal Hocko
2012-07-05 0:45 ` [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging Johannes Weiner
2012-07-05 0:45 ` Johannes Weiner
2012-07-09 2:53 ` Kamezawa Hiroyuki
2012-07-09 2:53 ` Kamezawa Hiroyuki
2012-07-09 15:20 ` Michal Hocko
2012-07-09 15:20 ` Michal Hocko
2012-07-09 15:20 ` Michal Hocko
2012-07-10 6:10 ` Wanpeng Li
2012-07-10 6:10 ` Wanpeng Li
2012-07-10 6:10 ` Wanpeng Li
2012-07-10 6:21 ` Michal Hocko
2012-07-10 6:21 ` Michal Hocko
2012-07-10 6:21 ` Michal Hocko
2012-07-10 6:54 ` Wanpeng Li
2012-07-10 6:54 ` Wanpeng Li
2012-07-10 16:22 ` Michal Hocko [this message]
2012-07-10 16:22 ` Michal Hocko
2012-07-10 16:22 ` Michal Hocko
2012-07-05 0:45 ` [patch 09/11] mm: memcg: split swapin charge function into private and public part Johannes Weiner
2012-07-05 0:45 ` Johannes Weiner
2012-07-09 2:55 ` Kamezawa Hiroyuki
2012-07-09 2:55 ` Kamezawa Hiroyuki
2012-07-09 2:55 ` Kamezawa Hiroyuki
2012-07-09 15:28 ` Michal Hocko
2012-07-09 15:28 ` Michal Hocko
2012-07-09 15:28 ` Michal Hocko
2012-07-05 0:45 ` [patch 10/11] mm: memcg: only check swap cache pages for repeated charging Johannes Weiner
2012-07-05 0:45 ` Johannes Weiner
2012-07-09 3:26 ` Kamezawa Hiroyuki
2012-07-09 3:26 ` Kamezawa Hiroyuki
2012-07-09 15:32 ` Michal Hocko
2012-07-09 15:32 ` Michal Hocko
2012-07-05 0:45 ` [patch 11/11] mm: memcg: only check anon swapin page charges for swap cache Johannes Weiner
2012-07-05 0:45 ` Johannes Weiner
2012-07-09 3:44 ` Kamezawa Hiroyuki
2012-07-09 3:44 ` Kamezawa Hiroyuki
2012-07-09 3:44 ` Kamezawa Hiroyuki
2012-07-09 15:34 ` Michal Hocko
2012-07-09 15:34 ` Michal Hocko
2012-07-09 15:34 ` Michal Hocko
2012-07-09 15:35 ` [patch 00/11] mm: memcg: charge/uncharge improvements Michal Hocko
2012-07-09 15:35 ` Michal Hocko
2012-07-09 15:35 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710162249.GA29114@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwp.linux@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.