[PATCH] SH: Convert out[bwl] macros to inline functions

[PATCH] SH: Convert out[bwl] macros to inline functions

[minyard]

From: Corey Minyard <cminyard@mvista.com>

The macros just called BUG(), but that results in unused variable
warnings all over the place, like in the IPMI driver.  The build
regression emails were annoying me, so here's the fix.  I have
not even compile tested this, but it's rather obvious.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 arch/sh/include/asm/io_noioport.h |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/arch/sh/include/asm/io_noioport.h b/arch/sh/include/asm/io_noioport.h
index e136d28..8cf7084 100644
--- a/arch/sh/include/asm/io_noioport.h
+++ b/arch/sh/include/asm/io_noioport.h
@@ -19,9 +19,20 @@ static inline u32 inl(unsigned long addr)
 	return -1;
 }
 
-#define outb(x, y)	BUG()
-#define outw(x, y)	BUG()
-#define outl(x, y)	BUG()
+static inline void outb(unsigned char x, unsigned int port)
+{
+	BUG();
+}
+
+static inline void outw(unsigned short x, unsigned int port)
+{
+	BUG();
+}
+
+static inline void outl(unsigned int x, unsigned int port)
+{
+	BUG();
+}
 
 #define inb_p(addr)	inb(addr)
 #define inw_p(addr)	inw(addr)
-- 
1.7.4.1

[PATCH] SH: Convert out[bwl] macros to inline functions

[minyard]

From: Corey Minyard <cminyard@mvista.com>

The macros just called BUG(), but that results in unused variable
warnings all over the place, like in the IPMI driver.  The build
regression emails were annoying me, so here's the fix.  I have
not even compile tested this, but it's rather obvious.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 arch/sh/include/asm/io_noioport.h |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/arch/sh/include/asm/io_noioport.h b/arch/sh/include/asm/io_noioport.h
index e136d28..8cf7084 100644
--- a/arch/sh/include/asm/io_noioport.h
+++ b/arch/sh/include/asm/io_noioport.h
@@ -19,9 +19,20 @@ static inline u32 inl(unsigned long addr)
 	return -1;
 }
 
-#define outb(x, y)	BUG()
-#define outw(x, y)	BUG()
-#define outl(x, y)	BUG()
+static inline void outb(unsigned char x, unsigned int port)
+{
+	BUG();
+}
+
+static inline void outw(unsigned short x, unsigned int port)
+{
+	BUG();
+}
+
+static inline void outl(unsigned int x, unsigned int port)
+{
+	BUG();
+}
 
 #define inb_p(addr)	inb(addr)
 #define inw_p(addr)	inw(addr)
-- 
1.7.4.1

Re: [PATCH] SH: Convert out[bwl] macros to inline functions

[Paul Mundt]

On Mon, Jul 09, 2012 at 03:35:20PM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> The macros just called BUG(), but that results in unused variable
> warnings all over the place, like in the IPMI driver.  The build
> regression emails were annoying me, so here's the fix.  I have
> not even compile tested this, but it's rather obvious.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>

Builds fine, I've switched the port type to unsigned long, but it looks
good otherwise. Will queue it up for -rc7, thanks.

Re: [PATCH] SH: Convert out[bwl] macros to inline functions

[Paul Mundt]

On Mon, Jul 09, 2012 at 03:35:20PM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> The macros just called BUG(), but that results in unused variable
> warnings all over the place, like in the IPMI driver.  The build
> regression emails were annoying me, so here's the fix.  I have
> not even compile tested this, but it's rather obvious.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>

Builds fine, I've switched the port type to unsigned long, but it looks
good otherwise. Will queue it up for -rc7, thanks.