From: Thierry Reding <thierry.reding@avionic-design.de> To: Simon Glass <sjg@chromium.org> Cc: Stephen Warren <swarren@nvidia.com>, Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>, U-Boot Mailing List <u-boot@lists.denx.de>, Jerry Van Baren <vanbaren@cideas.com>, Alex Courbot <acourbot@nvidia.com>, Tom Warren <twarren@nvidia.com> Subject: Re: [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra Date: Thu, 12 Jul 2012 10:40:51 +0200 [thread overview] Message-ID: <20120712084051.GA27022@avionic-0098.adnet.avionic-design.de> (raw) In-Reply-To: <CAPnjgZ0Lv2rjVzNottsY+NWYmred5Au+hebUuTTOSAJufTkLjA@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 2872 bytes --] On Thu, Jul 12, 2012 at 10:21:01AM +0200, Simon Glass wrote: > Hi Thierry, > > On Wed, Jul 11, 2012 at 7:48 AM, Thierry Reding > <thierry.reding@avionic-design.de> wrote: > > On Wed, Jul 11, 2012 at 06:44:10AM +0200, Simon Glass wrote: > >> Hi Stephen, > >> > >> On Fri, Jun 15, 2012 at 1:32 AM, Stephen Warren <swarren@wwwdotorg.org>wrote: > >> > >> > On 06/13/2012 10:19 AM, Simon Glass wrote: > >> > > Add LCD definitions and also a proposed binding for LCD displays. > >> > > > >> > > The PWFM is in progress on the device-tree-discuss list, so only a > >> > > very basic binding is offered here. > >> > > >> > I believe we have settled on a final representation, it just hasn't been > >> > added into linux-next yet. See: > >> > > >> > > >> > http://gitorious.org/linux-pwm/linux-pwm/commit/d3ce73e5dc86646a6302f2b0f7dd40e8c552fa04 > >> > >> > >> Thanks for the pointer. I suppose this doesn't address clocks as yet, but > >> that's fine. > > > > I was waiting for the common clock framework and DT bindings to get > > ready. This should happen RSN for Tegra so I will probably look at > > adding support for it in. > > OK, are you looking at adding it in U-Boot? No. I don't have much time to spend on U-Boot right now. [...] > I also need a place to put the pwm and GPIOs for the panel itself. > Something like this: > > nvidia,pwm = <&pwm 2 0>; > nvidia,backlight-enable-gpios = <&gpio 28 0>; /* PD4 */ > nvidia,lvds-shutdown-gpios = <&gpio 10 0>; /* PB2 */ > nvidia,backlight-vdd-gpios = <&gpio 176 0>; /* PW0 */ > nvidia,panel-vdd-gpios = <&gpio 22 0>; /* PC6 */ > nvidia,panel-timings = <4 203 17 15>; (number of ms before turning > on the next gpio) > nvidia,bits-per-pixel = <16>; (er, TBD) > > I am thinking of something like a phandle in your rgb node: > > host1x { > dc@54200000 { > rgb { > nvidia-panel = <&lcd_panel>; > ... > > lcd_panel: panel { > nvidia,pwm = <&pwm 2 0>; > ... > } > > Or have you already solved this problem another way? Linux has a generic PWM backlight driver. This is currently solved by using this in the DT: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 5000000>; brightness-levels = <0 4 8 16 32 64 128 255>; default-brightness-level = <6>; }; Alex Courbot (Cc'd) has been working on adding a generic way to add GPIO and regulator support to that. I don't know exactly what the lvds-shutdown-gpios and panel-vdd-gpios properties do. If they control hardware connected behind the display controller I suppose they could go into the rgb node. The panel alternative that you propose sounds interesting as well. Maybe the panel should itself contain either a phandle or a subnode for the backlight and collect the properties that you listed above. Thierry [-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 134 bytes --] _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra Date: Thu, 12 Jul 2012 10:40:51 +0200 [thread overview] Message-ID: <20120712084051.GA27022@avionic-0098.adnet.avionic-design.de> (raw) In-Reply-To: <CAPnjgZ0Lv2rjVzNottsY+NWYmred5Au+hebUuTTOSAJufTkLjA@mail.gmail.com> On Thu, Jul 12, 2012 at 10:21:01AM +0200, Simon Glass wrote: > Hi Thierry, > > On Wed, Jul 11, 2012 at 7:48 AM, Thierry Reding > <thierry.reding@avionic-design.de> wrote: > > On Wed, Jul 11, 2012 at 06:44:10AM +0200, Simon Glass wrote: > >> Hi Stephen, > >> > >> On Fri, Jun 15, 2012 at 1:32 AM, Stephen Warren <swarren@wwwdotorg.org>wrote: > >> > >> > On 06/13/2012 10:19 AM, Simon Glass wrote: > >> > > Add LCD definitions and also a proposed binding for LCD displays. > >> > > > >> > > The PWFM is in progress on the device-tree-discuss list, so only a > >> > > very basic binding is offered here. > >> > > >> > I believe we have settled on a final representation, it just hasn't been > >> > added into linux-next yet. See: > >> > > >> > > >> > http://gitorious.org/linux-pwm/linux-pwm/commit/d3ce73e5dc86646a6302f2b0f7dd40e8c552fa04 > >> > >> > >> Thanks for the pointer. I suppose this doesn't address clocks as yet, but > >> that's fine. > > > > I was waiting for the common clock framework and DT bindings to get > > ready. This should happen RSN for Tegra so I will probably look at > > adding support for it in. > > OK, are you looking at adding it in U-Boot? No. I don't have much time to spend on U-Boot right now. [...] > I also need a place to put the pwm and GPIOs for the panel itself. > Something like this: > > nvidia,pwm = <&pwm 2 0>; > nvidia,backlight-enable-gpios = <&gpio 28 0>; /* PD4 */ > nvidia,lvds-shutdown-gpios = <&gpio 10 0>; /* PB2 */ > nvidia,backlight-vdd-gpios = <&gpio 176 0>; /* PW0 */ > nvidia,panel-vdd-gpios = <&gpio 22 0>; /* PC6 */ > nvidia,panel-timings = <4 203 17 15>; (number of ms before turning > on the next gpio) > nvidia,bits-per-pixel = <16>; (er, TBD) > > I am thinking of something like a phandle in your rgb node: > > host1x { > dc at 54200000 { > rgb { > nvidia-panel = <&lcd_panel>; > ... > > lcd_panel: panel { > nvidia,pwm = <&pwm 2 0>; > ... > } > > Or have you already solved this problem another way? Linux has a generic PWM backlight driver. This is currently solved by using this in the DT: backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 5000000>; brightness-levels = <0 4 8 16 32 64 128 255>; default-brightness-level = <6>; }; Alex Courbot (Cc'd) has been working on adding a generic way to add GPIO and regulator support to that. I don't know exactly what the lvds-shutdown-gpios and panel-vdd-gpios properties do. If they control hardware connected behind the display controller I suppose they could go into the rgb node. The panel alternative that you propose sounds interesting as well. Maybe the panel should itself contain either a phandle or a subnode for the backlight and collect the properties that you listed above. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120712/9de88e00/attachment.pgp>
next prev parent reply other threads:[~2012-07-12 8:40 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-13 16:19 [U-Boot] [PATCH v2 0/19] tegra: Add display driver and LCD support for Seaboard Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 01/19] Add gpio_request() to asm-generic header Simon Glass 2012-09-21 19:30 ` Anatolij Gustschin 2012-09-27 20:58 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 05/19] tegra: Use const for pinmux_config_pingroup/table() Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 06/19] tegra: Add display support to funcmux Simon Glass 2012-06-14 23:24 ` Stephen Warren 2012-07-11 3:48 ` Simon Glass 2012-06-13 16:19 ` [PATCH v2 07/19] tegra: fdt: Add LCD definitions for Tegra Simon Glass 2012-06-13 16:19 ` [U-Boot] " Simon Glass 2012-06-14 23:32 ` Stephen Warren 2012-06-14 23:32 ` [U-Boot] " Stephen Warren 2012-07-11 4:44 ` Simon Glass 2012-07-11 4:44 ` [U-Boot] " Simon Glass 2012-07-11 5:48 ` Thierry Reding 2012-07-11 5:48 ` [U-Boot] " Thierry Reding 2012-07-12 8:21 ` Simon Glass 2012-07-12 8:21 ` [U-Boot] " Simon Glass 2012-07-12 8:40 ` Thierry Reding [this message] 2012-07-12 8:40 ` Thierry Reding 2012-07-12 9:22 ` Alex Courbot 2012-07-12 9:22 ` [U-Boot] " Alex Courbot 2012-06-13 16:19 ` [U-Boot] [PATCH v2 08/19] tegra: Add support for PWFM Simon Glass 2012-06-14 23:35 ` Stephen Warren 2012-07-11 4:45 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 09/19] tegra: Add SOC support for display/lcd Simon Glass 2012-06-14 23:39 ` Stephen Warren [not found] ` <CAPnjgZ2bqPx+dHD9m+NuFrAbBeP1PQxHokLMwvD1-3OnC6ZHtg@mail.gmail.com> 2012-07-11 5:12 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 10/19] tegra: Add LCD driver Simon Glass 2012-06-14 23:45 ` Stephen Warren 2012-07-11 4:56 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 11/19] tegra: Add LCD support to Nvidia boards Simon Glass 2012-06-14 23:47 ` Stephen Warren 2012-07-11 4:58 ` Simon Glass 2012-07-23 20:25 ` Stephen Warren 2012-09-27 19:15 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 12/19] arm: Add control over cachability of memory regions Simon Glass 2012-06-14 23:49 ` Stephen Warren 2012-07-11 5:01 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 13/19] lcd: Add CONFIG_LCD_ALIGNMENT to select frame buffer alignment Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 14/19] lcd: Add support for flushing LCD fb from dcache after update Simon Glass 2012-06-14 23:51 ` Stephen Warren 2012-07-11 5:06 ` Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 15/19] tegra: Align LCD frame buffer to section boundary Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 16/19] tegra: Support control of cache settings for LCD Simon Glass [not found] ` <1339604395-6621-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2012-06-13 16:19 ` [PATCH v2 02/19] fdt: Add debugging to fdtdec_get_int/addr() Simon Glass 2012-06-13 16:19 ` [U-Boot] " Simon Glass 2012-09-21 19:39 ` Anatolij Gustschin 2012-09-21 19:56 ` Anatolij Gustschin 2012-06-13 16:19 ` [PATCH v2 03/19] fdt: Add function to look up a phandle's register address Simon Glass 2012-06-13 16:19 ` [U-Boot] " Simon Glass 2012-06-14 23:17 ` Stephen Warren 2012-06-14 23:17 ` [U-Boot] " Stephen Warren 2012-07-11 5:10 ` Simon Glass 2012-07-11 5:10 ` [U-Boot] " Simon Glass 2012-06-13 16:19 ` [PATCH v2 04/19] fdt: Add header guard to fdtdec.h Simon Glass 2012-06-13 16:19 ` [U-Boot] " Simon Glass 2012-06-13 16:19 ` [PATCH v2 17/19] tegra: fdt: Add LCD definitions for Seaboard Simon Glass 2012-06-13 16:19 ` [U-Boot] " Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 18/19] lcd: Add CONSOLE_SCROLL_LINES option to speed console Simon Glass 2012-06-13 16:19 ` [U-Boot] [PATCH v2 19/19] tegra: Enable display/lcd support on Seaboard Simon Glass 2012-06-13 22:57 ` [U-Boot] [PATCH v2 0/19] tegra: Add display driver and LCD support for Seaboard Stephen Warren 2012-06-13 23:03 ` Stephen Warren 2012-06-13 23:09 ` Stephen Warren 2012-06-25 21:03 ` Tom Warren 2012-06-27 5:11 ` Simon Glass 2012-07-11 10:04 ` Simon Glass
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120712084051.GA27022@avionic-0098.adnet.avionic-design.de \ --to=thierry.reding@avionic-design.de \ --cc=acourbot@nvidia.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=sjg@chromium.org \ --cc=swarren@nvidia.com \ --cc=twarren@nvidia.com \ --cc=u-boot@lists.denx.de \ --cc=vanbaren@cideas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.