All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] h8300-uaccess-remove-assignment-to-__gu_val-in-unhandled-case-of-get_user.patch removed from -mm tree
@ 2012-07-12 19:36 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2012-07-12 19:36 UTC (permalink / raw)
  To: geert, tony, ysato, mm-commits


The patch titled
     Subject: h8300/uaccess: remove assignment to __gu_val in unhandled case of get_user()
has been removed from the -mm tree.  Its filename was
     h8300-uaccess-remove-assignment-to-__gu_val-in-unhandled-case-of-get_user.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: h8300/uaccess: remove assignment to __gu_val in unhandled case of get_user()

__gu_val is const if the passed ptr is const, giving:

include/linux/pagemap.h: In function 'fault_in_pages_readable':
include/linux/pagemap.h:442:2: error: assignment of read-only variable '__gu_val'
include/linux/pagemap.h:448:4: error: assignment of read-only variable '__gu_val'
include/linux/pagemap.h: In function 'fault_in_multipages_readable':
include/linux/pagemap.h:499:3: error: assignment of read-only variable '__gu_val'
include/linux/pagemap.h:508:3: error: assignment of read-only variable '__gu_val'
make[4]: *** [init/main.o] Error 1

As we don't care about the actual value of __gu_val in the unhandled
case (it will cause a link error anyway), just remove the assignment.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/h8300/include/asm/uaccess.h |    1 -
 1 file changed, 1 deletion(-)

diff -puN arch/h8300/include/asm/uaccess.h~h8300-uaccess-remove-assignment-to-__gu_val-in-unhandled-case-of-get_user arch/h8300/include/asm/uaccess.h
--- a/arch/h8300/include/asm/uaccess.h~h8300-uaccess-remove-assignment-to-__gu_val-in-unhandled-case-of-get_user
+++ a/arch/h8300/include/asm/uaccess.h
@@ -100,7 +100,6 @@ extern int __put_user_bad(void);
 	break;							\
     default:							\
 	__gu_err = __get_user_bad();				\
-	__gu_val = 0;						\
 	break;							\
     }								\
     (x) = __gu_val;						\
_

Patches currently in -mm which might be from geert@linux-m68k.org are

origin.patch
linux-next.patch
frv-kill-used-but-uninitialized-variable.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-12 19:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-12 19:36 [merged] h8300-uaccess-remove-assignment-to-__gu_val-in-unhandled-case-of-get_user.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.